Discussion: Find and Download Subtitles (1 Viewer)

morpheus_xx

Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,752
    7,115
    Home Country
    Germany Germany
    Country flag
    We need to check how this filter behaves in derived players: like TsVideoPlayer (TsReader) uses DvbSub3 for rendering subs. Same for DVD, BD.

    So if it conflicts with any specialized player, we should add a field to enable/disable subfilter loading.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,982
    3,703
    Stuttgart
    Home Country
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #13
    I found the setting "EnableSubtitles" on the VideoSettings class, but it is currently only shown for the DVPlayer in the Configuration Screen.
    I wanted to use this to control if subtitle filter should be loaded or not when building the graph.
    Funny thing is that the same setting is later used in the VideoPlayer for the ISubtitlePlayer implementation ;)

    Should we put the subtitle settings more global, meaning in the players category directly? Or do we need the same subtitle settings (enabled, default lang) for each player separately?
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,567
    10,387
    France
    Home Country
    France France
    Country flag
    About that :
    Could be nice to implement a good way of subtitle support. Video render needs to support it so DXVA can be used, it seems xy-VSFilter has an interface for that
    MPC-HC has already code for the subtitle consumer part, so it wont be too dificult for MP2 EVR renderer to be modified (Hopping :) )
     

    jehe

    Test Group
  • Team MediaPortal
  • February 15, 2011
    694
    216
    55
    Home Country
    Belgium Belgium
    Country flag
    Hi,
    Is there already a subtitle plugin that we can use / test?
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,752
    7,115
    Home Country
    Germany Germany
    Country flag
    I have currently no plans on this topic. For me personally this is not an important topic for nearest future. There are much more important features like plugin/extension handling which is unfinished and nobody cares about it :(

    But I take and review patches from other devs :)
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,982
    3,703
    Stuttgart
    Home Country
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #19
    OT:
    Large parts of the extension handling code were done by a different user. There's quite a bit of refactoring in it and it is a lot of code to go through and understand before one can even see what needs to be done. You cannot expect anyone to happily jump onto a task like that. It is much easier to start fresh with small problem/bug/missing feature. Most of us only have limited time, so working on smaller tasks is much preferred. I knew from the beginning that an undertaking of that magnitude had the danger of never being finished when the dev gets caught up in real life again.

    Even if you think of plugin handling as an important feature, and personally don't have any use for subtitles - I would still call it important to enable MP2 to display subtitles out of the box. Many countries do not dub the audio and simply leave the original audio with subs in the country's language. Then we also have hearing impaired people that are forced to read dialog. Another thing are movies with foreign parts spoken in foreign language where forced subtitles need to be shown. So IMHO subtitles out of the box is more important than e.g. Lastest Media and Right to Left support ;) As you can see, every dev has a different view on what is "important". Which is fine - but I was hoping to still be able to ask questions how to implement something and get an answer before I go ahead and implement it the way I think it should be done and afterwards get opinions that it should be done differently - very frustrating.


    Back to Topic:
    This thread started out with finding subtitles and since we discovered that MP2 does not yet handle subtitles out of the box, I started to implemented that part first by including the xy-SubFilter.
    You shared concerns about BluRay,DVD,TS Players (which I mentioned should not be a problem).
    Then I asked a question:
    Should we put the subtitle settings more global, meaning in the players category directly? Or do we need the same subtitle settings (enabled, default lang) for each player separately?

    And then the topic froze :(
    Whom if not the lead dev should I expect to answer, because you are the one that will decide if my code goes to master or not?
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,752
    7,115
    Home Country
    Germany Germany
    Country flag
    First, I didn't know (or remembered) that there was an open question. Also being in few days of vacation with trying not to think about coding didn't help in this question. And honestly, where the setting is put in the end doesn't influence the implementation so much.

    I think one setting for subtitle handling is enough, we should now overload configuration too much.

    Do you know already how the subtitles will finally get rendered? Does the xy-Subfilter does this alone during video decoding (DXVA?) or do we need to draw the subs onto the video frame as we do for DVB subtitles?
     

    Users who are viewing this thread

    Similar threads

    This is not possible if it is a self made series, like personal travel videos etc.
    This is not possible if it is a self made series, like personal travel videos etc.
    Hi! I have videos that I want to show in TV-Series, such as personal TV series and educational series. As some examples I have...
    Replies
    8
    Views
    485
    It is looking and working very well now and I am almost at the point of switching my HTPC to MP2, madvr would definitely push me over the edge for sure.;)
    It is looking and working very well now and I am almost at the point of switching my HTPC to MP2, madvr would definitely push me...
    We are proud to present MediaPortal 2.3 MediaPortal 2.3 is a full-blown media center software that addresses the most common user...
    Replies
    4
    Views
    2K
    Hello @aspik, thanks for that screenshot! Now I finally understand where to enable 'ATSC Closed Captions' -- not in the right-click Player configuration menu > Subtitle but in Settings > Players > Video player > Subtitles. And yes by enabling the option there, ATSC subtitles are indeed being shown in my local OTA streams. Player...
    Hello @aspik, thanks for that screenshot! Now I finally understand where to enable 'ATSC Closed Captions' -- not in the...
    MediaPortal 2 Version: 2.2.2 Description From a previous bug report for MP 2.2.1 here: [fixed] - [MP2-611] Having problems with...
    Replies
    2
    Views
    460
    We are proud to present MediaPortal 2.3.1 MediaPortal 2.3.1 is a full-blown media center software that addresses the most common user requirements out of the box. Aside from its support for Live TV and Radio, it offers a complete media server for music, movies, and TV shows. Info is automatically downloaded from various sources to...
    We are proud to present MediaPortal 2.3.1 MediaPortal 2.3.1 is a full-blown media center software that addresses the most common...
    We are proud to present MediaPortal 2.3.1 MediaPortal 2.3.1 is a full-blown media center software that addresses the most common...
    Replies
    0
    Views
    814
    Hi Lehmden Please forgive me for not making things clear, and ny the way, it's not you, your English is absolutely perfect. Europe ALWAYS puts us to shame when it comes to language because in UK "Education" we spend so long learning how wonderful the UK and its monarchy is we don't have time to learn the more important and useful...
    Hi Lehmden Please forgive me for not making things clear, and ny the way, it's not you, your English is absolutely perfect. Europe...
    Hi I am trying MP2 and getting on very well, finding the system more logical and very smooth now. The setup and configuration all...
    Replies
    10
    Views
    945
    Top Bottom