[Approved] Fix for MP #0002253 (1 Viewer)

[framug]

Thanks again for working on this issue. Your help really is appreciated.

Hi elliottmc and, thanks for your nice post, really apreciated.
Your proposals are also very good, maybe is it because of the age.

it is their computer and not ours!

What a pity but, I fully agree with you.

I agree with Chris that one way is to set it to go to home/basichome if the current folder is PIN protected.

Of course, I already agreed with too, this would be ideal.

However, as you have already done the code to go to the default folder, all you now need to do is add code to check if this is PIN protected and if so, THEN go to home.

Here is the problem :
To avoid the big dev explained above and also avoiding remove the "show last active module" functionality (It was not be nice for gibman), I choosed to propose the way to store the default folder when MP close, not on start.
Then, the code is at one place and, the next start is OK in all case, except the default pin protected folder with "remember last folder".
For fixing it in a proper way (I mean, not with a bad hack) and, if you don't want the 1/ proposal (I can understand it without problem, it's just because of a less dev cost) then, we have to intervene at all start events.

Regards.

 

[elliottmc]

Here is the problem :
To avoid the big dev explained above and also avoiding remove the "show last active module" functionality (It was not be nice for gibman), I choosed to propose the way to store the default folder when MP close, not on start.
Then, the code is at one place and, the next start is OK in all case, except the default pin protected folder with "remember last folder".
For fixing it in a proper way (I mean, not with a bad hack) and, if you don't want the 1/ proposal (I can understand it without problem, it's just because of a less dev cost) then, we have to intervene at all start events.

Regards.

I'm not sure I understand the problem.

Currently you store the default folder when MP closes.

Can you not simply do one of the following

1. Check if the default folder is PIN protected and if it is then store HOME instead.

2. Just store HOME

Thanks,

Mark

 

[framug]

I will think about it, if and when possible.
What can I say without trying : I'm pretty sure there will be problems in the next configuration launch with that because, MediaPortal.xml config file will not reflect what was set by the user.
(ie : checked box for default folder removed, etc...).

Edit : to be more precise, it's not the default folder wich is stored with previous patch, it's the last folder.
The first one param has others params dependencies (sharefolders).
The second, not.

Regards.

 

[elliottmc]

Hi,

If it is going to get more complicated, then I would go with Chris's suggestion.

If MP is in a PIN protected folder, then next time it starts up on home/basichome

I think this issue needs to be considered properly for development of MP2, to make sure the problem doesn't arise, but in terms of importance, this bug is relatively minor so if it can be fixed in an easy way then it should be.

Of course, I'm only a tester, so I'm just expressing an opinion.

Best wishes,

Mark

 

[framug]

Hello,
Since no devs feedback and light dev ended, here is code for the 1/ solution.
Screenshot 1 : Check default folder on a Pin protected folder.
Screenshot 2 : Fill a Pin code (by edit shares) in an already default checked folder.
Screenshot 3 : The following after the Screenshot 2 messagebox.
Feel free to use code, if you want.
Bye.

 

[elliottmc]

Hi,

Thanks for this. I will push to get this incorporated into SVN.

So, if I understand correctly, this does not allow you to select a PIN protected folder for default. Is that correct?

Best wishes,

Mark

 

[framug]

So, if I understand correctly, this does not allow you to select a PIN protected folder for default. Is that correct?

Good morning elliottmc,
Yes, absolutely then, the last error wich was still pending can't appear anymore.
Regards.

 

[infinite.loop]

If you ask me, then the current fix makes things more complex and confusing for the enduser.

In my opinion, MediaPortal should just start up at the homescreen if the last used folder required a pin protection.

 

[chemelli]

I agree with Chris.

Simone

 

[framug]

Well, I agree with you all.
The 1/ solution is not very user friendly for the end-user, finally.
Then, here is the 2/ solution.