[Approved] Fix for MP #0002253 (1 Viewer)

[elliottmc]

Dear Franck,

Thank you for this.

I will ask someone to test, and see if we can get this into SVN.

Best wishes,

Mark

 

[hwahrmann]

patch applied to SVN 23128. thanks for your support

 

[infinite.loop]

Sadly this codechange has a very bad sideeffect which i noticed very late.

1. add pin to a folder which is not the default
2. enter i.e. myvideos and go to the shares root view
3. select that pin protected share
4. select some folder inside that share
5. play a movie in that share
6. if you press "back" or "stop" or the movie just ends, then MP sends you right back to the "shares root".

And that should not happen. If you are inside a PIN protected folder and play something, then MP should not kick you back to the shares toot view.

 

[framug]

Hi,
No computer until 16th july.
You wrote it happen also when video play ended.
Testing isplaying is not correct then, I propose adding something indicate that the player has been called.
And, testing it to not go on root.
If MP devs agree with and, they don't have time to do it then, I will provide such patchs.
Bye.

 

[elliottmc]

Chris,

Could you please create a Mantis entry for this so that it doesn't get lost?

Thanks,

Mark

 

[infinite.loop]

Could you please create a Mantis entry for this so that it doesn't get lost?

I have re-opened the original mantis thread since the fix caused this sideeffect.

 

[framug]

fix sideeffect.

 

[elliottmc]

Anyone had time to check this out?

Thanks,

Mark

 

[elliottmc]

fix sideeffect.

Hi Framug,

Is this a single patch to fix everything in Mantis 2253? If not, could you please provide me with a single complete patch and I will do the testing? I'm not very experienced at compiling MP, so I need it made as easy as possible.

A patch based on the current SVN would be great.

Best wishes,

Mark

 

[framug]

Is this a single patch to fix everything in Mantis 2253?

Hi elliottmc,
Yes, this patch fix the last sideeffect still remaining in myvideos.
After own tests, it doesn't appear neither on mymusic, nor in mypicture.
Therefore, if MP devs prefer to harmonize others classes, I will provide it, also.

could you please provide me with a single complete patch and I will do the testing?

What do you mean, you would like to have a specific WindowPlugins.dll for testing it ?

A patch based on the current SVN would be great.

Class has not been changed since last time therefore, here is a patch for latest public SVN

Bests regards.