[Fixed] Incorrect series gets matched (Betrayal -> Betrayal!)

Discussion in 'My TVSeries' started by kiwijunglist, April 18, 2015.

  1. kiwijunglist
    • Team MediaPortal

    kiwijunglist Super Moderator

    Joined:
    June 10, 2008
    Messages:
    6,741
    Likes Received:
    1,416
    Occupation:
    Doctor
    Location:
    New Zealand
    Ratings:
    +1,845 / 9
    Home Country:
    New Zealand New Zealand
    Show System Specs
    I think I found a bug.

    Try making a dummy file called "Betrayal - S01E01 - Pilot.mkv"

    tvseries should match to
    "Betrayal" - http://thetvdb.com/?tab=series&id=269647

    instead if matches to
    "Betrayal!" - http://thetvdb.com/?tab=series&id=251167

    if I try to select correct match in tvseries configuration I get an error.



    Is anyone able to add this dummy file and have mytvseries download the images, it seems to also fail on my machines.
     
    • Agree Agree x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,451
    Likes Received:
    4,231
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,371 / 0
    Home Country:
    Australia Australia
    I can reproduce the incorrect match, im just looking into it now incase I introduced it or if it's always been like that.

    I can't reproduce any error when selecting the correct match though.
     
  4. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,451
    Likes Received:
    4,231
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,371 / 0
    Home Country:
    Australia Australia
    Good news is that it's always been like that, I reverted all changes to the method that creates and sorts the list of matches and it had the same result.

    I have an idea why it's happening, when it compares the results from the search it strips special characters from the title. So I think Betrayal! becomes Betrayal and gets a equal or possible better weighting later on when it does further checks.

    I will see what I can do.
     
  5. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,451
    Likes Received:
    4,231
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,371 / 0
    Home Country:
    Australia Australia
    The following characters are removed from the local parsed series name and the ones to match against from the online search:
    Code (Text):
    1.  
    2.   /// <summary>
    3.   /// ASCII chars that are considered "special" in the context of CleanStringOfSpecialChars
    4.   /// </summary>
    5.   static int[] specialCharsFromTo = new int[] { 0,  31,
    6.   33,  47,
    7.   58,  64,
    8.   91,  96,
    9.   123, 127 };
    10.  
    '33' represents an exclamation mark and if that is removed from the cleaning then it will match up perfectly. It probably makes sense to remove 33 from the cleaning as an exclamation is a valid filename character.
     
    • Agree Agree x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!