[Fixed] Incorrect series gets matched (Betrayal -> Betrayal!) (1 Viewer)

kiwijunglist

Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,749
    New Zealand
    New Zealand New Zealand
    Country flag
    I think I found a bug.

    Try making a dummy file called "Betrayal - S01E01 - Pilot.mkv"

    tvseries should match to
    "Betrayal" - http://thetvdb.com/?tab=series&id=269647

    instead if matches to
    "Betrayal!" - http://thetvdb.com/?tab=series&id=251167

    if I try to select correct match in tvseries configuration I get an error.

    Is anyone able to add this dummy file and have mytvseries download the images, it seems to also fail on my machines.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,687
    7,062
    Sydney
    Australia Australia
    Country flag
    I can reproduce the incorrect match, im just looking into it now incase I introduced it or if it's always been like that.

    I can't reproduce any error when selecting the correct match though.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,687
    7,062
    Sydney
    Australia Australia
    Country flag
    Good news is that it's always been like that, I reverted all changes to the method that creates and sorts the list of matches and it had the same result.

    I have an idea why it's happening, when it compares the results from the search it strips special characters from the title. So I think Betrayal! becomes Betrayal and gets a equal or possible better weighting later on when it does further checks.

    I will see what I can do.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,687
    7,062
    Sydney
    Australia Australia
    Country flag
    The following characters are removed from the local parsed series name and the ones to match against from the online search:
    Code:
      /// <summary>
      /// ASCII chars that are considered "special" in the context of CleanStringOfSpecialChars
      /// </summary>
      static int[] specialCharsFromTo = new int[] { 0,  31,
      33,  47,
      58,  64,
      91,  96,
      123, 127 };
    '33' represents an exclamation mark and if that is removed from the cleaning then it will match up perfectly. It probably makes sense to remove 33 from the cleaning as an exclamation is a valid filename character.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    framug [Pending] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    framug [Approved] Fix Irtrans config bug Submit: code patches (MediaPortal/TV-Server/etc.) 4
    W [solved] [FIXED] Survivor season 40 not automatically matching My TVSeries 1
    P [solved] ATSC subtitles not fixed yet? General 2
    framug [Rejected] Fix PowerScheduler plugin for MP2 single seat Submit: Code Patches 9
    M [Pending] Fix for Inconsistent date display in TV Guide Submit: code patches (MediaPortal/TV-Server/etc.) 1
    doskabouter [Proposal] Merge PR Fix for source directory with spaces MediaPortal 1 15
    CyberSimian Fixes for Amped aMPed 5
    CyberSimian Fixes for Amped skin MediaPortal 1 10
    S Please bring back instantskip in seconds. Feature Requests 13
    S MP1 deploy/download redirect links for MS SQL and WMP links - maybe fix them? Website/Forum/Wiki Feedback 0
    W [solved] Incorrect audio being reported Moving Pictures 4
    framug LAVFilter 0.74.1 incorrect version Skins and Plugins Installer (MPEI) 8
    SpudR Incorrect Links Skins and Plugins Installer (MPEI) 15
    P 1080 X 1920 videos playing incorrectly General Support 5
    CyberSimian MP 1.20: Watched percent sometimes incorrect MediaPortal 1 47
    K Schedules Direct or Tuner Card Incorrect Station Electronic Program Guide 0
    G Q about scheduling weekly series when epg lists duplicate back to back episodes each week General Support 2
    P MP 2 - Request to add an additional TV series Filename protocal Feature Requests 0
    W Not finding/matching new series - thetvdb issue? My TVSeries 3
    T TV Series Configuration funktioniert nicht Plugins & Erweiterungen 15
    HTPCSourcer Missing series posters/banners MediaPortal 2 11
    T TV Series - can't connect to http://thetvdb.com/api General Support 4
    L TV-Series kein Import Plugins & Erweiterungen 6
    Megane MP TV-Series and MediaPortal 1.23 Regeszter Edition (and TVDB). My TVSeries 11
    Similar threads

























    Top Bottom