[Fixed] Incorrect series gets matched (Betrayal -> Betrayal!) (1 Viewer)

kiwijunglist

Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    I think I found a bug.

    Try making a dummy file called "Betrayal - S01E01 - Pilot.mkv"

    tvseries should match to
    "Betrayal" - http://thetvdb.com/?tab=series&id=269647

    instead if matches to
    "Betrayal!" - http://thetvdb.com/?tab=series&id=251167

    if I try to select correct match in tvseries configuration I get an error.

    Is anyone able to add this dummy file and have mytvseries download the images, it seems to also fail on my machines.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,751
    7,196
    Sydney
    Home Country
    Australia Australia
    I can reproduce the incorrect match, im just looking into it now incase I introduced it or if it's always been like that.

    I can't reproduce any error when selecting the correct match though.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,751
    7,196
    Sydney
    Home Country
    Australia Australia
    Good news is that it's always been like that, I reverted all changes to the method that creates and sorts the list of matches and it had the same result.

    I have an idea why it's happening, when it compares the results from the search it strips special characters from the title. So I think Betrayal! becomes Betrayal and gets a equal or possible better weighting later on when it does further checks.

    I will see what I can do.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,751
    7,196
    Sydney
    Home Country
    Australia Australia
    The following characters are removed from the local parsed series name and the ones to match against from the online search:
    Code:
      /// <summary>
      /// ASCII chars that are considered "special" in the context of CleanStringOfSpecialChars
      /// </summary>
      static int[] specialCharsFromTo = new int[] { 0,  31,
      33,  47,
      58,  64,
      91,  96,
      123, 127 };

    '33' represents an exclamation mark and if that is removed from the cleaning then it will match up perfectly. It probably makes sense to remove 33 from the cleaning as an exclamation is a valid filename character.
     

    Users who are viewing this thread

    Top Bottom