[Jira MP1-4730] MKV multiple video track support (1 Viewer)

[Sebastiii]

It seems ok on my side

Could you post a little sample ?

 

[Sebastiii]

It can be the regex expression that is maybe not correct if LAV is not in use :
Name = "V: 2D [eng] (h264 high L4.1, yuv420p, 1920x1080) [default]"
after regex it can :
streamName = "2D [h264 high L4.1, yuv420p, 1920x1080]"

The relevant part of code is :

public override string VideoType(int iStream) in \mediaportal\Core\Player\VideoPlayerVMR7.cs
and
private void ShowVideoStreamsMenu() in \mediaportal\WindowPlugins\Common.GUIPlugins\Video\GUIVideoFullscreen.cs

 

[Stéphane Lenclud]

Here is what I get:

 

[Sebastiii]

And LAV splitter was in use ?
Could you post your log ?
Thanks

 

[Sebastiii]

No need log : (if language is und (undetermined) for video track, it seems the regex take default as name)
Could you try to set language for video track ?

 

[Sebastiii]

I'm not really good with regex but the culprit part is there :
public override string VideoType(int iStream)

if (resultLAVF.Success)
      // check for LAVF response format, e.g.:
      // S: Title [Lang] (Info) when only Language in stream -> answer is S: Lang -> start to detect if [lang] is present if not replace Lang by ""
      {
        string lang_or_title = resultLAVF.Groups[1].Value;
        string lang = resultLAVF.Groups[2].Value;
        string info = resultLAVF.Groups[3].Value;
        if (!string.IsNullOrEmpty(info))
        {
          if (!string.IsNullOrEmpty(lang))
          {
            streamName = "" + lang_or_title + " [" + info + "]";
          }
          else
          {
            streamName = info;
          }
        }
        else if (string.IsNullOrEmpty(info))
        {
          streamName = regex.Replace(streamName, "").Trim();
        }
      }

 

[Stéphane Lenclud]

Yup, that what it is. Would be nice to patch the code.

 

[Stéphane Lenclud]

Too late for coding off to bed!

 

[Sebastiii]

Yep and related too :
public override string VideoLanguage(int iStream)

So what is the best result to get ? and after that need a good regex man lol

 

[Stéphane Lenclud]

I can regex.
So if the Language property is not present it assumes English so we don't get the bug.
The Language property has to be present and set to undefined. I guess that makes sense for a video track without burn-in.