Last.FM Rework and Auto DJ mode (2 Viewers)

[HomeY]

MP_lastfm_v8_1.5Pre_Master.zip added to 2nd post (since jameson_uk is incredibly busy).

This build is based on current master (1.5 Pre Release) and you should be able to upgrade to this build from 1.4 and when 1.5 is out, upgrade to that also.
I hope it's ok, since it throws an XML error at the moment, but that's because last.fm is down.

I tested it and Auto-DJ mode is working fine, just the announcing that fails off course

 

[The_Stig]

@HomeY, @jameson_uk, maybe time for a build for 1.5 Final? Would be great!

 

[HomeY]

maybe time for a build for 1.5 Final? Would be great!

I tried, but it throws a whole bunch of merge conflicts that need to be resolved first.

 

[HomeY]

First post updated with a new build based on 1.5 Final (TNX @Sebastiii for fixing the merge conflicts!)

 

[elliottmc]

Ready for 1.6.0 Pre Release?

 

[HomeY]

I've got a feeling that the BASS rework has broken AutoDJ feature.

When i manually skip to the next song i see that AutoDJ adds a new song, but when the song has ended, and it proceeds with the next 1 in the playlist, AutoDJ doesn't add a new song.
It seems that a skip to a next song triggers g_Player.OnStarted() but when a song has ended, and a new 1 starts, i don't see the g_Player.OnStarted() [Path_to_file.ext] show up in the logs.
@jameson_uk Does AutoDJ get triggered by g_Player.OnStarted() ?

merge windows for 1.6 Pre closes in 2 weeks and i would really like to see this get included. My music section can't live without it

 

[The_Stig]

i would really like to see this get included

Me desperately too!!!

 

[hwahrmann]

It seems that a skip to a next song triggers g_Player.OnStarted() but when a song has ended, and a new 1 starts, i don't see the g_Player.OnStarted() [Path_to_file.ext] show up in the logs.

If it relies on g_Player.OnStarted(), then it is most probably broken by the last change, which i did.
Since i am doing my own playback handling, without g_player, which Stops a song and the Starts the next one.

I haven't seen Mike for a while, but could fix it, if he doesn't show up.
I am about to leave fr business for the next 2 days, but can fix it later this week.

 

[HomeY]

TNX Helmut! Although i have to say that it's an assumption on my part that the AutoDJ function is triggered by g_player.OnStarted().
I just noticed that when i skip a song, this line shows up in the logs, and then the AutoDJ function adds a new song to my playlist.
When a song has ended, and a new 1 is started, i don't see the g_player line, and then also no new song is added to the playlist.

 

[hwahrmann]

Yes, it was related to g_player events not received.
Changed the code to listen also on BASS player events and it works now again.
From my view it is ready for 1.6 pre-release.