[MANTIS 4321] - SMS style disabled on keyboard in password-mode (1 Viewer)

[doskabouter]

MediaPortal Version: 1.3.0

Description
Just noticed that when typing a password with the virtual keyboard, the SMS style is disabled.
So you have to navigate to each letter on the VK to select that one, and that kind of defeats the need for displaying the typed letters with a '*'
Previously, in SMS style, you could press the number buttons enough times to get each letter, and it's much harder to see which, and how many times each number is pressed

Steps to Reproduce:
Navigate to something where a password is required (f.e. browsetheweb select the login button on the forumpage). It defaults to character mode, and no way to set it to SMS

 

[HomeY]

Confirmed, TNX for the report kabouter
Only need to figure out if this needs a new Mantis or we can combine this with the other issues we have with the keyboard. I assume fixing this would have priority, since SMS Style is completely broken.

** EDIT **
Somehow SMS Style is working when you do a search by title in the EPG. So now i'm wondering if it's the plugin or not. At least i can confirm that SMS style isn't accessible with BrowseTheWeb.

 

[doskabouter]

Sms style is also working from browsetheweb in non-password dialogs, and the only difference in calling VirtualKeyboard is setting the Password property to true or false

 

[HomeY]

http://mantis.team-mediaportal.com/view.php?id=4321

 

[doskabouter]

Hm, it seems to be a conscious decision:

		  if (Password) return; //sms is disabled during password input - we cannot see chars!

Committed by silentexception at 6/17/2011 with comments:
* 0003598: Improve identification of virtual keyboard input mode (SMS / standard)
0003502: pin code can not be entered by remote because SMS sytle keyboard is used by default
So perhaps reviewing those 2 mantisses and the new one, theoretically it should lead to a consensus

 

[doskabouter]

Pull request made (https://github.com/MediaPortal/MediaPortal-1/pull/18)

 

[HomeY]

@Developers ?

 

[jameson_uk]

Pull request made (https://github.com/MediaPortal/MediaPortal-1/pull/18)

Made a couple of comments on github. Main thing is the inclusion of lots of formatting changes. Any chance you could remove the formatting changes so we can see the actual changes (if you want / need formatting changes then have this as a separate commit)

 

[doskabouter]

Ok, will do.
What is the best way of doing this? I myself am thinking of a new branch, or should(can?) I delete the current branch and create a new one with the same name?

 

[jameson_uk]

Ok, will do.
What is the best way of doing this? I myself am thinking of a new branch, or should(can?) I delete the current branch and create a new one with the same name?

As it is a pull request it does not matter to us You can do either as it is in your repository
I will close the current pull request and you can either delete and re-create branch or create a new pull request or create a new pull request on a new branch name.

I would probably suggest the simplest way is to create a new branch based on current MP master and then make the change, push to your repository and create a pull request.