[solved] MiniDisplayPlugin: Support for latest iMON VFD/LCD drivers (4 Viewers)

[Stéphane Lenclud]

I created a JIRA issue to track that slow update problem: https://issues.team-mediaportal.com/browse/MP1-4403

 

[azzuro]

stéphane, in your Jira, don't forget to add all link inside it.
because in few month, very hard to found the thread. who the bug or rework is needed.

 

[edterbak]

Did a test of V3 which Seb posted on page 6: https://forum.team-mediaportal.com/...on-vfd-lcd-drivers.123863/page-6#post-1062269.

Results are fine! driver loads, no crash and correct DLL seems to be used


Did a playback trial, and its fine If there are any specific issues I should test on, please let me know.

 

[edterbak]

I noticed (also with the separate DLL version) when using Titan extended two the selected menu items dont show up correctly. It shows something like #menu... I don't know exactly. But its only with the titan main menu items using extended two. (my default) In any other plugin or selection it works fine.
I suspect this is actually a skin issue?

 

[Stéphane Lenclud]

I noticed (also with the separate DLL version) when using Titan extended two the selected menu items dont show up correctly. It shows something like #menu... I don't know exactly. But its only with the titan main menu items using extended two. (my default) In any other plugin or selection it works fine.
I suspect this is actually a skin issue?

Definitely a skin/minidisplay settings issue. Not a problem of that iMON plugin. I had similar problems at some point but did not dig into it. See that post.
Since I also noticed that MiniDisplay was working properly on the default skin after all. Is that an issue only with a certain variant of Titan?[DOUBLEPOST=1393669256][/DOUBLEPOST]Guys can we move this forward and merge to master?

 

[edterbak]

Is that an issue only with a certain variant of Titan?

yes, original titat, stock theme "extended two". ill inform skin dev. @ncoH

This night I will describe the thing propperly in the titan forum for you.

 

[Sebastiii]

@HTPC_Sourcer

Do you confirm using the new branch with old drivers is ok ?
Thanks

 

[Stéphane Lenclud]

@Developers
@Testers

Guys it's time to get that stuff on master.
The earlier it goes on master the more time we have to fix possible regressions before release.

JIRA:
https://issues.team-mediaportal.com/browse/MP1-4418

The code review is there:
https://github.com/MediaPortal/MediaPortal-1/pull/39/files
https://issues.team-mediaportal.com/fisheye/cru/MP1CR-405

If someone could just test that branch with a MiniDisplay driver that's not iMON that would be great.
Either checkout that branch and compile it or patch a 1.7.1 with the binaries provided there:
https://forum.team-mediaportal.com/...portal-1-1-3-1-2-1.95616/page-50#post-1080078

 

[Sebastiii]

Thanks for that

But that not fully true
We shouldn't use Master as testing branch but merge only stuff fully tested, so first it's to open an AREA51 thread (maybe already open) to have wider testing and then test regression and after that we can conclude that the branch is ready

Of course, it can happen that even with wider testing something can be missed but in practice, the branch ready to be merged should be near to perfect (read no regression).

Don't get me wrong here i'm just explain that we need to have good testing

 

[Stéphane Lenclud]

It has received a lot of testing from at least 5 MiniDisplay users plus myself. All that's left is code review and test another driver/display to check for regressions. I really don't see the point of opening yet another thread about that. All dev and testers should have already been informed and most interested users too. All that's left really is for someone with the authority to push a button and get it merged.
Hope we can get this sorted before Sunday.