[Finished] MP1-4777 Additional info for video and audio (3 Viewers)

[Sebastiii]

I have changed it by :

if (MediaInfo != null && m_speedRate == 5000 && MediaInfo.BestVideoStream.FrameRate == 24)

But i'm not sure if it's ok because, we can have multiple video stream (i suppose that all should be at the same framerate but maybe not)

 

[Sebastiii]

I don't think i'm on right way lol, better is, if you can try to merge the above branch and see if it's doable
There is change in mediaportal.cs too and i'm not sure where to put :
MediaInfo = new MediaInfoWrapper(strFile);

 

[Sebastiii]

If i change in g_player by adding back :

public static MediaInfoWrapper mediaInfo = null

After, i change :

var mediaInfo = new MediaInfoWrapper(strFile);
to
mediaInfo = new MediaInfoWrapper(strFile);

Then i can use now (in mediaportal.cs) :

if (g_Player.mediaInfo != null && g_Player.mediaInfo.BestVideoStream.FrameRate == 24)

 

[regeszter]

if (g_Player.mediaInfo != null && g_Player.mediaInfo.BestVideoStream.FrameRate == 24)

What is the BestVideoStream? I think we need the" currentstream".FrameRate for calculate the right frame rate for slow down.

 

[Sebastiii]

Need @yartat to confirm, i have take reference of other part of code, but i agree with you, it's surely not the right method to take or maybe if it is, that need to be renamed to currentstream.....

 

[Sebastiii]

@regeszter if you wanna try : https://github.com/Sebastiii/MediaPortal-1/tree/1.14.0Fork-BDJ_MediaInfo lol

 

[yartat]

Wow, you are one who wakes early. I like to sleep a long time
@regeszter are right we need to use currentstream.

var stream = CurrentVideoStream;
if (m_speedRate == 5000 && stream != null && stream.FrameRate == 24)

 

[Sebastiii]

Wow, you are one who wakes early. I like to sleep a long time
@regeszter are right we need to use currentstream.

var stream = CurrentVideoStream;
if (m_speedRate == 5000 && stream != null && stream.FrameRate == 24)

Yep but FrameRate are not available it seems

But for MediaPortal.cs how to handle it ? (it's not ok : https://forum.team-mediaportal.com/...or-video-and-audio.133856/page-3#post-1177498 ofc we need to use CurrentVideoStream too but need FrameRate to be implemented)

 

[Sebastiii]

And for ex : CurrentVideoStream in RTSPPlayer is not implemented :

    public override int CurrentVideoStream
    {
      get { throw new NotImplementedException(); }
      set { throw new NotImplementedException(); }
    }

So above code will not work, i think we should expose current mediainfo somewhere that can be used like i'm trying in
https://forum.team-mediaportal.com/...or-video-and-audio.133856/page-3#post-1177498

 

[yartat]

But for MediaPortal.cs how to handle it ? (it's not ok : https://forum.team-mediaportal.com/...or-video-and-audio.133856/page-3#post-1177498 ofc we need to use CurrentVideoStream too but need FrameRate to be implemented)

Sorry, CurrentVideo property, of course. Not CurrentVideoStream[DOUBLEPOST=1457173595][/DOUBLEPOST]

And for ex : CurrentVideoStream in RTSPPlayer is not implemented

I didn't find any usage of the RTSPPlayer in the Mediaportal project. It doesn't used in the PlayerFactory, it doesn't have any instancing in other parts (plugin, tests)