MP2 - V2.1 [MP2-558] 2.1pre Error in SlimTV3 (1 Viewer)

[morpheus_xx]

Thanks! I'll check later this evening.

 

[MrTechno]

Reworked again so AbstractSlimTvService is the message reciever. SlimTvServicePlugin is back the way it was before.

 

[morpheus_xx]

Seems like we are getting to somewhere

I'd like to think about the original idea of the commit by henso: the text reads that the SlimTV service keeps running in case of a crash: "Fix for TV service continuing on crash".

I'm not sure what "crash" means here: if the whole process dies due to an unhandled exception, we don't need to take care for cancelling start up at all.

If there is a handled exception, then a shutdown sequence happens. At some point the registered services are removed from service registration and disposed. When disposing the SlimTvService, a DeInit() happens and closes the main TV thread.

Next point: the original change introduced checks for system state in 6 places of the Init() method. I consider 5 of the as very fast, only the startup of real TV code in step 6 could take longer. So in my opinion it would be enough to:

1. Set a "_abortInit = true" if a system message of "shutdown" is received
2. Only check for "_aboutInit" before the 6th step and remove the other 5 ones

Does this makes sense?

 

[Brownard]

The original issue was @Lehmden's BSOD from TV tuner driver, it occurred after the server failed to start because of an incompatible database. IIRC the MP2 server was shuttling down gracefully but from the logs TV service was continuing to start regardless, it was only ever a hunch that this was leading to the BSOD.Though really I think the tuner driver is at fault as it shouldn't ever fail.

 

[morpheus_xx]

Thanks for clarification. In this case my proposable above should take care for this case quite well.

 

[MrTechno]

Does this makes sense?

I think so, except I counted seven system state checks.

Latest changes pushed.

 

[HTPCSourcer]

@MrTechno , is there already a Jira in place? The thread has no reference.

 

[MrTechno]

The thread has no reference

Sorry about that, I've pointed the JIRA at the threads but not vice versa. https://issues.team-mediaportal.com/browse/MP2-558

 

[MrTechno]

Is there a more formal process to do this, like adding the JIRA ID as a label to each bug report thread?

 

[HTPCSourcer]

Is there a more formal process to do this, like adding the JIRA ID as a label to each bug report thread?

Yes, there is! Check out the bug report section and you'll notice that I am adding the [MP2-xxx] in front of most of the reports.

I will appreciate everybody's support and discipline to do so for me, as my vacation is now over and I am returning to the office tomorrow morning... This will also help to avoid fruitless discussions of the kind "this bug is known for years" and then find out that it was never captured in Jira.