Multilingual Teletext patch (4 Viewers)

[dvdfreak]

The patch only changes this extremely minor thing:

     public TeletextPageRenderer()
     {
-      _isRegionalDK = (RegionInfo.CurrentRegion.Equals("DK"));
+      _isRegionalDK = (RegionInfo.CurrentRegion.TwoLetterISORegionName.Equals("DK", StringComparison.InvariantCultureIgnoreCase));
     }

Is that really all there is to it? I just wondered since I thought the character tables needed fixing etc...

 

[arion_p]

Yep, that's it! The character tables are correct. The detection of the current regional settings was not working. (RegionInfo.CurrentRegion is an object not a string and so is never equal to "DK")

Edit: This refers to the Danish teletext bug. The additional languages in teletext patch is unrelated and much bigger change - too big for me to try to adapt it for 4TR. :sorry:

 

[dvdfreak]

All right, how easy can it be

 

[dvdfreak]

The recompiled plugin below should contain the fix. Let me know if it now works OK.

The fix will be part of the 1.4.0.1 maintenance release.

 

[dvdfreak]

Edit: This refers to the Danish teletext bug. The additional languages in teletext patch is unrelated and much bigger change - too big for me to try to adapt it for 4TR. :sorry:

Ah OK, understood.

Have you ever considered trying out For The Record? ;-) Perhaps this could be motivating

In any case, I'll put this on our TODO list to look at this ourselves later on...

 

[providers]

It Works,
Thanks to both of you guys.


/Providers