[fixed] Multiple, duplicated network shares without doing anything (1 Viewer)

[morpheus_xx]

I will fine tune the build scripts a bit more to ensure nothing is being missed like calling RestorePackage no matter if building complete installer, client only or server only bin dir, but only call RestorePackage once, when full isntaller (client, server, servicemonitor is started).

Can we use this solution: http://docs.nuget.org/docs/workflows/using-nuget-without-committing-packages ?

 

[MJGraf]

Thanks, guys!
Just building it a second time helped (I never use any of the scripts to make an installer - I always open the Server / Client project in VS and rebuild the solution, which now seems to be necessary twice, at least after a fresh pull from github).

Attached is the patch (one line code change plus four lines of comments) as well as a Mediaportal.Utilities.dll, which was built against MP2 Alpha 2. The patch as well as this dll only contain the fix - no more extra logging.

@jimmyo could you please test with the attached dll? You can just keep it if it works...
@Lehmden would you be so kind and test the steps described above with the attached dll? The important thing is that still all the computers in your network are shown with this patch.

For me it works, just want to be sure...

If it's all ok, Morpheus, chefkoch, please feel free to merge the patch into github. I'll set the Jira issue to ready for testing in the meantime.

To all of you: Great teamwork here!
Michael

 

[Lehmden]

Hi.
For me the attached DLL is working exactly like the Original one..

 

[chefkoch]

I will fine tune the build scripts a bit more to ensure nothing is being missed like calling RestorePackage no matter if building complete installer, client only or server only bin dir, but only call RestorePackage once, when full isntaller (client, server, servicemonitor is started).

Can we use this solution: http://docs.nuget.org/docs/workflows/using-nuget-without-committing-packages ?

We already use this, but
quote from http://wiki.team-mediaportal.com/in...elopment/Building_&_Compiling/1_Build_Process

Why is this​ step separated?
The NuGet dependencies are also downloaded by the *.csproj itself, why is this separated process required?
Short Answer
Normally packages are downloaded after the project has been opened, but some packages have to be locally available even before the project is opened.
Detailed Answer
Some packages include a MSBuild targets file into the project that referenced the package. If the project is opened while the package and it's MSBuild tagets file do not exist yet, the target file is ignored. While compiling the project the referenced package is downloaded and the MSBuild file exists then, but the project does not call it as it has been ignored on project opening.
The project compiles fine and calls the MSBuild targets file after it has been reopened.

 

[jimmyo]

Tried the new dll and it works, can see all computers

Thanks for your work

 

[MJGraf]

Perfect, thanks! Ready to merge...