Music - missing coverart for songs (2 Viewers)

jameson_uk

Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    Can you please email me one of the tracks shown in that screenshot. (My forum name at team-mediaportal.com)

    Could you also please confirm that the two thumbs for 2 unlimited - hits unlimited are both valid and you can display them?
     

    vrm42

    Portal Pro
    April 24, 2007
    131
    28
    Home Country
    Hungary Hungary
    All thumbs are valid and can be displayed.

    Mail sent.
     

    Attachments

    • Untitled.jpg
      Untitled.jpg
      51.2 KB
    • Untitled1.jpg
      Untitled1.jpg
      48.3 KB
    • Untitled2.jpg
      Untitled2.jpg
      60.9 KB

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    From PM:
    Ok, I found. Having disabled creation of TV/Video thumbs causes this issue even in 1.2.1. So I guess this is a bug.
    I don’t want MP to create video thumbs...

    Can you just confirm you are talking about the
    "Autocreate Thumbs" option on this page ?
    Thumbnails - MediaPortal Wiki

    If not, what setting are you talking about?
     

    vrm42

    Portal Pro
    April 24, 2007
    131
    28
    Home Country
    Hungary Hungary
    Yes, "Autocreate Thumbs" option causes the problem when it is enabled.
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    OK notes for later...
    setting is called tvrecordedondemand in xml

    SetThumbs in Util.cs has
    Code:
            if (createVideoThumbs && !foundVideoThumb)
            {
              if (Path.IsPathRooted(item.Path) && IsVideo(item.Path) &&
                  !VirtualDirectory.IsImageFile(Path.GetExtension(item.Path).ToLower()))
              {
                Log.Debug("SetThumbnails: Thumbs for video (" + GetFilename(item.Path) +
                          ") not found. Creating a new video thumb...");
                // creating and starting a thread for potentially every file in a list is very expensive, we should use the threadpool
                //Thread extractVideoThumbThread = new Thread(GetVideoThumb)
                //{
                //  Name = "ExtractVideoThumb",
                //  IsBackground = true,
                //  Priority = ThreadPriority.Lowest
                //};
                //extractVideoThumbThread.Start(item);
                ThreadPool.QueueUserWorkItem(GetVideoThumb, item);
              }
              return;
            }
    at line 671 so this could affect music thumbs (this is called in music database and is also called in vitualdirectory class (shares view)

    But it looks like the one call in database view is never called so confused as to why this would make a different :confused:
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    I have been looking and I am 95% sure that setting for TV/video thumbs is not making a difference so it must be co-incidence that changing it fixed your issue. The code is simply not called anywhere I can see for music or GUI rendering code.

    The fact that this is still a problem after removing the music database and deleting all local thumbs and only resolved by a full clean install leads me to think there is possibly another setting somewhere which could be causing this.

    Someone previously mentioned that the scanning the video database might be causing an issue here.

    I need anyone who is experiencing this to report back on a few things
    • That this occurs in default skin in debug mode
    • Whether it occurs in shares view and/or database views
    • Whether they use the inbuilt video plugin
    • Whether this does not work in all layouts (list, icons, filmstrip...)
    • Whether when they select an item with no thumb showing one still shows as the big thumb on the left

    I am struggling to replicate this on three different machines (XP and Win7) so need some help to try and figure out where this is going wrong
     

    vrm42

    Portal Pro
    April 24, 2007
    131
    28
    Home Country
    Hungary Hungary
    "and only resolved by a full clean install "

    Actually a full clean install doesn't resolve this issue.
    After a clean install you have that video thumbnail creation option ENABLED by default, so you may think that issue is resolved. But it's not :(

    This is how I reproduce this issue at any time. Nothing more, nothing less:
    Let's assume that after a full mediaportal uninstall (3rd option in uninstaller) you have a clean machine.
    - Install MP on Win7 SP1, Prof, 32bit, English: MP language is English, no TV
    - Start Configurator, Autocreate thumbs in TV/Video section: uncheck
    - Set music folder*, create database
    - Close Configurator
    - Start MP... no thumbs for songs

    * I created a new folder on an other drive and copied over only one random album.

    OK, going to sandbox...

    Asus notebook, Intel CPU
    - format C: (really)
    .
    .
    .
    - all the steps above, and then... STILL NO THUMBS for songs!

    Which is good, because it means that I don't have to re-install my HTPC for this issue, but on the other hand...


    My offer still stands, you can check out everything by yourself with Teamviewer.
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    My offer still stands, you can check out everything by yourself with Teamviewer.

    That is really only going to show me what you have said in that thumbs are not showing and music is tagged correctly.

    I have done exactly as you have said here (using a clean VM image I have for testing MP) gone in, unticked that TV/Video thumb option then gone into music database and scanned. This works (I have 12 tracks per page so even with album with more than 12 tracks each item gets a thumb).

    Very confused as no doubt something is going on (hence the mantis to sort out loading music thumbs) but I simply can not replicate this on any of my machines :confused:
     

    vrm42

    Portal Pro
    April 24, 2007
    131
    28
    Home Country
    Hungary Hungary
    I'm just preparing a virtual box machine to reproduce the issue. If it will come up, I will be very confused too :)
     

    trepamuros

    Portal Pro
    December 2, 2008
    71
    2
    Home Country
    Spain Spain
    Not sure if I'm late, but I can confirm this issue in a totally fresh installation: Format - W7 - MP 1.2.1
    No thumbnails for songs in any album. Also, if I browse the album song list and I reach the end of the list and it loops, I get (not always) some thumbs for the first songs and some others for the last songs. If I go back and enter the same album again, thumbs are gone.

    Autocreate thumbs is disabled, and I deleted all the thumbs previously created.

    Recreated the music database several times, the issue persists.

    It is not skin-dependant, happens with default skin and StreamedMP.
     

    Users who are viewing this thread

    Top Bottom