Music Player Rework (2 Viewers)

[hwahrmann]

I'm not using any of those plugins.
What is the error? Maybe they are not compatible with version 1.3.0 at all?

Yes, this only adresses the Music section. It has nothing to do with Live TV or Video or any other section within MP.

 

[jameson_uk]

I'm not using any of those plugins.
What is the error? Maybe they are not compatible with version 1.3.0 at all?

Yes, this only adresses the Music section. It has nothing to do with Live TV or Video or any other section within MP.

reckon they might have a dependency on old BASS version (think it has its own player)

 

[l337]

thanks for the feedback

the problem is the plugin will not play title
no error message


works the plugin radio time ??????
could you test the plugin please i have uninstalled the build

 

[hwahrmann]

Link to new binaries in first post

Also not sure if this is an issue or not but it looks like some streams are not being cleaned up until MP is closed?

I've fixed the code, so the streams are disposed on the end of playback

So I have
Stereo 22kHz mp3 - Played in shared mode, note about more output channels than input channels
Stereo 44.1kHz mp3 - No mention of whether this was shared or exclusive mode and no mention of output / input channels (upmixing)
Stereo 48 kHz mp3 - Played in exclusive mode - note about more output channels than input channels
5.1 24 bit / 96 kHz FLAC - Played in shared mode, note about more output channels than input channels but then says it is creating a 2 channel mixer at 44.1 Khz ??

Not sure if this is just logging that is not quite right or something else but this is my dev laptop with output set to stereo 16bit 44.1 kHz and to allow exclusive mode. The only file that seemed to play in exclusive mode was the 48 kHz track but I am not sure why. Also as this is stereo it seems that the stereo and the 5.1 tracks have a more output than input channel message.

There is no way to ask the WASAPI driver on the amount of speakers supported, so i'll try to detect, what is actually attached.
I am also displaying now on the beginning, when initializing the device, the supported formats for Exclusive or Shared mode.

On start of playback, i am creating a mixer device, which is supporting the current stream. I might fall back to Shared mode, if the number of channels and sample rate can't be played in exclusive mode.
When the next track is to be played, i am checking, if the format is the same as the previous track.
If this is the case, i am using the same mixer stream, otherwise i am creating a new mixer stream.
This is why you see different messages in the logs.
I have added a few more log messages, to decribe better what is happening under the hood.

I was not able o reproduce your crash however, but will continue to find it.

 

[tourettes]

There is no way to ask the WASAPI driver on the amount of speakers supported, so i'll try to detect, what is actually attached.

Some drivers (but not all ) support querying the current speaker mask. MPAR doesnt use such info but it is logging it. Maybe it would be helpful?

[SIZE=3][FONT=Consolas][COLOR=#0000ff][SIZE=3][FONT=Consolas][COLOR=#0000ff][SIZE=3][FONT=Consolas][COLOR=#0000ff]if[/COLOR][/FONT][/SIZE][/COLOR][/FONT][/SIZE][/COLOR][/FONT][/SIZE][SIZE=3][FONT=Consolas][SIZE=3][FONT=Consolas] (pProps->GetValue(PKEY_AudioEndpoint_PhysicalSpeakers, &speakerMask) == [/FONT][/SIZE][/FONT][/SIZE][SIZE=3][FONT=Consolas][COLOR=#6f008a][SIZE=3][FONT=Consolas][COLOR=#6f008a][SIZE=3][FONT=Consolas][COLOR=#6f008a]S_OK[/COLOR][/FONT][/SIZE][/COLOR][/FONT][/SIZE][/COLOR][/FONT][/SIZE][SIZE=3][FONT=Consolas][SIZE=3][FONT=Consolas])[/FONT][/SIZE][/FONT][/SIZE]

http://msdn.microsoft.com/en-us/library/windows/desktop/dd316575(v=vs.85).aspx

On start of playback, i am creating a mixer device, which is supporting the current stream. I might fall back to Shared mode, if the number of channels and sample rate can't be played in exclusive mode.

Optimal solution would be to keep ourselves always in the exclusive mode (like MPAR does). Does't BASS have a mixer that can be used in exclusive mode? MPAR has own custom mixer code do allow the exclusive mode to be used always.

 

[hwahrmann]

Thanks, but if i am creating e.g. a stereo Mixer for 48khz in Exclusive mode, then any 44.1khz file would be resampled to that value.
This is exactly what current BASS soes. so we have permanent resampling.
Which is, what most of the people don't like.

 

[tourettes]

Thanks, but if i am creating e.g. a stereo Mixer for 48khz in Exclusive mode, then any 44.1khz file would be resampled to that value.
This is exactly what current BASS soes. so we have permanent resampling.
Which is, what most of the people don't like.

Of course we would need to try to use native / non-resampled output formats when ever the audio HW is able to play those. Resampling would be done only for the non-supported modes, but stil using exclusive mode. Shared mode is pretty bad since OS dictates what and how the resampling is done. So if user has stereo speaker setup then the result for 5.1 will be down mixed to stereo - even if the case is that audio HW doesn't just support the request bit depth or sampling rate with the channel setup.

We need to query from the audio drivers if they support some alternative bit depths or sampling rates for the specific channel layout that fails - and then let either BASS mixer or own custom mixing code to do the sample rate conversion and/or bit depth adaptation (just like MPAR does - there is plenty of logic that can be ported from C++ to C# if needed ).

 

[hwahrmann]

Fair enough.
I can detect the supported modes for exclusive. In fact i am doing that already.

And when some combination is not supported, i should create e.g. a 44khz mixer in exclusive mode and the non supported track will then be resampled.
I'm thinking, if i should ask the user to indicate his speaker setup within config instead of trying to detect it.
Then in such fallback situations i can rely on what the user has selected.

 

[azzuro]

http://msdn.microsoft.com/en-us/library/windows/desktop/dd316575(v=vs.85).aspx

this feature seems to be, for Vista minimum ... (broke XP ? )

 

[tourettes]

http://msdn.microsoft.com/en-us/library/windows/desktop/dd316575(v=vs.85).aspx

this feature seems to be, for Vista minimum ... (broke XP ? )

WASAPI is already Vista or later feature.