Music Player Rework (2 Viewers)

[tourettes]

I'm thinking, if i should ask the user to indicate his speaker setup within config instead of trying to detect it.
Then in such fallback situations i can rely on what the user has selected.

Yep, as drivers aren't providing the speaker mask always correctly (Nvidia returns 0 for example for HDMI audio devide).

 

[tourettes]

The sound quality has been improved in any case, some of the plugins that use the sound engine, for example: Rockstar (Spotify player) no longer work.

@hwahrmann, do we have any API changes that should be documented (and music plugin version increased as well)?

 

[jameson_uk]

@hwahrmann not sure if this is a problem with this build, the latest BASS binaries or something else but I am using the current GIT code in conjunction with the last.fm rework stuff (no player changes) and I getting

2013-03-08 15:24:06.580342 [ERROR][MPMain(1)]: OnMessage exception:System.MissingMethodException: Method not found: 'MediaPortal.Player.BassAudioEngine MediaPortal.Player.BassMusicPlayer.get_Player()'.
   at MediaPortal.GUI.Music.GUIMusicPlayingNow.OnPageLoad()
   at MediaPortal.GUI.Library.GUIWindow.OnMessage(GUIMessage message)

New method that needs to be implemented for new binaries ???

 

[hwahrmann]

The sound quality has been improved in any case, some of the plugins that use the sound engine, for example: Rockstar (Spotify player) no longer work.

@hwahrmann, do we have any API changes that should be documented (and music plugin version increased as well)?

Well, we don't have API changes. just changed the BASS / BASS.NET version. So if any of the plugins use that, they just need to recompile.
Other than that it should be fine.

 

[tourettes]

The sound quality has been improved in any case, some of the plugins that use the sound engine, for example: Rockstar (Spotify player) no longer work.

@hwahrmann, do we have any API changes that should be documented (and music plugin version increased as well)?

Well, we don't have API changes. just changed the BASS / BASS.NET version. So if any of the plugins use that, they just need to recompile.
Other than that it should be fine.

So we need to bump up the music plugin API version.

 

[hwahrmann]

@hwahrmann not sure if this is a problem with this build, the latest BASS binaries or something else but I am using the current GIT code in conjunction with the last.fm rework stuff (no player changes) and I getting

2013-03-08 15:24:06.580342 [ERROR][MPMain(1)]: OnMessage exception:System.MissingMethodException: Method not found: 'MediaPortal.Player.BassAudioEngine MediaPortal.Player.BassMusicPlayer.get_Player()'.
  at MediaPortal.GUI.Music.GUIMusicPlayingNow.OnPageLoad()
  at MediaPortal.GUI.Library.GUIWindow.OnMessage(GUIMessage message)

New method that needs to be implemented for new binaries ???

Don't think so.
This comes from the Playing now trying to get the instance of the Player to set the callback for the Internet Stream to change.
And this is still in the code.
Couldn't reproduce this one.

 

[l337]

hwahrmann

rockstar will work for you with this build here????
my english is not good

German better

 

[jameson_uk]

So we need to bump up the music plugin API version.

The music player rather than the plugin I think

 

[hwahrmann]

hwahrmann

rockstar will work for you with this build here????
my english is not good

German better

I have no idea. You need to ask the author of Rockstar.
I am not using Rockstar. Most probably it needs to be adapted. At least recompiled.

 

[hwahrmann]

Updated the first post with a link to new binaries based on 1.3.0 Final.

I think i got also rid of random crashes.