My Films 5 - Testing (2 Viewers)

[doveman]

I tested here with you rfiles and it works fine.
Steps I did:
- On Import tab, select the AMCU Config file - the one you posted, that was "somewhere" stored
- recreating config and desktopicon worked as expected
Note: You can only choose an existing AMCU Config file in MyFilms setup - if I manually set the XML to an invalid path, I get the same error.
So in case you want to "manually" do the setup, copy the file to the location where you want to place it (in your example E:\Data\MediaPortal), then select that one in setup and you're fine.

Sorry, I'm confused now. Before you said "(Re)creating the default settings should create the file - after that creation of icon should work." and I'm sure this worked previously. Are you now saying that for someone using Myfilms for the first time, they have to manually run AMCU (I don't think MyFilms even makes a shortcut to it in the Start Menu), create and save a config and then point to that config in MyFilms setup?

 

[TLD]

Hi Guzzi, I see that you have made it possible to have the movie titles remain the same color after watching them.
I was wondering if i need to mark all as unwatched before the install to use this option?

Hi TLD - not sure what you mean - the watched color is defined in the skin files? And there is no need to change the watched status itself to reflect this.

EDIT: Also I still can not find the link to the new version.

Latest dev version is here

I got an email notification about the title color change option i must have misread it. must have been from Dadeo. lol
Thanks for the link to the dev version.

 

[doveman]

Sure, you can "clean" the output - with grabber script editor, add the expressions you want to get rid of in "Replace" and replace it with space or "nothing".
You can also use regex to replace / remove several strings:
Replace:
"#REGEX#Rated |for.*"
With:
""

Thanks I'll have a play with that

Yeah, difficult to understand ... The warning is especially if users use a field other than source, e.g. "URL" for the media storage info - those fields would get owerwritten in those cases by internet grabbed data, if selected. As MyFilms allows there any field to be selected, that case can happen.
For "Storage", it is indeed irrelevant, as there is no data source overwriting that field - meither mediainfo nor internet grabbed data...

Ah I see, the warning makes sense when a field other than Source is used.

You're probably right - the grabber script definition was done long ago before even mapping was implemented - and due to the fact, producer wasn't available on the fast one page IMDB grabber, we defined the producer field to grab the writer.
Actually, I am not sure, if we should change that, as AMC3.x users then wouldn't get that info (or would have to make a manual mapping) - and AMC4.x users still can use the IMDB-Full script, that does return much more and detailed data for all the extended fields ...?

]If Writer is written to DB, the respective fields will automatically be generated,

So with the IMDB (or IMDB-Full) script, I need to edit the grabber options and set Writer to be written to the Writer field? I just assumed that with it set to blank (default) it would write to that field anyway, but if I understand you it doesn't do this to retain compatibility with AMC3 databases?

I just tried this by updating the one entry (Easy A) in my Test database (using Update Movie on the View Movies tab in AMCU) with IMDB-Full and I get

"Exception adding data ('Tagline') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('Studio') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('Edition') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('IMDBrank') to Movie Update Dialog: Object reference not set to an instance of an object"

I don't know about the last three (certainly I don't see Studio or Edition in the entry after updating it) but the Tagline gets put in the Description and Tagline fields even though the grabber options specify it should only be written to the Description field. Also, the title of the film is added to the Description field after the Tagline. The only fields mapped are Producer->Producer, Writer->Writer and Tagline->(start of) Description.

I haven't tried your new IMDB scripts you've just posted though, so let me give those a go

 

[doveman]

If anyone wants to modify the AMC IMDB script to put the Certification in the custom Certification field (to match AMCU), this is how to do it.

Look for the section

        if GetOption('Classification') = 1 then
SetField(fieldMediaType, Value)

and change the second line to

          SetCustomField('Certification', Value)

You obviously have to set the Classification option to 1 for it to use this.

Hey, thanks for pointing that - might be worth to post that in a separate thread, as I think many other users might be interested in that!

Thanks, that's a good idea. Things get easily get overlooked in a busy thread like this

 

[Guzzi]

I'm having a problem with the picture for one particular film "Easy A". The picture that AMCU scrapes causes an Access Violation error when selecting that film in AMC. The picture scraped is 4.86MB, which is much bigger than most which are a few hundred KB, but a few others are almost as large, "Machete" being the next at 3.7MB and these don't cause AMC to produce any errors.

Please post that issue in AMC forum to soulsnake, as it seems to be an issue af AMC software - nothing I can do about it. As workaround you could just choose a cover with smaller size.

Yeah, apparently "The bug comes from Delphi 7 JPEG library" and he'll fix it in the next update

Great news - thanks for reporting that to soulsnake!

 

[Guzzi]

Sure, you can "clean" the output - with grabber script editor, add the expressions you want to get rid of in "Replace" and replace it with space or "nothing".
You can also use regex to replace / remove several strings:
Replace:
"#REGEX#Rated |for.*"
With:
""

Thanks I'll have a play with that

Yeah, difficult to understand ... The warning is especially if users use a field other than source, e.g. "URL" for the media storage info - those fields would get owerwritten in those cases by internet grabbed data, if selected. As MyFilms allows there any field to be selected, that case can happen.
For "Storage", it is indeed irrelevant, as there is no data source overwriting that field - meither mediainfo nor internet grabbed data...

Ah I see, the warning makes sense when a field other than Source is used.

You're probably right - the grabber script definition was done long ago before even mapping was implemented - and due to the fact, producer wasn't available on the fast one page IMDB grabber, we defined the producer field to grab the writer.
Actually, I am not sure, if we should change that, as AMC3.x users then wouldn't get that info (or would have to make a manual mapping) - and AMC4.x users still can use the IMDB-Full script, that does return much more and detailed data for all the extended fields ...?

]If Writer is written to DB, the respective fields will automatically be generated,

So with the IMDB (or IMDB-Full) script, I need to edit the grabber options and set Writer to be written to the Writer field? I just assumed that with it set to blank (default) it would write to that field anyway, but if I understand you it doesn't do this to retain compatibility with AMC3 databases?

in IMDB script, currently, the grabber has no writer defined - only the producer, and this one grabs the "writer" info into that field. Yes, this could be somehow "fixed" by mapping etc. - but for what you want, it would be best to just define the "Writer" with same parameters as current "Producer" on details tab in Grabberinterface. IMDB-Full already is grabbing "correct" data into the respective fields.
However, we can think about doing that change for upcoming release, as I think many ppl will migrate to AMC4 anyway, so it is not any longer an issue...

I just tried this by updating the one entry (Easy A) in my Test database (using Update Movie on the View Movies tab in AMCU) with IMDB-Full and I get

"Exception adding data ('Tagline') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('Studio') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('Edition') to Movie Update Dialog: Object reference not set to an instance of an object"

"Exception adding data ('IMDBrank') to Movie Update Dialog: Object reference not set to an instance of an object"

Confirmed - that update option is still wip and I am in the process of adapting/extending it to support the AMC4 extended fields. I just tested and got some more/other errors - so please wait for next next version for testing. Updating in MyFilms GUI itself is almost finished and should work - if you use IMDB-Full there, you should be able to update all extended fields too. However, to get the multiselect dialog recently added, you need a skin update - so testing should be done now with defult (as it includes the required new skinfile).

I don't know about the last three (certainly I don't see Studio or Edition in the entry after updating it) but the Tagline gets put in the Description and Tagline fields even though the grabber options specify it should only be written to the Description field. Also, the title of the film is added to the Description field after the Tagline. The only fields mapped are Producer->Producer, Writer->Writer and Tagline->(start of) Description.

I haven't tried your new IMDB scripts you've just posted though, so let me give those a go

There is a little misunderstanding:
The "default" behaviour of the "mapper" is a 1:1 mapping - so if there is mothing defined ("empty", the data will go through - so Writer to Writer, Description to description, etc. - defined settings are modifications "on top" of that. So with the definitions you have, only "action" is adding adding the tagline to start of description. (If the title appears at the start of the description, I assume that is coming from IMDB site. You can easily check that in grabber interface, go to "search" tab, use your movie, search, select details, do a preview and look into the results in preview windows - it will show original and mapped. Further, you can klick on the web links to check, what the IMDB site grabbed shows originally.)

 

[Guzzi]

I tested here with you rfiles and it works fine.
Steps I did:
- On Import tab, select the AMCU Config file - the one you posted, that was "somewhere" stored
- recreating config and desktopicon worked as expected
Note: You can only choose an existing AMCU Config file in MyFilms setup - if I manually set the XML to an invalid path, I get the same error.
So in case you want to "manually" do the setup, copy the file to the location where you want to place it (in your example E:\Data\MediaPortal), then select that one in setup and you're fine.

Sorry, I'm confused now. Before you said "(Re)creating the default settings should create the file - after that creation of icon should work." and I'm sure this worked previously. Are you now saying that for someone using Myfilms for the first time, they have to manually run AMCU (I don't think MyFilms even makes a shortcut to it in the Start Menu), create and save a config and then point to that config in MyFilms setup?

Sorry, I might have been unclear:
MyFilms will create that file, if it is creating a new config the first time (based on the default config file, modified with the settings made).
After that, it will only update the (existing) file, if you "recreate" it. So nothing need to be done manually on new config/setup.
And user can't even select a setting to a "non existing file" there.
All this applies, when using the new config wizard (that is autolaunched on new install).
So how exactly did you create the config that is generating that error? Did you use "New" and made all settings manually? Or did you manually change xml config file? With what I tested here, I cannot even reproduce that situation, so need detailed steps how you were able to get there.

 

[doveman]

Sorry, I might have been unclear:
MyFilms will create that file, if it is creating a new config the first time (based on the default config file, modified with the settings made).
After that, it will only update the (existing) file, if you "recreate" it. So nothing need to be done manually on new config/setup.
And user can't even select a setting to a "non existing file" there.
All this applies, when using the new config wizard (that is autolaunched on new install).
So how exactly did you create the config that is generating that error? Did you use "New" and made all settings manually? Or did you manually change xml config file? With what I tested here, I cannot even reproduce that situation, so need detailed steps how you were able to get there.

Thanks for clarifying.

You're right that I can't select a "non existing file" for the AMCU config file, but it does currently point to a non-existing file! When I created the new MyFilms config (use I clicked New and adjusted the settings manually) and tried to save it, I recall that setting was blank and MyFilms wouldn't let me save, so I put something in there (it points to E:\Data\MediaPortal\Movies-Del-AMCU.xml) but perhaps that file did exist and I later deleted it, although I don't recall doing this. Perhaps the (re)Create button should create the AMCU config file if it's missing, as it might get accidentally deleted/corrupted and it would be good to have a simple way for the user to recreate it?

What I've done now is save a config file with that name from AMCU and now I don't get that error. However, I've noticed that my AMCU config file was pointing to E:\Data\MediaPortal\Test\Test.xml and even though the MyFilms config points to E:\Data\MediaPortal\My Films\Movies-Del.xml this path isn't pushed to the AMCU config file by (re)Create, Save, Create Desktop Icon or Import from Myfilms.

 

[doveman]

in IMDB script, currently, the grabber has no writer defined - only the producer, and this one grabs the "writer" info into that field. Yes, this could be somehow "fixed" by mapping etc. - but for what you want, it would be best to just define the "Writer" with same parameters as current "Producer" on details tab in Grabberinterface. IMDB-Full already is grabbing "correct" data into the respective fields.
However, we can think about doing that change for upcoming release, as I think many ppl will migrate to AMC4 anyway, so it is not any longer an issue...

OK, I just tested with (your new) IMDB-Full using AMCU's Update Movies tab and that's grabbed the Writer so it seems to be fine. Not sure why it wasn't working before when I scanned from the Import Movies tab but I just tried that and it works now as well. I probably tried from the View Movies tab before as well, but if that's wip it would explain why it might not have worked from there.

Confirmed - that update option is still wip and I am in the process of adapting/extending it to support the AMC4 extended fields. I just tested and got some more/other errors - so please wait for next next version for testing. Updating in MyFilms GUI itself is almost finished and should work - if you use IMDB-Full there, you should be able to update all extended fields too. However, to get the multiselect dialog recently added, you need a skin update - so testing should be done now with defult (as it includes the required new skinfile).

Thanks, I'll leave that alone for now then

There is a little misunderstanding:
The "default" behaviour of the "mapper" is a 1:1 mapping - so if there is mothing defined ("empty", the data will go through - so Writer to Writer, Description to description, etc. - defined settings are modifications "on top" of that. So with the definitions you have, only "action" is adding adding the tagline to start of description. (If the title appears at the start of the description, I assume that is coming from IMDB site. You can easily check that in grabber interface, go to "search" tab, use your movie, search, select details, do a preview and look into the results in preview windows - it will show original and mapped. Further, you can klick on the web links to check, what the IMDB site grabbed shows originally.)

That's what I thought but as it wasn't writing Writer I wasn't sure. As I say, it seems to be working OK now. I don't know why it was sticking the title after the Description but I was testing by Updating from the View Movies tab, so maybe it was just a bug in that.

Still having a couple of other issues. With the film "Easy A" http://akas.imdb.com/title/tt1282140/ with the IMDB-Full script Secondary Title option set to Country: USA, Max # of Titles to grab: 2, it puts "Msubuki kopaktsevis priadosani" in the Secondary and Formatted Title, which doesn't look very American to me Looking at the Details preview, this appears to be the title for Georgia.

There also seems to a bug with the logging window in AMCU, as it only shows anything for the first action I do after loading AMCU and never updates for subsequent actions.

 

[TLD]

I'm getting nothing in the log for AMCU see attached pic. i'm running AMC ver4. and started a new configuration with the wizard did a grab and the log was working then i updated AMCU to 5 fanarts and changed to a different graber (IMBD Full) posted above and now i get a blank log.

EDIT: By the way what does the "Start Import Watcher" button do?
I see that the AMC ver4 has a watched field which i selected for the "Watched" field in MF configuration, are the extended fields working now i see some data in some of them.