My Films 5 - Testing (3 Viewers)

Status
Not open for further replies.

TLD

Portal Pro
October 26, 2007
964
396
Rainy Washington
Home Country
United States of America United States of America
Well the AMCU log started working again after turning it off then back on.
 

Guzzi

Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    Sorry, I might have been unclear:
    MyFilms will create that file, if it is creating a new config the first time (based on the default config file, modified with the settings made).
    After that, it will only update the (existing) file, if you "recreate" it. So nothing need to be done manually on new config/setup.
    And user can't even select a setting to a "non existing file" there.
    All this applies, when using the new config wizard (that is autolaunched on new install).
    So how exactly did you create the config that is generating that error? Did you use "New" and made all settings manually? Or did you manually change xml config file? With what I tested here, I cannot even reproduce that situation, so need detailed steps how you were able to get there.

    Thanks for clarifying.

    You're right that I can't select a "non existing file" for the AMCU config file, but it does currently point to a non-existing file! When I created the new MyFilms config (use I clicked New and adjusted the settings manually)
    Ok, that was the important statement - and you see, why I asked about exact stepts how to reproduce!
    Using an empty "new" config leaves respronsibility for all configuration with the user itself - I would recommend using the setup wizard and let myfilms create a config (and modify it, if necessary) - as that makes sure, all settings are consistant and preset with usable values.
    and tried to save it, I recall that setting was blank and MyFilms wouldn't let me save, so I put something in there (it points to E:\Data\MediaPortal\Movies-Del-AMCU.xml) but perhaps that file did exist and I later deleted it,
    Next important one ... I am almost 100% sure, the file WAS there, when you saved - as otherwise you couldn't have done that - that's why this sanity check is done.
    although I don't recall doing this. Perhaps the (re)Create button should create the AMCU config file if it's missing, as it might get accidentally deleted/corrupted and it would be good to have a simple way for the user to recreate it?
    Well, I am sure we cannot foresee all situations, when users do such things - if config files are deleted, that will lead to problems in most plugins/apps.
    So - if a config is broken, I recommend creating a new one with the setup wizard - that takes only 1 minute and you're "back in the game".
    However, when reproducing your problem I noticed another problem with "new empty" configs - that I fixed for next version. I also added ability to create a default config, if there is none, as this will help for the wizard for centralized setups (not planned for next version though).

    What I've done now is save a config file with that name from AMCU and now I don't get that error. However, I've noticed that my AMCU config file was pointing to E:\Data\MediaPortal\Test\Test.xml and even though the MyFilms config points to E:\Data\MediaPortal\My Films\Movies-Del.xml this path isn't pushed to the AMCU config file by (re)Create, Save, Create Desktop Icon or Import from Myfilms.
    There is two things you do there:
    1. (re)create config: That will "update" your AMCU config file with values, you've set in MyFilms.
    2. Create desktop icon: That will create a desktop icon with command line parameter to load AMCU with that config file you have defined.
    Re the problem you have reported: I can confirm that is a bug - when the is a location other than "default" selected, it doesn't properly push the settings to the AMCU config. I have created a tracker entry and will fix that - thanks for reporting.
     

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    .. cannot reproduce here - applying the settings you mentioned in IMDB script, currently, the grabber has no writer defined - only the producer, and this one grabs the "writer" info into that field. Yes, this could be somehow "fixed" by mapping etc. - but for what you want, it would be best to just define the "Writer" with same parameters as current "Producer" on details tab in Grabberinterface. IMDB-Full already is grabbing "correct" data into the respective fields.
    However, we can think about doing that change for upcoming release, as I think many ppl will migrate to AMC4 anyway, so it is not any longer an issue...

    OK, I just tested with (your new) IMDB-Full using AMCU's Update Movies tab and that's grabbed the Writer so it seems to be fine. Not sure why it wasn't working before when I scanned from the Import Movies tab but I just tried that and it works now as well. I probably tried from the View Movies tab before as well, but if that's wip it would explain why it might not have worked from there.

    Confirmed - that update option is still wip and I am in the process of adapting/extending it to support the AMC4 extended fields. I just tested and got some more/other errors - so please wait for next next version for testing. Updating in MyFilms GUI itself is almost finished and should work - if you use IMDB-Full there, you should be able to update all extended fields too. However, to get the multiselect dialog recently added, you need a skin update - so testing should be done now with defult (as it includes the required new skinfile).

    Thanks, I'll leave that alone for now then :)

    There is a little misunderstanding:
    The "default" behaviour of the "mapper" is a 1:1 mapping - so if there is mothing defined ("empty", the data will go through - so Writer to Writer, Description to description, etc. - defined settings are modifications "on top" of that. So with the definitions you have, only "action" is adding adding the tagline to start of description. (If the title appears at the start of the description, I assume that is coming from IMDB site. You can easily check that in grabber interface, go to "search" tab, use your movie, search, select details, do a preview and look into the results in preview windows - it will show original and mapped. Further, you can klick on the web links to check, what the IMDB site grabbed shows originally.)

    That's what I thought but as it wasn't writing Writer I wasn't sure. As I say, it seems to be working OK now. I don't know why it was sticking the title after the Description but I was testing by Updating from the View Movies tab, so maybe it was just a bug in that.

    Still having a couple of other issues. With the film "Easy A" http://akas.imdb.com/title/tt1282140/ with the IMDB-Full script Secondary Title option set to Country: USA, Max # of Titles to grab: 2, it puts "Msubuki kopaktsevis priadosani" in the Secondary and Formatted Title, which doesn't look very American to me ;) Looking at the Details preview, this appears to be the title for Georgia.
    ... cannot reproduce here - applying the settings you mentioned I get as result:
    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A

    When limiting to "2" and not limiting to "USA":

    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A (USA ), Easy Girl (Belgium  / France  / Italy )

    There also seems to a bug with the logging window in AMCU, as it only shows anything for the first action I do after loading AMCU and never updates for subsequent actions.
    Yeah, known problem - couldn't fix that yet - see workaround from TLD ...
     

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    I'm getting nothing in the log for AMCU see attached pic. i'm running AMC ver4. and started a new configuration with the wizard did a grab and the log was working then i updated AMCU to 5 fanarts and changed to a different graber (IMBD Full) posted above and now i get a blank log.
    Known problem - see the workaround you posted. Will probably change that logging after next public version is out ...
    EDIT: By the way what does the "Start Import Watcher" button do?
    That is also part of work planned after next public release - I will remove or disable it for now ;-)
    I see that the AMC ver4 has a watched field which i selected for the "Watched" field in MF configuration, are the extended fields working now i see some data in some of them.
    AMC4 support is incorporated - however, some rules apply to allow interoperability. Currently working on the wiki pages. However, you can create a config with catalog type AMC4 (or upgrade an existing one) and do some testing. MyFilms will automatically extend AMC4 catalog with the fields supported. You could try with samplemovies, if you want...
     

    doveman

    Portal Pro
    February 12, 2008
    2,326
    178
    Home Country
    United Kingdom United Kingdom
    Ok, that was the important statement - and you see, why I asked about exact stepts how to reproduce!
    Using an empty "new" config leaves respronsibility for all configuration with the user itself - I would recommend using the setup wizard and let myfilms create a config (and modify it, if necessary) - as that makes sure, all settings are consistant and preset with usable values.

    Next important one ... I am almost 100% sure, the file WAS there, when you saved - as otherwise you couldn't have done that - that's why this sanity check is done.

    I'm inclined to agree with you, although it's a bit confusing as MyFilms seems to create the config file with the name "MyFilmsAMCSettings_Dels Movies.xml" and I don't think it gives the user any option to change this, so I'm not sure how it got to be E:\Data\MediaPortal\Movies-Del-AMCU.xml unless I copied and renamed the generated file, pointed to that in MyFilms config and then deleted the file (which I may well have done and completely forgotten, I've been juggling so many things recently that I hardly know what I'm doing anymore!) Anyway, it probably was me doing something dumb, so I doubt it will crop up again :)

    Well, I am sure we cannot foresee all situations, when users do such things - if config files are deleted, that will lead to problems in most plugins/apps.
    So - if a config is broken, I recommend creating a new one with the setup wizard - that takes only 1 minute and you're "back in the game".
    However, when reproducing your problem I noticed another problem with "new empty" configs - that I fixed for next version. I also added ability to create a default config, if there is none, as this will help for the wizard for centralized setups (not planned for next version though).

    Sure you can't cover every situation and it's good that the Setup Wizard creates an AMCU config, although the ability to create one other than through the Setup Wizard will be good as well, so that there's a way to create one for existing MyFilms setups which, for whatever reason, have 'lost' theirs. It certainly takes more than 1 minute to go through and check/adjust all the settings when creating a new config using the Setup Wizard and would be best if this could be avoided just for the sake of creating an AMCU config.

    There is two things you do there:
    1. (re)create config: That will "update" your AMCU config file with values, you've set in MyFilms.
    2. Create desktop icon: That will create a desktop icon with command line parameter to load AMCU with that config file you have defined.
    Re the problem you have reported: I can confirm that is a bug - when the is a location other than "default" selected, it doesn't properly push the settings to the AMCU config. I have created a tracker entry and will fix that - thanks for reporting.

    Thanks but can you clarify what you mean by "a location other than "default" selected"? The location for what, the AMCU config files (normally ProgramData\Team MediaPortal\MediaPortal)?

    By the way, the bug I reported some time ago is still present, where clicking (re)Create changes the Title Search Handling to "Folder name + Internet Lookup" (which is then what AMCU loads with it set to), so the only way to get it set to "File Name + Internet Lookup" is to change it in AMCU and save the config from there (which is then reflected in MyFilms after restarting or changing to another profile and back).
     

    doveman

    Portal Pro
    February 12, 2008
    2,326
    178
    Home Country
    United Kingdom United Kingdom
    ... cannot reproduce here - applying the settings you mentioned I get as result:
    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A

    When limiting to "2" and not limiting to "USA":

    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A (USA ), Easy Girl (Belgium  / France  / Italy )

    I get quite different results. With IMDB-Full and it limited to "2" and either limited to "USA" or not:

    Code:
    (0) Original Title
    Easy A
    (1) Translated Title

    so Translated Title is blank and doing Update Record (only update with non-empty data) doesn't put anything in Translated or Formatted.

    With the IMDB script however it returns "Easy Girl" (not Easy A) with the Country left blank and # of titles on 999 (or indeed set to "USA" and "2") and doing Update Record puts this in Translated and Formatted.

    I've attached the contents from the lower window on the Details pane as an html, in case there's some clues in that.

    Yeah, known problem - couldn't fix that yet - see workaround from TLD ...

    No worries, just wanted to make sure it wasn't just me and that you were aware of it :)
     

    Attachments

    • Easy A grab.zip
      20.6 KB

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    Ok, that was the important statement - and you see, why I asked about exact stepts how to reproduce!
    Using an empty "new" config leaves respronsibility for all configuration with the user itself - I would recommend using the setup wizard and let myfilms create a config (and modify it, if necessary) - as that makes sure, all settings are consistant and preset with usable values.

    Next important one ... I am almost 100% sure, the file WAS there, when you saved - as otherwise you couldn't have done that - that's why this sanity check is done.

    I'm inclined to agree with you, although it's a bit confusing as MyFilms seems to create the config file with the name "MyFilmsAMCSettings_Dels Movies.xml" and I don't think it gives the user any option to change this, so I'm not sure how it got to be E:\Data\MediaPortal\Movies-Del-AMCU.xml unless I copied and renamed the generated file, pointed to that in MyFilms config and then deleted the file (which I may well have done and completely forgotten, I've been juggling so many things recently that I hardly know what I'm doing anymore!) Anyway, it probably was me doing something dumb, so I doubt it will crop up again :)
    Ok, I understand - and I agree, it is "difficult" currently, if a user wants to "move" the location of that config file.
    This is imho all related to "central config setup" - and there is some thinking about adding ability to the wizard to do that in a future release.
    Currently, the wizard works good for local/single setups - and yes, central configs (or changes to standard setup) require manual intervention and steps.
    However, with the last fix I did, in case a manual config is done MyFilms would offer you to create a new default config in that place.

    Well, I am sure we cannot foresee all situations, when users do such things - if config files are deleted, that will lead to problems in most plugins/apps.
    So - if a config is broken, I recommend creating a new one with the setup wizard - that takes only 1 minute and you're "back in the game".
    However, when reproducing your problem I noticed another problem with "new empty" configs - that I fixed for next version. I also added ability to create a default config, if there is none, as this will help for the wizard for centralized setups (not planned for next version though).

    Sure you can't cover every situation and it's good that the Setup Wizard creates an AMCU config, although the ability to create one other than through the Setup Wizard will be good as well, so that there's a way to create one for existing MyFilms setups which, for whatever reason, have 'lost' theirs. It certainly takes more than 1 minute to go through and check/adjust all the settings when creating a new config using the Setup Wizard and would be best if this could be avoided just for the sake of creating an AMCU config.
    That is done (for AMCconfig) - if it is missing and you try to save, it will notice you and offer you to create a new default.
    You now also CAN select a file name or location, that does not exist and MyFilms offers you to create a new default config file there.

    There is two things you do there:
    1. (re)create config: That will "update" your AMCU config file with values, you've set in MyFilms.
    2. Create desktop icon: That will create a desktop icon with command line parameter to load AMCU with that config file you have defined.
    Re the problem you have reported: I can confirm that is a bug - when the is a location other than "default" selected, it doesn't properly push the settings to the AMCU config. I have created a tracker entry and will fix that - thanks for reporting.

    Thanks but can you clarify what you mean by "a location other than "default" selected"? The location for what, the AMCU config files (normally ProgramData\Team MediaPortal\MediaPortal)?
    Yes - "default" = mediaportal data directory - but that was a bug and I fixed it.

    By the way, the bug I reported some time ago is still present, where clicking (re)Create changes the Title Search Handling to "Folder name + Internet Lookup" (which is then what AMCU loads with it set to), so the only way to get it set to "File Name + Internet Lookup" is to change it in AMCU and save the config from there (which is then reflected in MyFilms after restarting or changing to another profile and back).
    Confirmed - and fixed for next test version.
     
    Last edited:

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    ... cannot reproduce here - applying the settings you mentioned I get as result:
    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A

    When limiting to "2" and not limiting to "USA":

    Code:
    (0) Original Title
    Easy A
    (1) Translated Title
    Easy A (USA ), Easy Girl (Belgium  / France  / Italy )

    I get quite different results. With IMDB-Full and it limited to "2" and either limited to "USA" or not:

    Code:
    (0) Original Title
    Easy A
    (1) Translated Title

    so Translated Title is blank and doing Update Record (only update with non-empty data) doesn't put anything in Translated or Formatted.

    With the IMDB script however it returns "Easy Girl" (not Easy A) with the Country left blank and # of titles on 999 (or indeed set to "USA" and "2") and doing Update Record puts this in Translated and Formatted.

    I've attached the contents from the lower window on the Details pane as an html, in case there's some clues in that.

    Yeah, known problem - couldn't fix that yet - see workaround from TLD ...

    No worries, just wanted to make sure it wasn't just me and that you were aware of it :)
    ... can we please move grabber related stuff to the respective forum thread? I think it is not really related to "code", but configuration and maybe script details - plus there is other ppl that might be able to help - especially with english countries, as sometimes IMDB provides differnet data depending on the country you are.
    Regarding the problem you posted: Best would be to post the scripts you currently use - (and if you want/can verify results in grabber interfafce first). That way others have a possibility to reproduce.
    For this respective problem:
    So behaviour of IMDB script is correct - can verify here - it displays the "also known as" title as Ttitle.
    IMDB-Full works here as "intended" - shows what I do in settings - USA title, number of titles, etc.
     
    Status
    Not open for further replies.

    Users who are viewing this thread

    Top Bottom