New DVB subtitle filter (TsReader based) (1 Viewer)

tourettes

Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Anyway I haven't broke the champagne out just yet, but it is on ice. Has anyone here (meaning Scandinavians) got the subtitles working with the Canal+ FILM channels?

    I noticed somebody had some teletext stuff working but it was very Alpha and it seemed to be in TVe2.

    Assuming Canal+ FILM uses DVB *teletext* subtitles, then you wont find support in this filter currently. However i have already implemented some DVB teletext code for an earlier version of this filter (by partly ripping off an open source teletext filter), and hope to merge with the TSReader based filter within the near future (maybe a month or so, but no promises).

    Hi Ziphnor! Nice to see that you here! If you aren't busy please feel free to help with fixing those couple fo remaining issues that we have in the DVBSub2.ax :D
     

    ziphnor

    Retired Team Member
  • Premium Supporter
  • August 4, 2005
    755
    13
    Copenhagen
    Home Country
    Denmark Denmark
    Hi Ziphnor! Nice to see that you here! If you aren't busy please feel free to help with fixing those couple fo remaining issues that we have in the DVBSub2.ax :D

    Actually, im still on holiday without access to development tools :) I will be back at the end of august, and will hopefully have time to catch w.r.t the filter.

    I just couldnt resist popping by the forums to check on the progress :)
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    First post updated, version 4 available for testing...

    - Fixed some compiler warnings
    - Fixed a memory leak when processing subtitle bitmaps
    - Fixed a resource leak inside the TsReader
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    652
    Kgs. Lyngby
    Home Country
    Denmark Denmark
    First post updated, version 4 available for testing...

    - Fixed some compiler warnings
    - Fixed a memory leak when processing subtitle bitmaps
    - Fixed a resource leak inside the TsReader

    :D
    Sounds good. Initial test still show leaks in playing the troubled .ts file (especially after seeking in it?), and also while watching tv. The bug with a hang when seeking over a channel change (mpeg1 audio <-> mpeg2 audio) seems to be resolved. I will continue testing tomorrow evening, and update post on first page accordingly.

    Regards
    Seidelin
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    First post updated, version 4 available for testing...

    - Fixed some compiler warnings
    - Fixed a memory leak when processing subtitle bitmaps
    - Fixed a resource leak inside the TsReader

    :D
    Sounds good. Initial test still show leaks in playing the troubled .ts file (especially after seeking in it?), and also while watching tv. The bug with a hang when seeking over a channel change (mpeg1 audio <-> mpeg2 audio) seems to be resolved. I will continue testing tomorrow evening, and update post on first page accordingly.

    How big leaks are you seeing (and is it memory or thread leak that we are talking here?).

    Was that mpeg1 <> mpeg2 audio hang happening every time or randomly? (I'm just interested as it could be fixed by the TsReader fix as it's most likely fixes some hangs when rebuilding / reconfiguring the graph).
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    652
    Kgs. Lyngby
    Home Country
    Denmark Denmark
    How big leaks are you seeing (and is it memory or thread leak that we are talking here?).

    Was that mpeg1 <> mpeg2 audio hang happening every time or randomly? (I'm just interested as it could be fixed by the TsReader fix as it's most likely fixes some hangs when rebuilding / reconfiguring the graph).

    I have not seen any thread leaks in my initial test. Just memory, and also the handle count seems to increase slightly with each .ts file being played (if that is important).

    The mpeg1 <> mpeg2 audio hang occurred every single time when seeking back across the channel change. Now, you cannot seek back across the channel change (which is exactly how vanilla tsreader behaves).

    Regards
    Seidelin
     

    SciDoctor

    Retired Team Member
  • Premium Supporter
  • February 2, 2005
    1,465
    139
    England
    Testing latest V4 version and there is a porblem with the subtitle updating only every five seconds and the subs between this time aren't rendered.

    This was very obvious in some fast dialog in FRASIER (playing back the recording, not live) where VLC showed all the subtitles but V4 with SVN 15533 only showed subs every 5 seconds or so.


    2007-08-15 14:35:35.845683 [Info.][MPMain]: TSReaderPlayer: current pos:278.922332763672 dur:2127.82299804688
    2007-08-15 14:35:39.726294 [Debug][15]: OnSubtitle
    2007-08-15 14:35:39.726294 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 348 stride : 2880
    2007-08-15 14:35:39.727270 [Debug][15]: SubtitleRenderer: to = 8 ts=284862 fsl=228 (startPos = 0)
    2007-08-15 14:35:39.730200 [Debug][15]: Received Subtitle : Subtitle 21 meta data: Timeout=8 timestamp=284.862
    2007-08-15 14:35:39.736059 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-15 14:35:43.497537 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 21 meta data: Timeout=8 timestamp=284.862
    2007-08-15 14:35:43.514137 [Debug][14]: Subtitle: Setting vertices
    2007-08-15 14:35:56.827738 [Debug][15]: OnSubtitle
    2007-08-15 14:35:56.827738 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 348 stride : 2880
    2007-08-15 14:35:56.827738 [Debug][15]: SubtitleRenderer: to = 8 ts=301761 fsl=228 (startPos = 0)
    2007-08-15 14:35:56.829691 [Debug][15]: Received Subtitle : Subtitle 22 meta data: Timeout=8 timestamp=301.761
    2007-08-15 14:35:56.834574 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-15 14:35:59.916408 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 22 meta data: Timeout=8 timestamp=301.761
    2007-08-15 14:36:09.537862 [Debug][15]: OnSubtitle
    2007-08-15 14:36:09.537862 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 304 stride : 2880
    2007-08-15 14:36:09.537862 [Debug][15]: SubtitleRenderer: to = 8 ts=314561 fsl=272 (startPos = 0)
    2007-08-15 14:36:09.542745 [Debug][15]: Received Subtitle : Subtitle 23 meta data: Timeout=8 timestamp=314.561
    2007-08-15 14:36:09.547627 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-15 14:36:12.949753 [Debug][15]: OnSubtitle
    2007-08-15 14:36:12.949753 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 254 stride : 2880
    2007-08-15 14:36:12.949753 [Debug][15]: SubtitleRenderer: to = 8 ts=318101 fsl=322 (startPos = 0)
    2007-08-15 14:36:12.952683 [Debug][15]: Received Subtitle : Subtitle 24 meta data: Timeout=8 timestamp=318.101
    2007-08-15 14:36:12.957565 [Debug][15]: SubtitleRenderer: Subtitle added, now have 2 subtitles in cache
    2007-08-15 14:36:13.074745 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 23 meta data: Timeout=8 timestamp=314.561
    2007-08-15 14:36:13.090369 [Debug][14]: Subtitle: Setting vertices
    2007-08-15 14:36:16.373362 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 24 meta data: Timeout=8 timestamp=318.101
    2007-08-15 14:36:16.386057 [Debug][14]: Subtitle: Setting vertices
    2007-08-15 14:36:27.937075 [Debug][15]: OnSubtitle
    2007-08-15 14:36:27.937075 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 304 stride : 2880
    2007-08-15 14:36:27.937075 [Debug][15]: SubtitleRenderer: to = 8 ts=333014 fsl=272 (startPos = 0)
    2007-08-15 14:36:27.939028 [Debug][15]: Received Subtitle : Subtitle 25 meta data: Timeout=8 timestamp=333.014
    2007-08-15 14:36:27.942934 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-15 14:36:31.173196 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 25 meta data: Timeout=8 timestamp=333.014
    2007-08-15 14:36:31.187844 [Debug][14]: Subtitle: Setting vertices
    2007-08-15 14:36:50.202252 [Debug][15]: OnSubtitle
    2007-08-15 14:36:50.202252 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 304 stride : 2880
    2007-08-15 14:36:50.203228 [Debug][15]: SubtitleRenderer: to = 8 ts=354729 fsl=272 (startPos = 0)
    2007-08-15 14:36:50.205181 [Debug][15]: Received Subtitle : Subtitle 26 meta data: Timeout=8 timestamp=354.729
    2007-08-15 14:36:50.211040 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-15 14:36:53.451067 [Debug][14]: SubtitleRenderer: SetSubtitle : Subtitle 26 meta data: Timeout=8 timestamp=354.729
    2007-08-15 14:37:01.169323 [Debug][15]: OnSubtitle
    2007-08-15 14:37:01.170300 [Debug][15]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 304 stride : 2880
    2007-08-15 14:37:01.170300 [Debug][15]: SubtitleRenderer: to = 8 ts=365806 fsl=272 (startPos = 0)
    2007-08-15 14:37:01.172253 [Debug][15]: Received Subtitle : Subtitle 27 meta data: Timeout=8 timestamp=365.806
    2007-08-15 14:37:01.178112 [Debug][15]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Testing latest V4 version and there is a porblem with the subtitle updating only every five seconds and the subs between this time aren't rendered.

    This was very obvious in some fast dialog in FRASIER (playing back the recording, not live) where VLC showed all the subtitles but V4 with SVN 15533 only showed subs every 5 seconds or so.

    Could you please upload few minutes sample of the Frasier episode on the FTP? (details can be found in the first post in the thread). Also it would be interesting to see if the DVBSub.log would show more subtitles than the MediaPortal log is showing.

    I myself haven't noticed any missing subtitles. Some sample .ts files that I have tested are showing subtitles approx once per second.
     

    Users who are viewing this thread


    Write your reply...
    Top Bottom