New DVB subtitle filter (TsReader based)

ziphnor

Retired Team Member
  • Premium Supporter
  • August 4, 2005
    755
    0
    Copenhagen
    ...well, something like this? :D
    Exactly :)

    ...that was the debug logging that I added. My assumption is that the current position skips backwards in the TsReader for some odd reason. So this could be related to the seeking issues I and other people are seen with TsReader.
    I was writing my response at the same time as you were writing yours, so i didnt see that you already added extra logging ;)

    It will be interesting to see what the result is, but lets hope i made a mistake in SubtitleRenderer, since it will likely be easier to correct than a seeking bug in TsReader :)
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    83
    Kgs. Lyngby
    Country flag
    There seems to be a memory leak. MP was using 300 MB mem + 1.1 GB VM after viewing TV for 3 hours.

    Logs attached (unfortunately without the added logging - which I will install now).

    Regards
    Seidelin
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    113
    There seems to be a memory leak. MP was using 300 MB mem + 1.1 GB VM after viewing TV for 3 hours.

    Logs attached (unfortunately without the added logging - which I will install now).
    Seems like the growing subtitle cache is contributing to that big memory usage.
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    113
    ...well, something like this? :D
    Exactly :)

    ...that was the debug logging that I added. My assumption is that the current position skips backwards in the TsReader for some odd reason. So this could be related to the seeking issues I and other people are seen with TsReader.
    I was writing my response at the same time as you were writing yours, so i didnt see that you already added extra logging ;)

    It will be interesting to see what the result is, but lets hope i made a mistake in SubtitleRenderer, since it will likely be easier to correct than a seeking bug in TsReader :)
    Well, would be better to have only one bug as the TsReader seeking bug is true even if we would have 2nd bug in the rendering code :)
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    113
    Here are the logs for another incident (frozen subtitles - and seeking issues). Now with SVN 15600 (extended logging information).
    2007-08-19 11:50:36.093750 [Debug][7]: OnSubtitle - current position 1833,1229167
    2007-08-19 11:50:36.093750 [Debug][7]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 124 stride : 2880
    2007-08-19 11:50:36.093750 [Debug][7]: SubtitleRenderer: to = 5 ts=1834588 fsl=452 (startPos = 0)
    2007-08-19 11:50:36.093750 [Debug][7]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-19 11:50:37.593750 [Debug][15]: SubtitleRenderer: SetSubtitle : Subtitle 268 meta data: Timeout=5 timestamp=1834,588
    2007-08-19 11:50:57.421875 [Debug][7]: OnSubtitle - current position 1546,9344584
    2007-08-19 11:50:57.421875 [Debug][7]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 124 stride : 2880
    2007-08-19 11:50:57.421875 [Debug][7]: SubtitleRenderer: to = 5 ts=1856058 fsl=452 (startPos = 0)
    2007-08-19 11:50:57.421875 [Debug][7]: SubtitleRenderer: Subtitle added, now have 1 subtitles in cache
    2007-08-19 11:51:01.781250 [Debug][7]: OnSubtitle - current position 1551,3214792

    Looks like TsReader (or MP) has some issue with the current position. As it has been jumped backwards just without seeking.

    I have been looking for the seeking code in TsReader, but I guess I will need Frodo's help with solving this one...
     

    henrik4223

    Portal Pro
    May 7, 2007
    55
    8
    Great work!! It saved MP at home (my wife was about to force me to change back to MCE!!! :)

    I am not sure if this is a bug or if it has been fixed. Using version 4 the screen sometimes goes into black when changing channels (rarely). The audio however is fine. Also, sometimes when changning channels the audio either is missing or a strange tapping noise comes. This goes away when seekeing.

    Best regards
    Henrik
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    83
    Kgs. Lyngby
    Country flag
    Great work!! It saved MP at home (my wife was about to force me to change back to MCE!!! :)

    I am not sure if this is a bug or if it has been fixed. Using version 4 the screen sometimes goes into black when changing channels (rarely). The audio however is fine. Also, sometimes when changning channels the audio either is missing or a strange tapping noise comes. This goes away when seekeing.

    Best regards
    Henrik
    If your audio disappears when changing channels, I bet that you are using a single-seat setup, and are changing between channels with mpeg1 and mpeg2 audio. It is a bug in TsReader (which the dev's are working on solving).

    Not sure about the black screen issue. There is a report about image freezing when zapping, but if you could provide logs for such an event it would be much appreciated.

    Thanks
    Seidelin
     

    majland

    Portal Member
    January 24, 2005
    19
    0
    I just wants to say thankyou for the good work. I've have just just installed a new windows xp pc to see how things has been progressing. And without much trouble i'm now watching danish television _with_ subtitles

    So it look ready for primetime even trough there is still a few bugs listed - at least it is ready for a WAT here (Wife Acceptance Test)

    Until now I've used a mythv box that has the functionality i need - but not the userinterface for the family ....
     

    Nyll

    Portal Pro
    May 18, 2006
    156
    18
    Looks like version 5 is doing a tremendous job. Haven't had any crashes/freeze yet and subtitle timing is perfect also when switching channels.

    Thanks tourettes!

    /Nyll
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom