[TV] North American Closed Captions (4 Viewers)

[Sebastiii]

Added the dependency and pushed the branch.

What are the batch build errors ?

It seems that if i change like the patch it's OK

That patch seems to reverse the change I pushed i.e. removing the '= 0' initialisation entries for the .h files - is that what you meant to do ?

Ah yes not 100% the revert but you can confirm if it's ok or not

 

[mm1352000]

For example, if a stream has CC + Teletext + DVB subtitle...

North American broadcasts don't use teletext or DVB subtitles. Only CC. I guess the risk might be if an NA broadcast is somehow rebroadcast somewhere else without removing the CCs.

 

[Sebastiii]

It seems that i always have error from building from batch (from VS it's ok).
Attached is the log

 

[Owlsroost]

It seems that i always have error from building from batch (from VS it's ok).
Attached is the log

Can you attach your 'CcParseH264.h' and 'CCParser.h' files please (or point me at the repo if it's a public branch) ?

 

[Sebastiii]

It seems that i always have error from building from batch (from VS it's ok).
Attached is the log

Can you attach your 'CcParseH264.h' and 'CCParser.h' files please (or point me at the repo if it's a public branch) ?

Thanks
My repo is there :
https://github.com/Sebastiii/MediaPortal-1/commits/1.10.0Fork-BDJ

I will try again on your EXP branch but it give me the same if i'm not wrong or i mix something lol

 

[Owlsroost]

It seems that i always have error from building from batch (from VS it's ok).
Attached is the log

Can you attach your 'CcParseH264.h' and 'CCParser.h' files please (or point me at the repo if it's a public branch) ?

Thanks
My repo is there :
https://github.com/Sebastiii/MediaPortal-1/commits/1.10.0Fork-BDJ

I will try again on your EXP branch but it give me the same if i'm not wrong or i mix something lol

Fixed versions attached (you had reverted my fix which removed the '= 0' initialisation).

 

[Sebastiii]

Going to try

 

[Sebastiii]

I'm going crasy but it seems that need a fix on tsreader side now too

 

[Sebastiii]

I will apply your diff to tsreader and see what happen

 

[Owlsroost]

You can probably just drop the CcParseH264.h and CcParseH264.cpp from the Core CC project into TsReader (and mod the StdAfx.h path).