[TV] North American Closed Captions (4 Viewers)

[Vasilich]

do we always need to have that corecc parser in graph ? or will it be included only when activating subtitles?

 

[Sebastiii]

It's already the case, corecc filter is only added to the graph when using the option -> 'Enable CC subtitles'

 

[Owlsroost]

@xvffx and @fir3ma5t3r - which version of MP are you using ?

(The new Core CC filter is ready for testing, but the MP Core.dll needs to be modified to allow H.264 CC to work. I have a modified Core.dll available for MP 1.10).

 

[Sebastiii]

@xvffx and @fir3ma5t3r - which version of MP are you using ?

(The new Core CC filter is ready for testing, but the MP Core.dll needs to be modified to allow H.264 CC to work. I have a modified Core.dll available for MP 1.10).

If you want i will able to test on my sample if needed
I just see your commit, so i will test

 

[xvffx]

Hi
I'm using 1.4 and I have no problem moving to 1.10 (it will be this weekend tho)
Or..... If it's not too much trouble that I could test both 1.4 and 1.10.

Thanks again
Vff[DOUBLEPOST=1423659576][/DOUBLEPOST]Hi
I just remembered using 1.4 that a small glitch happens.
When testing between h264 and mpeg2 I would have to turn on closed caption again from the OSD menu. I thought it was more in relation to graph not rebuilding. I just have this feeling that once h264 have been resolved with core cc, the glitch will be gone.
Another reason to test 1.4 ?

Vff

 

[Owlsroost]

Hi
I just remembered using 1.4 that a small glitch happens.
When testing between h264 and mpeg2 I would have to turn on closed caption again from the OSD menu. I thought it was more in relation to graph not rebuilding.
Vff

I've also noticed this testing with MP 1.10 (with modified Core.dll).

@Sebastiii - any idea why the 'Autoshow subtitles when TV starts' setting doesn't seem to work with Closed Captions ? (they usually - but not always - default to 'off' as far as I can tell).

 

[Sebastiii]

Hi
I just remembered using 1.4 that a small glitch happens.
When testing between h264 and mpeg2 I would have to turn on closed caption again from the OSD menu. I thought it was more in relation to graph not rebuilding.
Vff

I've also noticed this testing with MP 1.10 (with modified Core.dll).

@Sebastiii - any idea why the 'Autoshow subtitles when TV starts' setting doesn't seem to work with Closed Captions ? (they usually - but not always - default to 'off' as far as I can tell).

Tony, i get an error when building when it's Debug setting, release is OK but not from building from batch lol :

Error 2 error C2065: 'DEBUG_NEW' : undeclared identifier DirectShowFilters\Core-CC-Parser\parsing\CCParser.cpp 147 1 CCCP
Error 3 error C2146: syntax error : missing ';' before identifier 'CcParseH264' DirectShowFilters\Core-CC-Parser\parsing\CCParser.cpp 147 1 CCCP

About the 'Autoshow subtitles' it's surely a bug, i don't really remember how it was set @ the time.

 

[Sebastiii]

From batch, this is the error i get (from vs2013 it's ok in release mode) :

Spoiler: CCCP error building

"D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj" (Rebuild target) (9) ->
(ClCompile target) ->
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CCParser.h(131): error C2864: 'CCcParser::m_ccsetH264WrIdx' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\ax\../Parsing/CCParser.h(131): error C2864: 'CCcParser::m_ccsetH264WrIdx' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\ax\../Parsing/CCParser.h(131): error C2864: 'CCcParser::m_ccsetH264WrIdx' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\ax\../Parsing/CCParser.h(131): error C2864: 'CCcParser::m_ccsetH264WrIdx' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(66): error C2864: 'CcParseH264::ccblocks_in_avc_total' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(67): error C2864: 'CcParseH264::ccblocks_in_avc_lost' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(68): error C2864: 'CcParseH264::num_unexpected_sei_length' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(69): error C2864: 'CcParseH264::cc_count' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(70): error C2864: 'CcParseH264::cc_bytes_in_buffer' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(73): error C2864: 'CcParseH264::cc_data' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\parsing\CcParseH264.h(74): error C2864: 'CcParseH264::cc_databufsize' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]
D:\MediaPortal-1\directshowfilters\core-cc-parser\ax\../Parsing/CCParser.h(131): error C2864: 'CCcParser::m_ccsetH264WrIdx' : only static const integral data members can be initialized within a class [D:\MediaPortal-1\DirectShowFilters\Core-CC-Parser\ax\CCCP.vcxproj]

39 Warning(s)
48 Error(s)

 

[Sebastiii]

It works (from the sample lol) :
@Owlsroost Great work and i confirm that CC doesn't turn ON automatically (maybe because the option handle sub from DVBSubtitle but i'm not sure @ all)

 

[Sebastiii]

From another sample
Ok it's the recording and not live TV but it should work