- September 3, 2010
- 575
- 239
- Home Country
-
Canada
I was pretty sure that I found the "Holy Grail" to help you @morpheus_xx nailed that problem. Not earing anything from you after my new discovery says it all.
Plugin: RefreshRateChanger (1 Viewer)
- Thread starter morpheus_xx
- Start date
- March 24, 2007
- 12,070
- 7,459
- Home Country
-
Germany
- Thread starter
- Moderator
- #82
You know that I currently switch the rendering engine to D2D, this takes my full time. I this regard, could you please test the testbuild with refresh rate changer? Would be good to know if the problem is still present with DX11
- March 24, 2007
- 12,070
- 7,459
- Home Country
-
Germany
- September 3, 2010
- 575
- 239
- Home Country
-
Canada
Of course, it's my job !
Well... what can I say. I tested your files and I can't see anything wrong ! The 60hz RRC problem is officially DONE !
CONGRATS morpheux_xx !
Honnestly, I danced in front of my TV yesterday and my girlfriend was like... WTF !?!?
I said morpheus did it !! morpheus did it honey !! LOL.
thanks morpheus, i'll send proper log this evening with/without the patch to let you see.
A small step for MP2, but a great step for BETA !
- March 24, 2007
- 12,070
- 7,459
- Home Country
-
Germany
- Thread starter
- Moderator
- #86
Great 
- September 3, 2010
- 575
- 239
- Home Country
-
Canada
Here's my logs.
There's one last thing that has not been cured with the patch, it's when the video go throught the end, RRC try to switch back to 60hz (GUI) but stays at 24hz.
But If I stop myself the video before the end, RRC act like it should and switch to 60hz succesfully (GUI).
There's one last thing that has not been cured with the patch, it's when the video go throught the end, RRC try to switch back to 60hz (GUI) but stays at 24hz.
But If I stop myself the video before the end, RRC act like it should and switch to 60hz succesfully (GUI).
- in bad.rrc.7z, I stopped the video myself and GUI switch to 60hz
- in good.rrc.7z, I let the video play throught the end and the switch failed and the TV stays at 24hz, started a new video to see how it goes in the log...
- March 24, 2007
- 12,070
- 7,459
- Home Country
-
Germany
- Thread starter
- Moderator
- #88
Fine!
The remaining issue is maybe related to the Atmolight plugin (I think I mentioned it before). At least there are some exceptions logged (taken from the "bad.rrc.7z"):
But this log also tells about a "Stop" key press and a sucessful switch back to 60 Hz:
Btw, there is an open issue with PiP player I need to explain:
When changing refresh rates, the original one is remembered. But if player end in another order, they might restore a wrong refresh rate. Example:
Source situation idle: 60Hz
1) -> playback Primary Video: 23fps -> remembers "60", switches to 23
2) -> playback Secondary Video: 25fps -> remembers current "23", switching to "25"
You see, if now 1) ends before, screen switches back to "60" (remembered primary rate). If 2) stops thereafter, it restores its remembered "23", which is different than our starting point.
This can only be solve by remaining a shared history of refresh rate switches and each player pops out his source rates on stop until list is empty.
The remaining issue is maybe related to the Atmolight plugin (I think I mentioned it before). At least there are some exceptions logged (taken from the "bad.rrc.7z"):
But this log also tells about a "Stop" key press and a sucessful switch back to 60 Hz:
Btw, there is an open issue with PiP player I need to explain:
When changing refresh rates, the original one is remembered. But if player end in another order, they might restore a wrong refresh rate. Example:
Source situation idle: 60Hz
1) -> playback Primary Video: 23fps -> remembers "60", switches to 23
2) -> playback Secondary Video: 25fps -> remembers current "23", switching to "25"
You see, if now 1) ends before, screen switches back to "60" (remembered primary rate). If 2) stops thereafter, it restores its remembered "23", which is different than our starting point.
This can only be solve by remaining a shared history of refresh rate switches and each player pops out his source rates on stop until list is empty.
- September 12, 2009
- 798
- 577
- Home Country
-
Germany
Had another look at this. The AtmoLight errors result from the source surface being null between refreshrate changes.
This is the code im using:
At the point where the error happens the else clause is used and
returns null instead of a surface.
I would add a check and if it returns null just return the method if you dont have any better solution. But im not sure how this would influence the refreshrate changer or other parts of mp2. If this happens right now, the exception gets catched and the method returns alrady, just with an error message in the logs.
Btw. i could only see this error come up on video start not on video end or stop.
This is the code im using:
Code:
if (ServiceRegistration.Get<IPlayerContextManager>().IsVideoContextActive)
{
player = ServiceRegistration.Get<IPlayerContextManager>().PrimaryPlayerContext.CurrentPlayer as ISharpDXVideoPlayer;
surfaceSource = player.Surface;
}
else
{
surfaceSource = SkinContext.Device.GetRenderTarget(0);
}At the point where the error happens the else clause is used and
Code:
SkinContext.Device.GetRenderTarget(0)returns null instead of a surface.
I would add a check and if it returns null just return the method if you dont have any better solution. But im not sure how this would influence the refreshrate changer or other parts of mp2. If this happens right now, the exception gets catched and the method returns alrady, just with an error message in the logs.
Btw. i could only see this error come up on video start not on video end or stop.