[fixed] - Random slideshow in pictures can repeat some pictures and miss others [Mantis #4472] | Page 8

Discussion in '1.4.0 Pre-Release' started by Sebastiii, June 3, 2013.

  1. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    Looks good, I have not had a single hang trying it out. All the existing functionality seems to be working as well.



    Strangely enough I have found 2 new minor things (will this ever end?):
    1. When you have music running and do a slide show on a folder with folder.m3u it will stop music, start to play the 1st song of the playlist and then skip to the 2nd song (why-ever).
    2. If you have folder.m3u music running & you exit the slide show during playback of a video folder.m3u music is restarted and not stopped

    Conclusion: Merge it, I will add these two little ones to mantis (would you prefer separate or merge to an existing mantis?)

    P.S.: Does not only look good, works very good - I was not able to produce any more trouble - usually I am pretty good at breaking sw ;-)
     
    Last edited: June 7, 2013
    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Thanks :)
    Please mantis it like you want, i surely prefer separate one :p (ofc the goal is to not forget it).
     
  4. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    I didn't spot any issues. We have 3 days before the merge deadline. I'd rather not be leaving this to the last day, since there are other issues I need to push for.
     
  5. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs

    I will supply a bin but i will stop working on it after 21H00 (i set my limit lol).
    Good spot about music :

    Code (Text):
    1. 1. When you have music running and do a slide show on a folder with folder.m3u it will stop music, start to play the 1st song of the playlist and then skip to the 2nd song (why-ever).
    Maybe this one is fixed but i can't reproduce and like i see something strange for 2., i hope the fix will work for it.

    Code (Text):
    1. 2. If you have folder.m3u music running & you exit the slide show during playback of a video folder.m3u music is restarted and not stopped
    This one should be fixed :)
     
    • Like Like x 1
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    This is the bin :)
     

    Attached Files:

  7. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    This file fixed the 2nd issue - perfect.

    It also changes behaviour. If I have music playing, it does not change to the folder.m3u on slide show. I have no 1.2.3 system anymore to check how that initially worked. I would think that it is perfectly OK to keep the current music even if there is a fodler.m3u. So for me this is good.

    Btw. do you do anything on "nested" folder.m3u for recursive slideshows? Have not tested that at all.
     
  8. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Code (Text):
    1.     private void StartBackgroundMusic(string path)
    2.     {
    3.       if (g_Player.IsMusic || g_Player.IsRadio || g_Player.IsTV || g_Player.IsVideo)
    4.       {
    5.         return;
    6.       }
    Good :), from code, it shoudn't stop current music or i would say it shouldn't start to play m3u if music is already running.

    I did some test but not right now (can you ?).
    From i remember, if no music running, and start resursive slideshow if the slideshow start with an .m3u, music should start but if it start from a non .m3u, music will never start after that because MP read only pictures/videos item.

    Not sure you follow me lol.

    Code (Text):
    1. public void StartSlideShow(string path)
    2.     {
    3.       LoadSettings();
    4.       _isBackgroundMusicPlaying = false;
    5.       StartBackgroundMusic(path);
    6.       _slideDirection = 1;
    7.       _isSlideShow = true;
    8.       if (_autoShuffle && (_isSlideShow || _showRecursive))
    9.       {
    10.         Shuffle(false, false);
    11.         // Reset currentSlideIndex when slideshow start from context menu
    12.         _currentSlideIndex = 0;
    13.         _currentSlide = _slideCache.GetCurrentSlide(_slideList[_currentSlideIndex]);
    14.       }
    15.     }

    Normal Slideshow : -->> StartBackgroundMusic(path);
    Recursive one : -->> StartBackgroundMusic(path);

    When i do my testing it look to 'T:\-=- Pictures -=-' is the folder where i start rslideshow (that mean if i put m3u there it should start :)
     
    Last edited: June 7, 2013
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!