Ready for Testing - PowerScheduler++ integrated in MediaPortal 1.4 (4 Viewers)

[azzuro]

Re-tested with %temp% folder empty before update MP, i have the same issue

the Titanextended downloaded is the wrong version in your deploytool titanextended14.mpei is the good, your version is related to titanextended.mpei, the old one
sebastiii ?
https://github.com/MediaPortal/MediaPortal-1/commit/2039a68d9e228c4c3405696878308f91bee13e7e

 

[Sebastiii]

Euh what lol ?

It seems EXP-Replace_PS_by_PS++ is not up to date against master, the TitanExtensionInstall.cs is the old one.
I just try to merge master to it and all went fine and now TitanExtensionInstall.cs is OK
I didn't push it because @michael_t surely has some pending change on his local branch

Seb.

 

[azzuro]

Euh what lol ?

No, nothing, i have found the error after my 1st post, désolé mon gars

 

[michael_t]

Euh what lol ?

It seems EXP-Replace_PS_by_PS++ is not up to date against master, the TitanExtensionInstall.cs is the old one.
I just try to merge master to it and all went fine and now TitanExtensionInstall.cs is OK
I didn't push it because @michael_t surely has some pending change on his local branch

Seb.

Thank you for checking this - I will do the merge as soon as possible and release a new version.

Michael

 

[michael_t]

Thank you for checking this - I will do the merge as soon as possible and release a new version.

Michael

Uploaded new version 1.4.0.934 based on MP 1.4 final (now the real MP 1.4 final build without TitanExtended issues)

Michael

 

[azzuro]

@elliottmc / @michael_t : working fine for me, no more error

 

[elliottmc]

Bumping this thread. Any more testing? Any known issues?

If there are no known issues, what is the next stage? Code review? Documentation (needed?).

Thanks!

 

[Holzi]

Bumping this thread. Any more testing? Any known issues?

If there are no known issues, what is the next stage? Code review? Documentation (needed?).

Thanks!

I think this is ready to go.

Docs are already available: http://wiki.team-mediaportal.com/in.../3_Plugins/TV-Server_Plugins/PowerScheduler++ (and they are great!)

But maybe they should be moved? @Dadeo

 

[Dadeo]

Docs are already available: (and they are great!) But maybe they should be moved?

I agree they are great, but not ready to be moved because they still document it as an extension.
Imo we need a What's New page - could be simple - to say what is changed - e.g.

• how do you install it with MP 1.5.0? Is it installed as part of MP instead of the old powerscheduler or still via MPEI?
• how do you access it in config - the same as old powerscheduler or the way it is described in the docs you want to move? (i assume there is no change really since PS++ always replaced PS plugin anyways)

The What's new page can simply indicate the changes between it being an extension vs integrated and link to the current docs. That way once 1.5.0 is released the @Docs Team knows to move the pages to TV-Server Config > Plugins. At that time we should manually redirect the old PowerScheduler page to the new one so that anyone who accesses old links to either that page or to PS++ pages will be auto redirected to the new location of the PS++ pages.

 

[michael_t]

Bumping this thread. Any more testing? Any known issues?
If there are no known issues, what is the next stage? Code review? Documentation (needed?).
Thanks!

I agree they are great, but not ready to be moved because they still document it as an extension. Imo we need a What's New page - could be simple - to say what is changed - e.g. how do you install it with MP 1.5.0? Is it installed as part of MP instead of the old powerscheduler or still via MPEI? how do you access it in config - the same as old powerscheduler or the way it is described in the docs you want to move? (i assume there is no change really since PS++ always replaced PS plugin anyways) The What's new page can simply indicate the changes between it being an extension vs integrated and link to the current docs. That way once 1.5.0 is released the @Docs Team knows to move the pages to TV-Server Config > Plugins. At that time we should manually redirect the old PowerScheduler page to the new one so that anyone who accesses old links to either that page or to PS++ pages will be auto redirected to the new location of the PS++ pages.

I will have a look at the documentation, as Dadeo said. But what about a code review? The code is available at github, so if we need a review it could be done...

Michael