Rework of Music Database Thumb Handling (3 Viewers)

[catavolt]

Can I also implement that handling in NowPlaying screen, e. g. that the embedded cover appears as the cd case? The argument "#Play.Current.Thumb" doesn't work.

#Play.Current.Thumb works (and worked!) all the time here in all skins IF you have the same cover as folder.jpg in your Album folder
MP3Tag allows you to extract the embedded cover and saves it automatically as folder.jpg

 

[badboyxx]

I thought that now the embedded cover can be displayed in the nowplaying screen without extracting the image, but it doesn't work with the above mentioned argument.

I did some screenshots

 

[edterbak]

Found 1 performance issue.

Population times on first load.
Sebastiii fixed this a while back.
It was fast befor, but with this fix with coverart, it is slow again.

This is the thread with the fix
https://forum.team-mediaportal.com/...-ok-results-in-delayed-playback.125485/page-5

 

[edterbak]

@hwahrmann
You havent been online for a while, did you get this performance issue?

@Sebastiii Do you think it is possible do the same logic as before? (Dont know if its appropriate to ask you like this. is it?)

 

[Sebastiii]

No clue, but it's seems that we can run into preformance issue so maybe it's not fully the right way to do lol

 

[sleepycol]

Please note that some users, including myself would like to ALWAYS use the folder.jpg if it exists. I have spent many hours getting the correct folder.jpg in hundreds of music folders and it would be VERY BAD if this was wasted time if you ignore folder.jpg and use embedded images as a first option.

Solutions is to look for folder.jpg first OR provide option for user to ALWAYS use folder.jpg if exists and if it doesn't then use embedded images.....

Can you confirm this is already thought of, or can be implemented?

 

[hwahrmann]

Please note that some users, including myself would like to ALWAYS use the folder.jpg if it exists. I have spent many hours getting the correct folder.jpg in hundreds of music folders and it would be VERY BAD if this was wasted time if you ignore folder.jpg and use embedded images as a first option.
Solutions is to look for folder.jpg first OR provide option for user to ALWAYS use folder.jpg if exists and if it doesn't then use embedded images.....
Can you confirm this is already thought of, or can be implemented?

So we need a Configuration option.

 

[hwahrmann]

Found 1 performance issue.

Population times on first load.
Sebastiii fixed this a while back.
It was fast befor, but with this fix with coverart, it is slow again.

This is the thread with the fix
https://forum.team-mediaportal.com/...-ok-results-in-delayed-playback.125485/page-5

I don't have any performance problems here

 

[edterbak]

I will post log and movie about what I see.

 

[hwahrmann]

Ok, to reflect sleeycol's request above i have changed the logic slightly.

In the Music Database section within Configuration someone can choose to use "Embedded CoverArt in tags" for Thumbs creation.
This is an indication for us, that the user has nicely tagged files with covers included and this is most probably the cover that should be displayed by MP.

If this flag is set, we will get the Cover in the following way:

1. Get embedded Tag from the Song File
2. Search the Thumbs folder for a file in the form "Artist-Album"
3. return folder.jpg
4. Return empty string

If the above flag is not set, that indicates to us, that this user is most probably not using Database, but browsing via folder. So we will get the cover art in this way:

1. return folder.jpg
2. Search the Thumbs folder for a file in the form "Artist-Album"
3. Get embedded Tag from the Song File
4. Return empty string