[Approved] Start Music with parameter (1 Viewer)

[ltfearme]

yep, and just another note for out wiki guys is you need an additional namespace MediaPortal.GUI.Views for ViewDefinition class.

 

[ltfearme]

I did a quick test from an external plugin and was able to get the list of music/video views sucessfully

[COLLAPSE]

11/11/2010 11:12:49 AM [Info] 133, Artists
11/11/2010 11:12:49 AM [Info] 528, Album Artists
11/11/2010 11:12:49 AM [Info] 132, Albums
11/11/2010 11:12:49 AM [Info] 135, Genres
11/11/2010 11:12:49 AM [Info] 987, Years
11/11/2010 11:12:49 AM [Info] 1052, Songs
11/11/2010 11:12:49 AM [Info] 271, Top 100
11/11/2010 11:12:49 AM [Info] 932, Favourites
11/11/2010 11:12:49 AM [Info] 4558, Recently added
11/11/2010 11:12:49 AM [Info] TEST, TEST
11/11/2010 11:12:49 AM [Info] 135, Genres
11/11/2010 11:12:49 AM [Info] 344, Actors
11/11/2010 11:12:49 AM [Info] 369, Title
11/11/2010 11:12:49 AM [Info] 987, Years

[/COLLAPSE]

 

[trevor]

Hi,


Just been testing this and found that only works if hyperlink to 504 (mymusicgenres), is this intentional or should hyperlinking to 501 (mymusicsongs) also support this?


edit: just looked at the patch, should have done that first - so the question is more should this also be supported when hyperlinking to 501?

thx

 

[jameson_uk]

Just been testing this and found that only works if hyperlink to 504 (mymusicgenres), is this intentional or should hyperlinking to 501 (mymusicsongs) also support this?

Yep this was intentional, in fact I don't understand when 501 should be loaded directly....

when it loads you get

      if (MusicState.StartWindow != GetID)
      {
        GUIWindowManager.ReplaceWindow((int) Window.WINDOW_MUSIC_GENRE);
        return;
      }

so if you open up 501 you generally just get sent to 504 anyway...


hwahrmann will probably know but my understanding is that 501 is for shares view. If you try and open it up you will be sent to 504. if you select shares view from 504 (or were browsing shares view from 504) then you will be sent from 504 to 501 or will stay in 501 if you go there directly. So I think we should always be using 504 anyway? (I don't think a parameter would really help with shares view; yes you might have multiple shares but I am trying to move people away from shares view and onto the database views....)

 

[trevor]

Just been testing this and found that only works if hyperlink to 504 (mymusicgenres), is this intentional or should hyperlinking to 501 (mymusicsongs) also support this?

Yep this was intentional, in fact I don't understand when 501 should be loaded directly....

when it loads you get

      if (MusicState.StartWindow != GetID)
      {
        GUIWindowManager.ReplaceWindow((int) Window.WINDOW_MUSIC_GENRE);
        return;
      }

so if you open up 501 you generally just get sent to 504 anyway...


hwahrmann will probably know but my understanding is that 501 is for shares view. If you try and open it up you will be sent to 504. if you select shares view from 504 (or were browsing shares view from 504) then you will be sent from 504 to 501 or will stay in 501 if you go there directly. So I think we should always be using 504 anyway? (I don't think a parameter would really help with shares view; yes you might have multiple shares but I am trying to move people away from shares view and onto the database views....)

Makes sense as 504 is the DB view I believe, I know the StreamedMP skin calls 501 and this may be safer option as the user may not have populated the DB.

Will have to do some testing.

Thx

 

[jameson_uk]

Makes sense as 504 is the DB view I believe, I know the StreamedMP skin calls 501 and this may be safer option as the user may not have populated the DB.

There is some code in 504 to do the same so if you open up 504 and are wanting shares view you actually get sent to 501.

Normally this makes little difference until now when we want to open up with a parameter. I believe the only sensible parameter is a db view. I don't really want to hack this about so that the parameters received from 501 are then passed onto 504 as this could get quite messy and I am not sure the ReplaceWindow method copes with these parameters

 

[trevor]

Makes sense as 504 is the DB view I believe, I know the StreamedMP skin calls 501 and this may be safer option as the user may not have populated the DB.

There is some code in 504 to do the same so if you open up 504 and are wanting shares view you actually get sent to 501.

Normally this makes little difference until now when we want to open up with a parameter. I believe the only sensible parameter is a db view. I don't really want to hack this about so that the parameters received from 501 are then passed onto 504 as this could get quite messy and I am not sure the ReplaceWindow method copes with these parameters

True and not worth the risk for the minor gain, in my case I can easily handle the skinID part in the editor when configureing the hyperlink parameters.

The documentation will just need to make it clear that these parameters for music only work when hyperlinking to 504.

Thx

 

[Deda]

Just to inform, it works with MyVideos also. Code is practically the same.

Code for DB Video window and example parameter is:

....
<hyperlink>[B][COLOR=Red]25[/COLOR][/B]</hyperlink>
<hyperlinkParameter>987</hyperlinkParameter>   -> will open Years view
...

 

[Sebastiii]

thanks should be needed on latest SVN ?