SubtitleDownloader (3 Viewers)

seco

Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    Re: SubtitleDownloader 2.2

    Good library, much appreciated!
    The one thing i noticed was lacking is support for a hash based query, as far as i see it just means subclassing SubtitleSearchQuery and adding a file path property, then each capable ISubtitleDownloader could support this search.
    I thought about adding this support myself, but i couldn't find this project under source control.. are you the only active developer? im sure other people would like to pitch in.

    You are correct, but I don't think there is not that many sites that support hash feature. That's why it is not part of the ISubtitleDownloader interface. Of course you can make your own implementation like you described to support hash search.
     

    Magaf

    New Member
    September 16, 2010
    3
    0
    Re: SubtitleDownloader 2.2

    Good library, much appreciated!
    The one thing i noticed was lacking is support for a hash based query, as far as i see it just means subclassing SubtitleSearchQuery and adding a file path property, then each capable ISubtitleDownloader could support this search.
    I thought about adding this support myself, but i couldn't find this project under source control.. are you the only active developer? im sure other people would like to pitch in.

    You are correct, but I don't think there is not that many sites that support hash feature. That's why it is not part of the ISubtitleDownloader interface. Of course you can make your own implementation like you described to support hash search.

    OpenSubtitles, Sublight and Podnapisi support this, and perhaprs even more i dont know of.
    All of them are already inside your library, so the easiest way would be to edits its code..
    Are you willing to add it to code.google/sourceforge etc?
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    Re: SubtitleDownloader 2.2

    Good library, much appreciated!
    The one thing i noticed was lacking is support for a hash based query, as far as i see it just means subclassing SubtitleSearchQuery and adding a file path property, then each capable ISubtitleDownloader could support this search.
    I thought about adding this support myself, but i couldn't find this project under source control.. are you the only active developer? im sure other people would like to pitch in.

    You are correct, but I don't think there is not that many sites that support hash feature. That's why it is not part of the ISubtitleDownloader interface. Of course you can make your own implementation like you described to support hash search.

    OpenSubtitles, Sublight and Podnapisi support this, and perhaprs even more i dont know of.
    All of them are already inside your library, so the easiest way would be to edits its code..
    Are you willing to add it to code.google/sourceforge etc?

    Well 3/9 sources isn't that much :) I'm not sure how editing current code would help nor I don't want any edited versions floating around.

    Can't you just make new interface IMediaHashDownloader or something and then create implementation like MyDownloader extends OpenSubtitlesDownloader : IMediaHashDownloader ?
     

    Magaf

    New Member
    September 16, 2010
    3
    0
    Re: SubtitleDownloader 2.2

    You are correct, but I don't think there is not that many sites that support hash feature. That's why it is not part of the ISubtitleDownloader interface. Of course you can make your own implementation like you described to support hash search.

    OpenSubtitles, Sublight and Podnapisi support this, and perhaprs even more i dont know of.
    All of them are already inside your library, so the easiest way would be to edits its code..
    Are you willing to add it to code.google/sourceforge etc?

    Well 3/9 sources isn't that much :) I'm not sure how editing current code would help nor I don't want any edited versions floating around.

    Can't you just make new interface IMediaHashDownloader or something and then create implementation like MyDownloader extends OpenSubtitlesDownloader : IMediaHashDownloader ?

    Third of the sites is not that negligible, especially if they are among the largest.
    There are always workarounds like you mentioned, but thats not the proper way and discourages code reusability.

    You don't need to fear open source code, if you are new to this i would refer you to https://forum.team-mediaportal.com/mediaportal-plugins-47/plugin-development-svn-15863/
    Many plugins are there and many more use sites like code.google.
    edit: Your library is independent to mediaportal so it would be more appropriate to use a separate code control.
     

    BlackBurn

    MP Donator
  • Premium Supporter
  • October 4, 2008
    99
    28
    41
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 2.2

    When will Moving Pictures get this feature?

    :D

    I'm also hoping (waiting) for this feature, it would be awesome to add subtitles to movies.
    For movies ondertitel.com is a great source.

    I use bierdopje as resource for my series subtitles, but sometimes it is hard to choose which one I need, cause I can't see the real file name. It would be cool if there was a solution for this, maybe on a sort of hash comparison or just show the filename.

    Further keep up the good work, great plugin!

    :D
     

    Djang

    Portal Pro
    November 3, 2007
    79
    6
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 2.2

    I still give my vote for the abilty to setup the download folder for subtitles.
    Because I use WHS and gave the HTPC only read options.
     

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Home Country
    Croatia Croatia
    Re: SubtitleDownloader 2.2

    I use bierdopje as resource for my series subtitles, but sometimes it is hard to choose which one I need, cause I can't see the real file name. It would be cool if there was a solution for this, maybe on a sort of hash comparison or just show the filename.

    +1

    I still give my vote for the abilty to setup the download folder for subtitles.
    Because I use WHS and gave the HTPC only read options.

    When will Moving Pictures get this feature?

    :D

    I'm also hoping (waiting) for this feature, it would be awesome to add subtitles to movies.
    For movies ondertitel.com is a great source.

    I use bierdopje as resource for my series subtitles, but sometimes it is hard to choose which one I need, cause I can't see the real file name. It would be cool if there was a solution for this, maybe on a sort of hash comparison or just show the filename.

    Further keep up the good work, great plugin!

    :D

    Have you been living under a rock? :D ;)

    Check this: https://forum.team-mediaportal.com/...g-pictures-mediaportal-tvseries-others-85545/
     

    Djang

    Portal Pro
    November 3, 2007
    79
    6
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 2.2

    A rock!? More like a mountain!
    Damn I feel ashamed, how could I've missed this :eek:
     

    Asdolol

    New Member
    November 3, 2010
    3
    0
    Re: SubtitleDownloader 1.5

    Hello Seco, do you think is it possible to use RSS feeds to integrate the ::Italian Subs Addicted:: - La Community italiana dei Sottotitoli repository?
    They launched the MY ITASA service, a sort of personal subscription to the user favorite TV series, accessible via RSS.

    In fact there are two softwares that use RSS to directly download srt files from this site: jRss2sub and RSS2Sub LT (I know it's in italian language, but there's google translator ;) )

    Sry, but I MUST quote this old post :) ! This integration would be TOO FANTASTIC for us (all Italian series' viewer i think) :D !

    Pls answer! :)

    Sergio.
     

    Users who are viewing this thread

    Top Bottom