[Approved] Support for keepaspectratio in Coverflow (1 Viewer)

[pilehave]

I'll submit a patch soon, but I had to get the scrollbar posX working when the facadeview is not the precise resolution of the screen. This will include a fix for scrollbar scaling as well, as it has to be done in the facade to not destroy existing features.

 

[pilehave]

OK, here's the deal.

4 new XML values added to coverflow facade:

    [XMLSkinElement("keepaspectratio")] protected bool _keepAspectRatio = true;
    [XMLSkinElement("thumbZoom")] protected bool _zoom = false;
    [XMLSkinElement("cardAlign")] protected Alignment _imageAlignment = Alignment.ALIGN_CENTER;
    [XMLSkinElement("cardVAlign")] protected VAlignment _imageVAlignment = VAlignment.ALIGN_BOTTOM;

I fixed the scrollbar not being scaled and positioned to skin-size, but I still think there is an issue with Coverflow when the width of the control is NOT the same as the skin-resolution.

IE: If I make the coverflow posX=560 and width=800 I would expect that it was 800 pixel wide and centered in the screen on 1920x1080 (560x2 + 800 = 1920), but it is not.

As long as the skinner makes sure it is the same width as the skin, there is no problem

@DieBagger: Please review the patch, test it and see if the attached screenshots is what you would expect.

I'm open to suggestions, and it's OK for me if the patch makes it into a later version

I made the patch against SVN 27393.

Off for now, on tomorrow morning again

 

[pilehave]

Please note that the scrollbar only works with the seperate patch i made for the horizontal/vertical scrollbar:
https://forum.team-mediaportal.com/...5/fixed-vertical-horizontal-scrollbars-93059/

Without this patch it does not scale to resolution

 

[ajp8164]

OK, here's the deal.

4 new XML values added to coverflow facade:

    [XMLSkinElement("keepaspectratio")] protected bool _keepAspectRatio = true;
    [XMLSkinElement("thumbZoom")] protected bool _zoom = false;
    [XMLSkinElement("cardAlign")] protected Alignment _imageAlignment = Alignment.ALIGN_CENTER;
    [XMLSkinElement("cardVAlign")] protected VAlignment _imageVAlignment = VAlignment.ALIGN_BOTTOM;

I fixed the scrollbar not being scaled and positioned to skin-size, but I still think there is an issue with Coverflow when the width of the control is NOT the same as the skin-resolution.

IE: If I make the coverflow posX=560 and width=800 I would expect that it was 800 pixel wide and centered in the screen on 1920x1080 (560x2 + 800 = 1920), but it is not.

As long as the skinner makes sure it is the same width as the skin, there is no problem

@DieBagger: Please review the patch, test it and see if the attached screenshots is what you would expect.

I'm open to suggestions, and it's OK for me if the patch makes it into a later version

I made the patch against SVN 27393.

Off for now, on tomorrow morning again

Hi Pilehave,

I'm not sure about the scrollbar patch where you have provided for coverflow:

int scrollbarPosX = (_positionX / 2) + (_width / 2) - (scrollbarWidth / 2);

This geometry establishes an x position that I'm not sure makes sense. If the goal is to scale the final position with respect to the screen scaling then we use a special scaling method; GUIGraphicsContext.ScaleHorizontal(ref int x) for example.

On the problem of positioning the coverflow using x position; well, it's broken Here is the offending line; it only takes into account the coverflow control width.

GUIGraphicsContext.Translate(Width / 2, YPosition, 0);

Perhaps a more correct implementation would be:

GUIGraphicsContext.Translate(XPosition + Width / 2, YPosition, 0);

To take into account scaling probably need something like the following. Not sure what the effect would be because I don't think the other critical calculations are scaled (haven't tried any of this).

int x = XPosition;
int y = YPosition;
int w = Width;
GUIGraphicsContext.ScalePosToScreenResolution(ref x, ref y)
GUIGraphicsContext.ScaleHorizontal(ref w)
GUIGraphicsContext.Translate(x + w / 2, y, 0);

 

[pilehave]

Hi Pilehave,

I'm not sure about the scrollbar patch where you have provided for coverflow:

int scrollbarPosX = (_positionX / 2) + (_width / 2) - (scrollbarWidth / 2);

This geometry establishes an x position that I'm not sure makes sense. If the goal is to scale the final position with respect to the screen scaling then we use a special scaling method; GUIGraphicsContext.ScaleHorizontal(ref int x) for example.

I think it is neccesary to use all 3 numbers to position it correctly, both _positionX and _width are already scaled as they derive from the facadecontrol. scrollbarWidth is scaled just above the quted code with ScaleHorizontal().

But I found that this code should be used instead (previous one had an error) , which will position the scrollbar correctly when the facade is not centered; some skinners may want to position the facade more to the left or right:

int scrollbarPosX = (_positionX) + (_width / 2) - (scrollbarWidth / 2);

If we can make coverflow horizontal positionable (<-- is that even a word?) it would be really nice

 

[pilehave]

OK, I applied

GUIGraphicsContext.Translate(XPosition + Width / 2, YPosition, 0);

to coverflow and I think the scaling seems to be in order, and I positioned the scrollbar with the fixe from previous post. See attached screenshots (never mind that the title and itemcount is not positioned with the facade).


720x576 (window inner height)


1280x720 (window inner height)

Above examples has the coverflow posX=800 and width=720

 

[ajp8164]

pilehave - post a final patch with these changes (so I'm sure to get them all) and I'll commit them now as a bug fix (to get into 1.2).

 

[pilehave]

@pilehave - post a final patch with these changes (so I'm sure to get them all) and I'll commit them now as a bug fix (to get into 1.2).

This should be it

 

[ajp8164]

@pilehave - post a final patch with these changes (so I'm sure to get them all) and I'll commit them now as a bug fix (to get into 1.2).

This should be it

Committed to SVN 27444. Please verify and drop a note in the mantis issue 3390.

 

[catavolt]

AW: Support for keepaspectratio in Coverflow

Just testing SVN 27444. When changing e.g. posX to 100 and width to 1166 to have the coverflow centered with 100 px space on either side (skin resolution 1366 x 768), nothing happens. Neither the posX nor the width are respected.