[Approved] Support for keepaspectratio in Coverflow (2 Viewers)

[pilehave]

It works here with a clean checkout of SVN 27445?

		<posX>800</posX>
		<width>720</width>
		<posY>297</posY>

 

[catavolt]

AW: Support for keepaspectratio in Coverflow

As I said before:

<posX>100</posX>
<posY>280</posY>
<width>1166</width>

Coverflow covers whole screen from left to right... (with SVN 27445 from dev-ftp)

 

[pilehave]

Re: AW: Support for keepaspectratio in Coverflow

As I said before:

<posX>100</posX>
<posY>280</posY>
<width>1166</width>

Coverflow covers whole screen from left to right... (with SVN 27445 from dev-ftp)

Which skin is it? I'll try and download it and see if I have the same issue...

 

[pilehave]

Screenshot of Blue3Wide attached with these figures:

          <posX>680</posX>
          <posY>200</posY>
          <width>600</width>

Something in your build is not updated... try and delete mediaportal\Core\guilib\GUICoverFlow.cs and update from SVN again.

 

[elliottmc]

Peter,

If you could confirm that all is well, could you please close the mantis entry?

Thanks,

Mark

 

[catavolt]

AW: Re: Support for keepaspectratio in Coverflow

Something in your build is not updated... try and delete mediaportal\Core\guilib\GUICoverFlow.cs and update from SVN again.

As you can see from your own screenshot, the patch is no way working as expected.
The selected card is totally off center, the gap to the left of selected card is much bigger than on the right etc. and the angle of the other cards differ on left and right side.
Managed to "center" it with my skins, but experiencing the same errors.
And it´s even more: It takes about a second before the most left card disappears and the most right card appears to center the coverflow. This is a bad user experience IMHO.
Could you please overwork your patch so that all these bugs are eliminated?
My own sreenshots (before and after applying your values):

 

[pilehave]

Andy, we need to make the camera positionable but I can't figure out how...

 

[catavolt]

AW: Support for keepaspectratio in Coverflow

I really don´t want more properties in coverflow (there are more than enough already ), just make it possible that the given posX and a given width are respected as it´s done in all other facadeviews.

 

[pilehave]

posX and width IS respected, but the calculation of the card placement and angle is not offset correctly. What I meant with camera position was the I need to calculate the RotateY's posX correctly.

 

[elliottmc]

Hi guys,

We are getting close to release of 1.2.0beta.

Could I suggest that if this cannot be fixed quickly (and there is clearly something wrong) then this commit be reverted quickly while the problems are resolved?

Best wishes,

Mark