Trakt for MP2 (2 Viewers)

[morpheus_xx]

I would like to check the plugin code tomorrow, then we can decide how to continue. It would be good to have it in again

 

[morpheus_xx]

Finally managed to switch it to my API-Key. Here is a working version which uses the 0Auth authentication method:
https://github.com/aspik/MediaPortal-2/commits/FEAT_Trakt_v4

Can you please rebase the branch upon https://github.com/MediaPortal/MediaPortal-2/tree/SpringRelease16_RC and push it to our main repo?

 

[aspik]

Currently I'm on my way to work. I can do it later in the evening. Hope that's ok for you?

 

[aspik]

Done:
https://github.com/MediaPortal/MediaPortal-2/commits/FEAT_Trakt_v4
I hope I did it right and didn't broke something (still finding my way to get more familiar with git )

 

[morpheus_xx]

Thanks, I made some modifications to the setup dialog. The login was successful, also the sync to Trakt worked . Scrobbling I couldn't test yet. I'm currently building a new Spring'16 RC with this plugin enabled and I will post the link to the Spring'16 discussion thread.

 

[aspik]

I made some modifications to the setup dialog

I know, the setup dialog was not made very well...
Thank you for reviewing, short testing and including it in the new build!

 

[aspik]

I've a question to the MIA-devs (@henso or @Brownard or @MrTechno)
Is this still the right way to get the ImdbId?

I'm currently adding the two-way syncing to trakt and have problems with syncing from MP2 to trakt (it worked in the pre-MIA version). I can't sync a movie because I can't match it.

I tried a movie with nfo file and a movie with tt-id in filename. After importing these movies none of them had an ImdbId in the DB. Is there an example how can I get an ImdbId from a imported movie? Maybe I'm importing it wrongly...

Thanks

 

[Brownard]

Is this still the right way to get the ImdbId?

As a guess I'd say the ExternalIdentifier type is wrong, possibly should be TYPE_MOVIE for a movie

 

[aspik]

As a guess I'd say the ExternalIdentifier type is wrong, possibly should be TYPE_MOVIE for a movie

Sorry, I should have added that I also tried with the ExternalIdentiefer TYPE_MOVIE and it also returned null.

 

[Brownard]

Sorry, I should have added that I also tried with the ExternalIdentiefer TYPE_MOVIE and it also returned null.

Then I'll have to defer to @henso
EDIT: @aspik just had a thought that maybe the ExternalIdentifierAspect just isn't being requested with the MediaItem, which I don't think it is for media views (i.e. not included in the MediaItemQuery's necessary/optionalRequestedMIATypeIds). Maybe you'll need to reload the media item from the server with it included.