Trakt for MP2 (1 Viewer)

[HTPCSourcer]

How about scrobbling?

Scrobbling is correctly working.

I will mark this thread as finished.

 

[aspik]

I will mark this thread as finished.

It's far from being finished It can just sync and scrobble, where the MP1 version has much more features. I'm not not using it, but it would be nice if they where also available for MP2 users. But you can mark it as finished, the initial idea (port syncing and scrobbling) is done.

@ltfearme
I guess, I can't convince you to jumping ship? I want make the other API features available in MP2. For this, I will remove the trakt plugin from MP2 main solution and develop it further as an standalone .dll. I can do it in a dedicated repo, but then, the whole API would be still a copy paste from your version. Every API change has to be done twice... Can you imagine join forces?

Brownard's emulators plugin is very good example how a plugin for MP1 and MP2 can be developed together.

Your repo has already the right name: Trakt-for-Mediaportal and it's located where it belongs, in the main trakt.tv repo.

With your permission I would create in the trakt-for-mediaportal repo a new project for the MP2 version and develop it there further. The only thing, what would have to be done, is to move the trakt API into an own project to be able to develop it independently from MP1 and MP2. For this, the current MP1 version would have to be updated to the new v2 trakt API. Do you have plans to do it?

What do you think? Please say yes!

 

[aspik]

For this, the current MP1 version would have to be updated to the new v2 trakt API.

I'm sorry, that's of course false! The MP1 version is using the new v2 API! I meant the new 0Auth authentication procedure. The MP1 version is currently not yet using the new method, right? For a start this doesn't have to be a common thing.

So, the only thing what have to be done, is to move the traktAPI to an own project. This shouldn't be to difficult?

 

[ltfearme]

Yeah, MP1 is not using oAuth for authentication, something in the backlog. Its not too diffulcult to make the TraktAPI part of the project into a seperate project, I agree it benefits both teams going forward. I will endevour to get this done along with adding oAuth support soonish.

Im going through a bit of gaming phase at the moment, trying to get some downtime which I rarely get Bare with me as I have a few games to get through before coming back, just got Zelda for the Nintendo switch and can see myself getting lost in that for quite some time.

 

[aspik]

No problem, I can wait. The important thing is, that your not against bringing the development together

Have fun playing!

 

[ltfearme]

@aspik, I have commit Device Code oAuth now and created a separate library for the TraktAPI.

 

[aspik]

I have commit Device Code oAuth now and created a separate library for the TraktAPI.

Coool! Big thanks for moving the API to own lib!

Can I then add a another project in your repo for the MP2 version? This time I have to warn you, it will not happen right away now...

 

[ltfearme]

Yeah, that should be fine. Can you send me your email via pm for GitHub

 

[aspik]

Hi @ltfearme,

I pushed a new branch to your repo. In this branch I added a new project for the MP2 version and started to work on the new trakt implementation using your API. I also added a Tests project for unit tests. When I'm done, I'll make a pull request. I hope, that's ok for you?

 

[ltfearme]

All good here @aspik.