[fixed] TV recordings time progress not remembered (1 Viewer)

[elliottmc]

Will try to reproduce on monday.

That could be interpreted in so many ways.

 

[AtTimesPerplexed]

After many hours resetting the master branch to various commits to try and find where it breaks, I think I have found the culprit.

GITHUB:Fix BASS and VideoPlayerVMR9

Builds made before this commit work normally and builds after do not. I think the problem is MP not writing the data, rather than not reading it.

If I use a working build and watch a recording for a few minutes then stop, that data is saved. If I then install a non-working build, the resume dialog pops up with the correct resume time from the working build, but any new resume data is not saved instead it will ask to resume from the same time as the working build saved. Hope that made sense?

 

[elliottmc]

After many hours resetting the master branch to various commits to try and find where it breaks, I think I have found the culprit.

GITHUB:Fix BASS and VideoPlayerVMR9

Builds made before this commit work normally and builds after do not. I think the problem is MP not writing the data, rather than not reading it.

If I use a working build and watch a recording for a few minutes then stop, that data is saved. If I then install a non-working build, the resume dialog pops up with the correct resume time from the working build, but any new resume data is not saved instead it will ask to resume from the same time as the working build saved. Hope that made sense?

Where does it save the data ?

This commit affects 3 files. I think it is fair to exclude the BASS file, since this really shouldn't affect video playback at all.

You are using Windows 7, so you shouldn't be using VMR9. Are you?

Are you able to narrow this down to only one of the 3 affected files?

 

[mm1352000]

Note VMR9.cs is used as a base class.
If it is that commit then it is almost certainly in the g_Player file.

 

[elliottmc]

But why is this working perfectly for some of us but not others?

How many people see this fault? Am I possibly the only one that this is working for?

 

[Holzi]

@Sebastiii maybe you have an idea?

 

[Sebastiii]

@Sebastiii maybe you have an idea?

Not really but need to reproduce/debug it to see what happen

 

[Sebastiii]

Trying to debug that, here (singleseat + MSSQL) resume didn't work @ all.
It seems to save stoptime in videodb and not in TVdb.

I don't know what happen and not sure it was related to GITHUB:Fix BASS and VideoPlayerVMR9 this is strange for sure.

 

[Holzi]

Trying to debug that, here (singleseat + MSSQL) resume didn't work @ all.

I have only tested with MovPic so far and there resume works.

 

[Sebastiii]

I think i know what happen
i will supply bin tomorrow with a fix