UPnP / DLNA Media Server for MediaPortal 2 (2 Viewers)

[MrTechno]

it basically returns what the case is...

It almost does:

case "audio/mp3":
return "audio/mpeg";

case "image/jpeg":
case "image/pjpeg":
return "image/jpeg";

Auto merge between the DLNA branch and SR15 isn't going to work, I'll create a new branch and sort the merge conflicts out.

 

[FreakyJ]

Thank you very much!

I changed it locally to return the mimetype if it can't be found inside the switch case instead of "null". I think abording just because of the mime type is not a good idea. Is there a reason for that?
Probably the restrictions of DLNA. I guess we must somehow distinguis between a DLNA request and an UPnP/AV request which support every format.

 

[MrTechno]

No reason really. I've not really done any work on the plugin beyond getting it working again. The MIME type code should probably good types for DLNA supported content and pseudo types for unsupported content that can then be transcoded on the fly.

 

[FreakyJ]

okay that makes sense, somehow.
I will add a comment once you pushed the merged branch. There seem to be some other bugs. I will take a look and see if I can fix it further

 

[MrTechno]

DLNA branch merged with SR15, plugin XML changes applied, pushed and built - http://tinyurl.com/ok5zdan

The only thing I haven't done is test it

 

[FreakyJ]

Thank you very much for doing the merging

I've just fixed the post build events by replacing them with build.targets (like in all the other plugins). Now it is working and I pushed my changes to github.
I will try to do some more work on the plugin during this week. Lets see how far I get

 

[FreakyJ]

Attached is the latest build. It works already pretty good after I patched a function.
I would like to here some feedback to see where might be some issues
@Lehmden

 

[MrTechno]

works already pretty good after I patched a function

Is this patch in addition to https://github.com/MediaPortal/MediaPortal-2/commit/7a4f38ddc16bc2daac99e64c5e25f8ecbc925555 ?

 

[FreakyJ]

Is this patch in addition to https://github.com/MediaPortal/MediaPortal-2/commit/7a4f38ddc16bc2daac99e64c5e25f8ecbc925555 ?

Yes, it is what I mentioned yesterday:

Logger.Warn("No DLNA media type for MIME type {0}", mimeType);
            // I don't think it is a goof idea to return "null". The control point should check if the renderer supports the protocols offered by the server.
            // We could introduce some transcoding at a later point
            return mimeType;

I return the mimeType instead of null even it wasn't found in the switch case.
I try to find a good definition of the DLNA profile mappings, but the documentation has thousands of pages and for me it looks like a really bad one... I got it from the original DLNA Hompage.

 

[Lehmden]

Hi.
As Soon as I'm back home again I will test...