[solved] [WIFIREMOTE] Crash occurs when showing rate dialog after watching episode (3 Viewers)

[ltfearme]

If WIFI Remote is the reason, then perhaps I can add the enum back and mark it as obsolete so it works okay with it. But I need to be sure that is the problem, I will also check out the source code if it is.

Hi There,

yes, WifiRemote is the problem here. I access the Trakt plugin directly to allow WifiRemote clients to display the rating dialog, too.
This is broken now with the changed enum namespace @ltfearme I can publish an update for WifiRemote with a fix. Do you know the commit (or plugin version) where you changed the enum?

Sorry for the inconvenience, guys!


Edit: I guess it's this commit here: https://github.com/Technicolour/Tra...mmit/8a87243fb435e83913744caa8ad95a4f441cc8ee

Thanks @Shukuyen,

If you can push a new release that would be helpful, it will save me putting back the enum into the old namespace.

 

[ltfearme]

@ajs,

Can you please test the dll attached, I put back the ENUM that causes issues with WIFIREMOTE (cross fingers it works). If it works okay, then I can make a release with that change and save @Shukuyen the work. It will also be good for me not seeing that crash report

Things to test:
1. Auto-Rate Dialog after episode or movie has finished.
2. Rating is accurately sent to trakt.tv
3. Manual Trakt rate dialog works as expected e.g. trakt context menu from movingpics/myvideos details view -> rate.

Don't forget to ENABLE WIFIREMOTE for the tests!

 

[ltfearme]

@ajs, have you had time to test this yet and report result?

 

[ajs]

have you had time to test this yet and report result?

In the evening, try. Now at work.

 

[ajs]

have you had time to test this yet and report result?

Auto-Rate after Video (MyVideo)

[2015-01-16 23:27:48,159] [Log    ] [47       ] [DEBUG] - [WIFI_REMOTE]  Stop now-playing update thread
[2015-01-16 23:27:48,409] [Log    ] [MPMain   ] [DEBUG] - WindowManager: route MediaPortal.GUI.Video.GUIVideoFiles:6->TraktPlugin.GUI.GUIRateDialog:87300
[2015-01-16 23:27:48,410] [Log    ] [MPMain   ] [DEBUG] - [WIFI_REMOTE]  Sending dialog open to clients
[2015-01-16 23:27:48,416] [Error  ] [Rate     ] [ERROR] - MediaPortal: Unhandled exception occured
[2015-01-16 23:27:48,422] [Log    ] [Rate     ] [ERROR] - Exception: System.MissingMethodException: Method not found: 'TraktPlugin.TraktAPI.TraktRateValue TraktPlugin.GUI.GUIRateDialog.get_Rated()'.
   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at TraktPlugin.GUI.GUIUtils.ShowRateDialog[T](T rateObject)
   at TraktPlugin.TraktHandlers.MyVideos.<>c__DisplayClass4c.<ShowRateDialog>b__4b(Object o)
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart(Object obj)  Message: Method not found: 'TraktPlugin.TraktAPI.TraktRateValue TraktPlugin.GUI.GUIRateDialog.get_Rated()'.  Site   : System.Object MarshaledInvoke(System.Windows.Forms.Control, System.Delegate, System.Object[], Boolean)  Source : System.Windows.Forms  Stack Trace:     at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at TraktPlugin.GUI.GUIUtils.ShowRateDialog[T](T rateObject)
   at TraktPlugin.TraktHandlers.MyVideos.<>c__DisplayClass4c.<ShowRateDialog>b__4b(Object o)
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart(Object obj)

Auto-Rate after TVSeries:

[2015-01-16 20:54:48,133] [Log    ] [MPMain   ] [DEBUG] - TextureManagerEx: load from memory: [TVSeries:C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\TVSeriesDynLogo480xvidmp32.0widescreennosubtitles.png]
[2015-01-16 20:54:48,133] [Log    ] [FileExistsCache Thread] [DEBUG] - FileExistsCacheThread: new items found waiting for caching: 1
[2015-01-16 20:54:48,134] [Log    ] [FileExistsCache Thread] [DEBUG] - FileExistsCacheThread: no more items to cache, suspending thread.: 1
[2015-01-16 20:54:48,175] [Log    ] [MPMain   ] [DEBUG] - Window: WindowPlugins.GUITVSeries.TVSeriesPlugin init
[2015-01-16 20:54:48,202] [Log    ] [MPMain   ] [DEBUG] - WindowManager: route WindowPlugins.GUITVSeries.TVSeriesPlugin:9811->TraktPlugin.GUI.GUIRateDialog:87300
[2015-01-16 20:54:48,203] [Log    ] [MPMain   ] [DEBUG] - [WIFI_REMOTE]  Sending dialog open to clients
[2015-01-16 20:54:48,209] [Error  ] [Rate     ] [ERROR] - MediaPortal: Unhandled exception occured
[2015-01-16 20:54:48,212] [Log    ] [Rate     ] [ERROR] - Exception: System.MissingMethodException: Method not found: 'TraktPlugin.TraktAPI.TraktRateValue TraktPlugin.GUI.GUIRateDialog.get_Rated()'.
   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at TraktPlugin.GUI.GUIUtils.ShowRateDialog[T](T rateObject)
   at TraktPlugin.TraktHandlers.TVSeries.<>c__DisplayClassf8.<ShowRateDialog>b__f7(Object o)
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart(Object obj)  Message: Method not found: 'TraktPlugin.TraktAPI.TraktRateValue TraktPlugin.GUI.GUIRateDialog.get_Rated()'.  Site   : System.Object MarshaledInvoke(System.Windows.Forms.Control, System.Delegate, System.Object[], Boolean)  Source : System.Windows.Forms  Stack Trace:     at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at TraktPlugin.GUI.GUIUtils.ShowRateDialog[T](T rateObject)
   at TraktPlugin.TraktHandlers.TVSeries.<>c__DisplayClassf8.<ShowRateDialog>b__f7(Object o)
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart(Object obj)
[2015-01-16 20:54:48,212] [Log    ] [MPMain   ] [DEBUG] - TextureManager: load from memory: [TVSeries:C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\TVSeriesDynLogo480xvidmp32.0widescreennosubtitles.png]
[2015-01-16 20:54:48,217] [Log    ] [MPMain   ] [DEBUG] - TextureManager: load from memory: [TVSeries:C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\TVSeriesDynLogo480xvidmp32.0widescreennosubtitles.png]
[2015-01-16 20:54:48,424] [Log    ] [60       ] [DEBUG] - [WIFI_REMOTE]  Stop now-playing update thread
[2015-01-16 20:54:49,163] [Log    ] [FileSystemManager Thread] [DEBUG] - FileSystemWatchManagerThread : updating watchers
[2015-01-16 20:54:49,224] [Log    ] [FileSystemManager Thread] [DEBUG] - FileLookUpCacheThread items : 90857

No rating and watched send to Trakt But sync after restart MP.

PS:

[2015-01-16 20:57:44,047] [Log    ] [MPMain   ] [INFO ] - PluginManager: Plugin: 'C:\Team MediaPortal\MediaPortal\Plugins\process\WifiRemote.dll' / Version: 0.8.2.0

 

[ltfearme]

Sorry @ajs, I gave you the wrong dll. Mixed up between threads.

I have re-compiled to be sure this time.

 

[ajs]

Sorry @ajs, I gave you the wrong dll. Mixed up between threads.

Unfortunately, I'm going to sleep already. To work tomorrow, I'll try to check tomorrow night.

 

[ltfearme]

@ajs, I just installed WIFIREMOTE to test.

It looks like there is more issues, so looking into this now see if something can be done easily.

Next issues was a removed property 'ShowAdvancedRatings'. For @Shukuyen benefit I readded the property and marked it as obsolete.

 

[ltfearme]

Final build attached, with backwards compatibility for WIFIREMOTE.

 

[ltfearme]

Official release out v5.0.6 with fix for this.