Winamp Visualisations. Finally :-) (2 Viewers)

BassFan · August 13, 2013

Big Update!
Pluginload and destroy threads have been rewritten
a counter to check whether the thread is terminated and the plugin has been discharged is no longer needed.
i have changed BassVis_Free function to void(procedure).
you can check now if a Plugin unload as following

Code:

			if (_visParam.VisHandle != 0)
			{
			  BassVis.BASSVIS_Free(_visParam);
			  bool bFree = BassVis.BASSVIS_IsFree(_visParam);
			  if (bFree)
			  {
				_visParam.VisHandle = 0;
			  }
			  else
			  {
				Log.Warn("VisualisationManager: Failed to unload Sonique viz module - {0}", name);
				_visParam.VisHandle = 0;
			  }
			}

greets

Sebastiii · August 15, 2013

Branch updated

Thanks

When 1.5.0 Pre Release is out, it will be the time to open an Area51 thread for wider testing with an installer

and if all is good, it should go in next version (1.6.0).

Does you last fix answer to Tourettes suggestion ? if i understand correctly, when Viz is displayed, we should be able to display MP OSD.
I will test your branch ASAP

Holzi · August 15, 2013

I think it is a good idea to start testing based on MP 1.5.0 Pre-Release (and later based on MP Final when it gets released). Are you able to update the branch to be in line with master?
Thanks!

Guzzi · August 15, 2013

Sebastiii said:
Branch updated
Thanks

When 1.5.0 Pre Release is out, it will be the time to open an Area51 thread for wider testing with an installer and if all is good, it should go in next version (1.6.0).

Does you last fix answer to Tourettes suggestion ? if i understand correctly, when Viz is displayed, we should be able to display MP OSD.
I will test your branch ASAP

Hi Sebastiii, if you do testing, can you please also test the FPS limiter, that is only applied to VIZ process (20 < FPS < 40) - I think that doesn't make sense - and if we manage to sync the VIZ to render loop or display refresh, it definately must go as high as 60 ....
THanks, Guzzi

Sebastiii · August 17, 2013

Hi,

I have see this :
It happen (i think) if i close MP while Fullscreen Viz is running.

@BassFan , in your commit message (for future patch) can you add the Jira issue key like :

Plugin Load and Destroy Thread rewritten -> should be -> MP1-4091 : Plugin Load and Destroy Thread rewritten

It will help to create review for the branch (Thanks

Code:

[2013-08-17 16:10:52,431] [Log	] [MPMain  ] [ERROR] - Exception: System.InvalidOperationException: Value Dispose() cannot be called while doing CreateHandle().
  at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at MediaPortal.Visualization.VisualizationWindow.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at System.Windows.Forms.Form.Dispose(Boolean disposing)
  at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
  at MediaPortal.D3D.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Form.WmClose(Message& m)
  at System.Windows.Forms.Form.WndProc(Message& m)
  at MediaPortalApp.WndProc(Message& msg)  Message: Value Dispose() cannot be called while doing CreateHandle().  Site  : Void Dispose(Boolean)  Source : System.Windows.Forms  Stack Trace:	at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at MediaPortal.Visualization.VisualizationWindow.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at System.Windows.Forms.Form.Dispose(Boolean disposing)
  at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
  at MediaPortal.D3D.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Form.WmClose(Message& m)
  at System.Windows.Forms.Form.WndProc(Message& m)
  at MediaPortalApp.WndProc(Message& msg)

I get also :

Code:

[2013-08-17 16:21:33,923] [Error  ] [BASS Stop] [ERROR] - BASS: Stop command caused an exception - Invoke or BeginInvoke cannot be called on a control until the window handle has been created..	at System.Windows.Forms.Control.WaitForWaitHandle(WaitHandle waitHandle)
  at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
  at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.ShowVisualizationWindow(Boolean visible) in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1377
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.HandleSongEnded() in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1961
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.<Stop>b__1() in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1923

Line log will surely not ok (because i'm running testing not directly on the branch)

BassFan · August 17, 2013

I have see this :
It happen (i think) if i close MP while Fullscreen Viz is running.

i will check for this error.
------------------------------------
please tell me what your do when produce this error
i can not reproduce it.

which plugin
which keyevent.. also key your use
and so on.

@Sebastiii should be -> MP1-4091 : Plugin Load and Destroy Thread rewritten

yes.. when create a new patch.

greets

BassFan · August 17, 2013

@Sebastiii It happen (i think) if i close MP while Fullscreen Viz is running.

after click X Button in Windowmode if Milk2 running no error appears by me. (StreamedMP)
after click X Button in Windowmode if Milk2 running no error appears by me. (Titan Skin)

with latest fixed
directly on my local branch.

@Guzzi that is only applied to VIZ process (20 < FPS < 40) - I think that doesn't make sense

That do nothing (has no effect) with Visualization of BassVis(Winamp, Sonique, BassBox)
that is only for WMP internal Visual-Plugin's in MePo..

greets

Sebastiii · August 17, 2013

Thanks BassFan,

Can you try ? :

- Start MP in windowed mode
- Start Music (with MilkDrop)
- Go to Home menu ('H' key)
- Click 'X' Key (it should display Milkdrop on fullscreen)
- Close MP (Alt-F4 or with X)

It happen randomly and also when i try to reproduce the issue, when clicking 'X' key, the MilkDrop was a very little windows.

BassFan · August 17, 2013

Can you try ? :

1. Use ALT + ENTER switch to Windowed mode
2. Start music with MilkDrop
3. using H key to Home menu
4. click x key Milkdrop is fullscreen
5 use ALT + F4

no error appears
same when start directly in Windowed mode.

greets

deadmonty · August 21, 2013

Will all these fixes be included in 1.5? I had a look at the change log and there was no mention of them.

Winamp Visualisations. Finally :-) (2 Viewers)

BassFan

Guest

Sebastiii

Development Group

Holzi

Super Moderator

Guzzi

Retired Team Member

Sebastiii

Development Group

BassFan

Guest

BassFan

Guest

Sebastiii

Development Group

BassFan

Guest

deadmonty

MP Donator

Users who are viewing this thread