Winamp Visualisations. Finally :-) | Page 66

Discussion in 'Listen Music' started by hwahrmann, March 31, 2007.

  1. BassFan

    BassFan Guest

    Ratings:
    +0 / 0
    Big Update!
    Pluginload and destroy threads have been rewritten
    a counter to check whether the thread is terminated and the plugin has been discharged is no longer needed.
    i have changed BassVis_Free function to void(procedure).
    you can check now if a Plugin unload as following

    Code (Text):
    1.             if (_visParam.VisHandle != 0)
    2.             {
    3.               BassVis.BASSVIS_Free(_visParam);
    4.               bool bFree = BassVis.BASSVIS_IsFree(_visParam);
    5.               if (bFree)
    6.               {
    7.                 _visParam.VisHandle = 0;
    8.               }
    9.               else
    10.               {
    11.                 Log.Warn("VisualisationManager: Failed to unload Sonique viz module - {0}", name);
    12.                 _visParam.VisHandle = 0;
    13.               }
    14.             }
    greets


     
    Last edited by a moderator: August 20, 2013
    • Like Like x 6
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,256
    Likes Received:
    6,211
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,214 / 9
    Home Country:
    France France
    Show System Specs
    Branch updated :)
    Thanks :p

    When 1.5.0 Pre Release is out, it will be the time to open an Area51 thread for wider testing with an installer :) and if all is good, it should go in next version (1.6.0).

    Does you last fix answer to Tourettes suggestion ? if i understand correctly, when Viz is displayed, we should be able to display MP OSD.
    I will test your branch ASAP :)
     
    • Like Like x 2
  4. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    I think it is a good idea to start testing based on MP 1.5.0 Pre-Release (and later based on MP Final when it gets released). Are you able to update the branch to be in line with master?
    Thanks! :)
     
  5. Guzzi
    • Premium Supporter

    Guzzi Retired Team Member

    Joined:
    August 20, 2007
    Messages:
    2,161
    Likes Received:
    704
    Ratings:
    +922 / 0
    Hi Sebastiii, if you do testing, can you please also test the FPS limiter, that is only applied to VIZ process (20 < FPS < 40) - I think that doesn't make sense - and if we manage to sync the VIZ to render loop or display refresh, it definately must go as high as 60 ....
    THanks, Guzzi
     
    • Like Like x 1
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,256
    Likes Received:
    6,211
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,214 / 9
    Home Country:
    France France
    Show System Specs
    Hi,

    I have see this :
    It happen (i think) if i close MP while Fullscreen Viz is running.

    @BassFan , in your commit message (for future patch) can you add the Jira issue key like :

    Plugin Load and Destroy Thread rewritten -> should be -> MP1-4091 : Plugin Load and Destroy Thread rewritten

    It will help to create review for the branch (Thanks :)

    Code (Text):
    1. [2013-08-17 16:10:52,431] [Log  ] [MPMain  ] [ERROR] - Exception: System.InvalidOperationException: Value Dispose() cannot be called while doing CreateHandle().
    2.   at System.Windows.Forms.Control.Dispose(Boolean disposing)
    3.   at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
    4.   at MediaPortal.Visualization.VisualizationWindow.Dispose(Boolean disposing)
    5.   at System.ComponentModel.Component.Dispose()
    6.   at System.Windows.Forms.Control.Dispose(Boolean disposing)
    7.   at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
    8.   at System.Windows.Forms.Form.Dispose(Boolean disposing)
    9.   at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
    10.   at MediaPortal.D3D.Dispose(Boolean disposing)
    11.   at System.ComponentModel.Component.Dispose()
    12.   at System.Windows.Forms.Form.WmClose(Message& m)
    13.   at System.Windows.Forms.Form.WndProc(Message& m)
    14.   at MediaPortalApp.WndProc(Message& msg)  Message: Value Dispose() cannot be called while doing CreateHandle().  Site  : Void Dispose(Boolean)  Source : System.Windows.Forms  Stack Trace:    at System.Windows.Forms.Control.Dispose(Boolean disposing)
    15.   at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
    16.   at MediaPortal.Visualization.VisualizationWindow.Dispose(Boolean disposing)
    17.   at System.ComponentModel.Component.Dispose()
    18.   at System.Windows.Forms.Control.Dispose(Boolean disposing)
    19.   at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
    20.   at System.Windows.Forms.Form.Dispose(Boolean disposing)
    21.   at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
    22.   at MediaPortal.D3D.Dispose(Boolean disposing)
    23.   at System.ComponentModel.Component.Dispose()
    24.   at System.Windows.Forms.Form.WmClose(Message& m)
    25.   at System.Windows.Forms.Form.WndProc(Message& m)
    26.   at MediaPortalApp.WndProc(Message& msg)
    I get also :
    Code (Text):
    1. [2013-08-17 16:21:33,923] [Error  ] [BASS Stop] [ERROR] - BASS: Stop command caused an exception - Invoke or BeginInvoke cannot be called on a control until the window handle has been created..   at System.Windows.Forms.Control.WaitForWaitHandle(WaitHandle waitHandle)
    2.   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
    3.   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
    4.   at MediaPortal.MusicPlayer.BASS.BassAudioEngine.ShowVisualizationWindow(Boolean visible) in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1377
    5.   at MediaPortal.MusicPlayer.BASS.BassAudioEngine.HandleSongEnded() in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1961
    6.   at MediaPortal.MusicPlayer.BASS.BassAudioEngine.<Stop>b__1() in D:\svnroot\MediaPortal-1_Fork_1\mediaportal\Core\MusicPlayer\BASS\BassAudioEngine.cs:line 1923
    Line log will surely not ok (because i'm running testing not directly on the branch)
     
    • Like Like x 1
  7. BassFan

    BassFan Guest

    Ratings:
    +0 / 0
    i will check for this error.
    ------------------------------------
    please tell me what your do when produce this error
    i can not reproduce it.

    which plugin
    which keyevent.. also key your use
    and so on.

    yes.. when create a new patch.

    greets
     
    Last edited by a moderator: August 17, 2013
    • Like Like x 1
    • Thank You! Thank You! x 1
  8. BassFan

    BassFan Guest

    Ratings:
    +0 / 0
    after click X Button in Windowmode if Milk2 running no error appears by me. (StreamedMP)
    after click X Button in Windowmode if Milk2 running no error appears by me. (Titan Skin)

    with latest fixed
    directly on my local branch.

    That do nothing (has no effect) with Visualization of BassVis(Winamp, Sonique, BassBox)
    that is only for WMP internal Visual-Plugin's in MePo..

    greets
     
    Last edited by a moderator: August 20, 2013
    • Thank You! Thank You! x 1
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,256
    Likes Received:
    6,211
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,214 / 9
    Home Country:
    France France
    Show System Specs
    Thanks BassFan,

    Can you try ? :

    - Start MP in windowed mode
    - Start Music (with MilkDrop)
    - Go to Home menu ('H' key)
    - Click 'X' Key (it should display Milkdrop on fullscreen)
    - Close MP (Alt-F4 or with X)

    It happen randomly and also when i try to reproduce the issue, when clicking 'X' key, the MilkDrop was a very little windows.
     
  10. BassFan

    BassFan Guest

    Ratings:
    +0 / 0
    1. Use ALT + ENTER switch to Windowed mode
    2. Start music with MilkDrop
    3. using H key to Home menu
    4. click x key Milkdrop is fullscreen
    5 use ALT + F4

    no error appears
    same when start directly in Windowed mode.

    greets
     
    Last edited by a moderator: August 19, 2013
  11. deadmonty
    • Premium Supporter

    deadmonty MP Donator

    Joined:
    February 7, 2009
    Messages:
    59
    Likes Received:
    8
    Gender:
    Male
    Occupation:
    IT and Business Process Manager
    Location:
    Red Lodge, Suffolk, England
    Ratings:
    +21 / 4
    Home Country:
    United Kingdom United Kingdom
    Will all these fixes be included in 1.5? I had a look at the change log and there was no mention of them.
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!