The problem is that, you will have to upgrade your code each time, "official" MP code will be modified (same classes).
Some very salient points @framug.The problem is that, you will have to upgrade your code each time, "official" MP code will be modified (same classes).
For me, for the moment, I didn't see your modified code with a switch for no impact for others users.
Also, what would be weird is why your code should be integrated where mine was not, even with switches ? (but more "critical" because, scanning was not the only part, timeshifting/playing and recording 'ie real time' was also impacted).
If this change works, and it can be turned on and off in the settings, and in the off state, this change does not lead to a deterioration in the functional, it has the right to life.I am happy to collaborate for a solution that would keep everyone happy.
But, it feels like this may have met a natural end.
I am happy to collaborate for a solution that would keep everyone happy.
But, it feels like this may have met a natural end.
I don't wish to be a wet blanket, but I still think that the design of this proposed change is wrong:If this change works, and it can be turned on and off in the settings, and in the off state, this change does not lead to a deterioration in the functional, it has the right to life.
Although this is true in principle, "TV Server" is changing very little (if at all) from one release to the next. So if @vapourEyes 's modified DLL(s) won't work as is, a simple recompile should be all that is needed (not complicated remerging of his changes with changes originating from others). But you probably know more about this than I do.The problem is that, you will have to upgrade your code each time, "official" MP code will be modified (same classes).
Apologies @CyberSimian, I did not address this earlier.I don't wish to be a wet blanket, but I still think that the design of this proposed change is wrong:
(1) "Retain strongest duplicate" should not need to use a signal threshhold. If you are using a signal threshhold, then you have the wrong design. The right design is to compare the signal levels of the two MUXes so that you can discard the weaker. (You also need a setting to enable or disable this feature.)
(2) "Omit weak MUXes" does use a signal level threshhold, but it should be speciable by the user, and it should not eliminate duplicates.
See my earlier post in this thread.
It change a little sometimes."TV Server" is changing very little (if at all) from one release to the next.
I agree with this.There may be channels on MUX-a - that are not on MUX-b, so I don't want to ignore the weaker MUX.
@CyberSimian, Thank you.I agree with this.
"BBC1 SD" and "ITV1" have regional content (perhaps one or two other channels also). If you live on the border between two regions, you might be able to receive both variants (e.g. "BBC1 South" and "BBC1 East"), and you might want to have both variants in your EPG. Since all channels in a MUX have the same signal strength, it does not matter whether you compare the MUX signal strength, or the channel signal strength. However...
You still don't need a fixed threshhold during scanning when checking for duplicates. Example: if both MUXes contain "BBC2 SD", you retain the stronger channel and discard the weaker channel ("BBC2 SD" has no regional content).
Rejecting weak channels is a separate capability, and I don't think that the the two capabilities should be mixed up in the implementation. You need an enable/disable setting in "TV Server Config" for discarding duplicates, and a threshhold for rejecting weak channels. These are separate settings that should have separate action during the scan.
I should say that I am not familiar with the internals of TV Server, so I don't know how easy it would be to implement what I consider to be the "correct" design.
Please,take a look at the red rectangle, it's possible to have signal for channel.I think I can rid myself of the pesky threshold IFF I can store strength per-channel for the comparator. This would then mean that the Channel object has a strength field or something similar.
|Automatically Re-Tune Periodically||Improvement Suggestions||1|
|S||TV-Server MP1 - Automatic search doesn't work||Installation, configuration support||2|
|W||[solved] [FIXED] Survivor season 40 not automatically matching||My TVSeries||1|
|G||Switch to new channel at begining of program automatically||Feature Requests||0|
|C||How do I get MediaPortal to separate recording files by channel and month?||General||2|
|H||MP1.21F video database scan, can it be scheduled to automatically run in background||General Support||5|
|Online Videos - Automatic Updates fails 'Automatic update disabled. Check your internet connection'||OnlineVideos||10|
|1.20 final does not update video duration automatically||1.20||10|
|1.20 final does not update video duration automatically||1.20 Pre Release||1|
|M||TV Server can't tune to some DVB-S multiplexes while other software can||General||0|
|[Pending] DVB-C Tuning Parameters: Switzerland.UPC Cablecom [NID 43020] v.7.xml||Submit: EPG-Grabbers and tuningdetails||0|
|J||DVB-S2 card fails to tune? Subchannel count increasing||Television (MyTV frontend and TV-Server)||3|
|M||Tuning channels with quad tuner question||General||6|
|E||[solved] Vodafone Kabel dvb-c Braunschweig Tuning Liste (Stand 31.01.2019)||TV / Streaming||0|
|A||VB-IP SPAIN Movistar plus tunning details (Update 26 dec 2018)||Submit: EPG-Grabbers and tuningdetails||1|
|M||Wrong DVB-T tuning parameters for Sweden, Vannas - Granlundsberget||1.20 Pre Release||1|
|U||Client cannot tune channels||General||1|