CD Rip "Still" Does Not Work (1 Viewer)

hwahrmann

Development Group
  • Team MediaPortal
  • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    That's what id did already.
    Fix is in SVN
     

    smallishzulu

    Portal Pro
    December 25, 2006
    83
    0
    Istanbul
    Home Country
    Turkey Turkey
    1) Now it works. Except one thing, sorry I should say that :)

    It is related with "CD Tracklist View Bug" (https://forum.team-mediaportal.com/cd_tracklist_view_bug-t24536.html).

    Please give a look at that. After the track list names are changed, it is now impossible to import CD. Because, the labels are different.

    2) Also; I have an opinion to add to GUIMusicFiles.cs

    OnShowContextMenu Method:

    case 1100: // Import CD
    if (g_Player.Playing && g_Player.isCDA)
    g_Player.Stop(); // Hocus Pocus
    OnAction(new Action(Action.ActionType.ACTION_IMPORT_DISC, 0, 0));
    break;

    case 1101: // Import seltected track
    if (g_Player.Playing && g_Player.isCDA)
    g_Player.Stop(); // Hocus Pocus
    OnAction(new Action(Action.ActionType.ACTION_IMPORT_TRACK, 0, 0));
    break;

    Doing such a change can stop playback of CD to make import. Otherwise it seems like a bug. (I tried this but isCDA returns false. It didnt work. It needs a touch from heaven :) )
     

    hwahrmann

    Development Group
  • Team MediaPortal
  • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    Both solved now.
    code is in SVN.

    When you do an import playback stops.
    No need to check for g_player.isCDA as it isn't implemented. :-(

    the dialog options are displayed only anyhow, when you are on a CD drive.
     

    Users who are viewing this thread

    Top Bottom