Das Erste: Livestream not working | Page 2

Discussion in 'OnlineVideos' started by SilentBob, August 3, 2017.

  1. SilentBob

    SilentBob Portal Pro

    Joined:
    January 1, 2011
    Messages:
    54
    Likes Received:
    38
    Ratings:
    +50 / 0
    Home Country:
    Germany Germany
    please try with updated files here
    Das Erste: Livestream not working
    if you see other issues please let me know

    before i create a pull request i want to test it at least a little more ;)
    btw. i also added a small patch into OnlineVideos.dll, is this a problem for a pull request?

     
    • Thank You! Thank You! x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. joecrow
    • Team MediaPortal

    joecrow Test Group

    Joined:
    August 9, 2012
    Messages:
    1,479
    Likes Received:
    715
    Ratings:
    +1,195 / 2
    Home Country:
    Germany Germany
    Show System Specs
    On a very quick check it is looking good.(y)(y):)
    I will run a more thorough test later today and report back then but have no time right now, sorry.:p
     
  4. catavolt
    • Team MediaPortal
    • Administrator

    catavolt Design Group Manager

    Joined:
    August 13, 2007
    Messages:
    12,240
    Likes Received:
    4,982
    Gender:
    Male
    Occupation:
    Technical Documentation, Translation
    Location:
    Lanzarote
    Ratings:
    +7,396 / 38
    Home Country:
    Germany Germany
    Show System Specs
    New 2.3.1.2 works as expected - all live streams and mediathek videos are played w/o errors ;)
    Well done (y) (y) (y)
     
    • Like Like x 1
  5. joecrow
    • Team MediaPortal

    joecrow Test Group

    Joined:
    August 9, 2012
    Messages:
    1,479
    Likes Received:
    715
    Ratings:
    +1,195 / 2
    Home Country:
    Germany Germany
    Show System Specs
    Everything I have tried works perfect.(y)(y)(y)
    Good work.:):):)
     
  6. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,795
    Likes Received:
    751
    Location:
    Nuenen
    Ratings:
    +1,112 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Ok.
    Patching onlinevideos.dll is no problem for a pullrequest, however if the working of DasErste is dependant on it, a new version of onlinevideos has to be released.
    I do have some extra rights on the repo but sadly not enough to do a release...
     
    • Like Like x 1
  7. SilentBob

    SilentBob Portal Pro

    Joined:
    January 1, 2011
    Messages:
    54
    Likes Received:
    38
    Ratings:
    +50 / 0
    Home Country:
    Germany Germany
    Okay, so let me create two pull requests.
    one without adapting onlinevideo.dll and pulling needed adaption as a hack into the site dll.

    And one where I remove the hack from site dll and adapting the onlinevideo.dll, as it makes sense to have the changes there.

    Then we can already update the site dll and wait for an online video update.
     
    • Like Like x 1
  8. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,795
    Likes Received:
    751
    Location:
    Nuenen
    Ratings:
    +1,112 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Ok, it seems I have a lot to learn to review a pull request. (Couldn't get it to merge in my local source using tortoisegit to get a bit of an overview)

    3 remarks/questions:
    - May I point you to the HlsPlaylistParser class? That may save you a lot of code (or maybe not, didn't do an in-depth analysis)
    - That change in onlinevideos, couldn't that throw unwanted exceptions?
    - Either way, until a new version of onlinevideos is released, I think it's better to put that part in the util itself, so everyone can benefit without having to manually copy files and such
     
    • Thank You! Thank You! x 1
  9. SilentBob

    SilentBob Portal Pro

    Joined:
    January 1, 2011
    Messages:
    54
    Likes Received:
    38
    Ratings:
    +50 / 0
    Home Country:
    Germany Germany
    That's a good hint, i just wanted to fix the mediathek streams and did not look larger around. so my first intention was to quick fix it, and most of the code was already there from offbyone. In a next step i would have provided such a playlist parser as well, but good to see there is already one.
    Just a question: Is it by intention that only one stream is returned per streamname (e.g. if there are Urls for same size and bitrate, only one is returned)

    You asked me to provide the code as fast as possible ;)
    I can update the pull request or create another one, as i would like to do some clenaups as well.

    not more than already in. i changed the last fallback which already today returns default(T), default(T) means in most cases: null

    These are the default values for the more important types inside of CLR,
    • Classes - null
    • Nullable<T> - null
    • Numerics structs (int, double, decimal, etc) - 0
    • DateTime structs - 01/01/0001.
    • Char structs - empty char.
    • Bool structs - false
    The Convert call does not throw an exception it tries to convert, if possible you get your type if not null... so similar to todays implementation

    I did not got this point, maybe you could give an example, or mark the code in pullrequest comment.
    For me this pull request is just one fix of the mediathek(s) as I saw other issues as well. I would like to refactor some code and consolidate some communalties of the ard, zdf and wdr mediathek code
     
    • Like Like x 1
  10. doskabouter
    • Premium Supporter

    doskabouter Community Plugin Dev

    Joined:
    September 27, 2009
    Messages:
    2,795
    Likes Received:
    751
    Location:
    Nuenen
    Ratings:
    +1,112 / 1
    Home Country:
    Netherlands Netherlands
    Show System Specs
    For now: yes, the user isn't going to be wanting one over the other I presumed
    Do you want me to wait for that?
    Presumably no...
    Well, judging from the code I would expect JsonConvert.DeserializeObject to generate an exception if f.e. it isn't valid json, but I will try to understand it better. (Planning on deploying without this change anyway)
    Well, what I meant was that I'm planning on merging the pullrequest #164 (the one without onlinevideos modifications) so that everyone can just automatically update the site, and not having to wait for an onlinevideos update
     
    • Thank You! Thank You! x 1
  11. SilentBob

    SilentBob Portal Pro

    Joined:
    January 1, 2011
    Messages:
    54
    Likes Received:
    38
    Ratings:
    +50 / 0
    Home Country:
    Germany Germany
    yes do this, merge without onlinevideo dll, which has a smaller impact, and everyone can have the fixes already.:)
    As I will do some code cleanups and create another pull request for that, we can review it again and see then how we proceed with online videos dll.
    Currently only one site plugin benefits from that change, and therefore it is also okay to have it just there in the specific siteutil
     
    • Thank You! Thank You! x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!