DVD navigation doesn't work (2 Viewers)

[marshall]

It would be great if this were fixed. It is one of my few issues with MP. I thought it was my remote, but there is definitely an animated/not animated twist when I think back on when it works and when it doesn't. Also, the cursor does move, there is just no feedback on the screen showing it has done so.

I have learned to just go straight to the movie and not try to view any special features or navigate the menus at all.

 

[Eabin]

turns out that the needed modifications in MP are fairly small, but unfortunately significant. i got a working graph - and therefore DVD menus - up and running here, but i'm not sure if such a patch should get accepted in the RC stage. for testing, please replace the original files from todays svn snapshot with the attached ones, and report back about success/failure (with logfiles!).

as a note of warning: the attached files do contain some changes i made on the enhanced video renderer (evr) part, which differ from the ones in current svns. so make a backup copy, and don't blame me, if your machine explodes

 

[Olodin]

I installed SVN-Snapshot: 09-26-2007 01-03h - Revision:16036 and then copied over your two files but had no luck:
When I want to start a DVD nothing happens, but there are errors in the log:

[ERROR][MPMain]: Exception   :System.DllNotFoundException: Unable to load DLL 'dshowhelper.dll'

Attached is the complete error log.

Unfortunately some of the message is in german (is this 'cause of .Net on german Windows XP?). Please tell me if I shall translate.

Maybe we should open a thread in the bug report subforum for that? I've found three old issues in mantis, but all of them where marked fixed. They contain additional error description:

• NVIDIA decoder / navigator does not behave as expected when watching or navigating DVD's
• DVD menu not able to navigate using VMR9 using Cyberlink Navigator
• DVD navigation behavies wierd

 

[Jack Sparrow]

mmmm ... interesting.

Has someone of the develop team take a look at it ?

Anyway ... some comments Eabin:

1) You spoke about "evr" ... I guess that's mean Vista, am I wrong ??? Cannot work on XP.

2) If you put some new dll's, it's not only a matter of copying files, you have also to register it I guess ...


Anyway if the highlighting of the menu is on a different pin in the graph maybe we finally find the solution of this problem ... that would be really great !!!!

Regards

 

[Eabin]

Olodin: i will have a look at this.
@jack:
1) yes, evr means vista. but i updated the vmr9 part too, so it should work on XP just fine if you use those dlls.
2) no, it is just a matter of stopping MP, replacing those 2 dlls, and starting MP again (unless you run into troubles like olodin)

i have made a few updates to my patch, and it should be way more reliable now. i will upload the new version this evening.
tested a fair part of my dvd collection, and i have all menus working now, with MS MPEG2 decoder and Cyberlink SP decoder.

 

[Mr Hipp]

Eabin - Please upload the sources to sourceforge as a patch, then I will take a look at your patch to see if it can be merged

Regards

Mr Hipp

 

[Eabin]

olodin: please try the new files. your problem may have been due to some compile options (now the dll is statically linked)
mr. hipp: i attached the changed files in a seperate zip-file. they are working very well for me, but they perform rather verbose logging atm.

edit: mr. hipp: the second needed fix (to generate a working dshowhelper.dll) is to replace both occurences of SetNumberOfStreams(1) in dshowhelper.cpp with SetNumberOfStreams(4)

 

[Olodin]

olodin: please try the new files. your problem may have been due to some compile options (now the dll is statically linked)

I am just testing with my DVD collection and have to say: fantastic! Everywhere the navigation is now visible!

This is what DVD experience should be. I found myself browsing through the great special DVDs of "Lord of the Rings", which have very deep menus, after installing the two files.

Now that I see the navigation I have a question about the colors: they don't seem to be defined through the DVD anymore and now use some green/pink style, see attached screenshot. Is this coded in MediaPortal?

And another one: while using the two patched files I had three crashes after hitting "B" to stop. This happend in the menu and in the movie itself. Tried to reproduce this with the original files but had no luck. The logs of such a crash are also attached.

 

[Eabin]

that's good news

about the color bug: i have no idea, and haven't seen anything similar with my dvds yet. is it always the same green/pink colors, or are they different on each dvd, but weird?

the crashes i experience myself, but i haven't found the bug yet although they are 100% reproducable, and always happen to me when trying to stop a dvd which does not show a still image (e.g. in a menu).

edit: here is a preliminary crash-free version i have to do some more testing, and will upload sources later.

 

[jcm]

I also had the DVD Navigation problem caused by the Video Decoder not rendering an extra subpicture pin and i wrote a similar patch but I didn't publish it because I have some concerns about the way it's implemented.

- It's hacky.
- I read that inceasing the number of streams for the renderer increases the video memory needed.
(if that's the case increasing this number generally as proposed by Eabin would be bad)
- I don't know if it's not only caused by bad configuration of the video decoder. Because (in the case of Cyberlink SP Decoder) the decoder creates an extra "~SubPicture Out" pin if hardware accleration is activated, but I think it could be that in that case hardware accleration is not supported by the graphics adapter and shouldn't be activated in the first place (reason for Turn of DxVA option I guess)

If it is actually a good way to fix this problem (maybe PowerDVD or similar products do it the same way) then I think there is the need of some changes to MediaPortal which would be implementing DShowHelper functions and objects directly in MediaPortal in C# to have better access to the SetNumberOfStreams method (need explanation why this isn't done anyway - resp. why is DShowHelper implemented in C++) to prevent having extra Streams if they aren't needed. There could be a workaround by only moving the IVMRConfig methods to the VMR9Helper but then there has to be a real reason that the Presentor/Allocator is implemented in C++ which I don't get at this point.

well just my 2 cents, I hope you can explain some things to me so that I can learn about this topic some more^^