Extension Installer V2 (2 Viewers)

Disore

Portal Pro
February 27, 2009
72
16
Sweden Sweden
I have a problem where uninstalling my plugin doesn't remove all installed files. It leaves a file called AxisCameras.dll, which contains the implementation of ISetupForm which makes MP believe the plugin still is installed. When investigating the following folder:

%allusersprofile%\Application Data\Team MediaPortal\MediaPortal\Installer\V2\7295daa1-612d-4896-8672-443bd5ce5ba0\1.1.0.0\BackUp\%Base%\Plugins\Windows

I see AxisCameras.dll. Can you please describe in what situation a file is backed up, and also how this is affecting the uninstallation?
I would like to bump my question. I've done some more investigation, and it seems that when I uninstall Axis Cameras 1.0.0.0, the extension installer doesn't remove AxisCameras.dll. Is this a bug or a weird feature I don't understand?
 

vuego

Documentation Group
  • Team MediaPortal
  • August 5, 2006
    1,584
    744
    Göteborg
    Sweden Sweden
    Country flag
    I believe this is yet another bug in MPEI. I have the same problem that uninstall ignores the first file in a group. Is your dll file first in a group? Try moving it further down or add a dummy file if needed.
     

    Disore

    Portal Pro
    February 27, 2009
    72
    16
    Sweden Sweden
    I've tracked down my problem, and it is a bug.

    In class PackageClass we have the following code:

    Code:
    /// <summary>
    /// Do the unistall procces. The unistall file info should be alredy loaded.
    /// </summary>
    public void UnInstall()
    {
      for (int i = UnInstallInfo.Items.Count - 1; i > 0; i--)
      {
        UnInstallItem item = UnInstallInfo.Items[i];
        if (string.IsNullOrEmpty(item.ActionType))
        {
          MpeInstaller.InstallerTypeProviders[item.InstallType].Uninstall(this, item);
          if (FileUnInstalled != null)
            FileUnInstalled(this, new UnInstallEventArgs("Removing file " + Path.GetFileName(item.OriginalFile), item));
        }
        else
        {
          MpeInstaller.ActionProviders[item.ActionType].UnInstall(this, item);
          if (FileUnInstalled != null)
            FileUnInstalled(this, new UnInstallEventArgs("Removing action " + item.ActionType, item));
        }
      }
      UnInstallInfo.Items.Clear();
      DoAdditionalUnInstallTasks();
    }
    The problem is that the first file with index == 0 won't be uninstalled since 'i > 0' is stated in the for-loop. Dukus, can you fix this? Or else I volunteer to fix it if given the correct permissions. :)

    It won't help me since I've already released a second version of my plugin, and the leftover file from uninstalling the first version will be cached by MPE when installing the second version, but it may help new plugin developers.
     

    Seidelin

    Retired Team Member
  • Premium Supporter
  • August 14, 2006
    1,755
    652
    Kgs. Lyngby
    Denmark Denmark
    Country flag
    Fix is in svn 27925. Thanks for isolating the issue and providing the fix. It would be nice if you can verify the fix is working (binary attached), so we can close the mantis issue.
     

    Attachments

    Users Who Are Viewing This Thread (Users: 0, Guests: 2)

    OP Similar threads Forum Replies Date
    C Can't install any extensions - DLL error Installation, configuration support 19
    T MediaPortal Extensions Manager Fehlermeldung bei Installation einer Erweiterung Installationsprobleme? 1
    R New MP2 user issues: software encoders for analog & plug-in/extension installation General 2
    high [Evaluate] MP Extension Manager can't download HTTPS links MediaPortal 1 38
    R Verbindungsproblem bei MP Extension Manager Installationsprobleme? 2
    ajs [Help Us!] Extensions plugin question MediaPortal 1 8
    F Problems with new install of MP2 Newcomers Forum 3
    joecrow 1.25.0 5031: Error on Install. Bugreports 24
    P [solved] MP2 new install, 2 x hdhomerun tuners, client on same PC unable to view TV & recordings Newcomers Forum 8
    M MediaPortal2 TV Config Error on Install (0x80004005) General 7
    ajs [fixed] 5022: Improving the MPE Installer, providing nicer GUI :) MediaPortal 1 42
    Rob Hexenmeister Dependency error on install v2.3.2.0 OnlineVideos 28
    ajs [fixed] 5015: Improving the MP1 installer, providing nicer GUI :) MediaPortal 1 138
    N No TV or EPG on fresh install General 0
    D [solved] Changed username in Win10, now TV Server config crashes on fresh install Installation, configuration support 1
    doskabouter [Question] Optional installation of subcomponents in MPE1 Developer Discussions 1
    D Unable to install 1.22 on Win 10 Newcomers Forum 9
    D I just installed MP 1.23. Which version of Schedules Direct should I use, where do I obtain it from Newcomers Forum 6
    J Server vs Client Install General 5
    G Newb trying MP2, trouble with guide data General 5
    G MP1 TV Server "failed to upgrade the database" using MS Sql Server Installation, configuration support 3
    geotwticher [solved] Fatal Error 0x80070643 during MP2 installation General 7
    B 'Successful' install of MP2.2.2 on W8.1 - but can't connect to sql db General 1
    badboyxx MP installation aborts with an error Installation, configuration support 2
    cbr954rr [solved] No sound after clean install? General 24
    Similar threads

























    Top Bottom