Extension Installer V2 | Page 23

Discussion in 'Skins and Plugins Installer (MPEI)' started by dukus, October 5, 2009.

  1. Disore

    Disore Portal Pro

    Joined:
    February 27, 2009
    Messages:
    72
    Likes Received:
    8
    Ratings:
    +9 / 0
    Home Country:
    Sweden Sweden
    I would like to bump my question. I've done some more investigation, and it seems that when I uninstall Axis Cameras 1.0.0.0, the extension installer doesn't remove AxisCameras.dll. Is this a bug or a weird feature I don't understand?


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. vuego
    • Team MediaPortal

    vuego Documentation Group

    Joined:
    August 5, 2006
    Messages:
    1,568
    Likes Received:
    658
    Occupation:
    Alchemist, Astrobiologist, Exotic dancer
    Location:
    Göteborg
    Ratings:
    +865 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    I believe this is yet another bug in MPEI. I have the same problem that uninstall ignores the first file in a group. Is your dll file first in a group? Try moving it further down or add a dummy file if needed.
     
  4. Disore

    Disore Portal Pro

    Joined:
    February 27, 2009
    Messages:
    72
    Likes Received:
    8
    Ratings:
    +9 / 0
    Home Country:
    Sweden Sweden
    Yes it is. Thanks for the tip of moving it down, I'll try that.
     
  5. Disore

    Disore Portal Pro

    Joined:
    February 27, 2009
    Messages:
    72
    Likes Received:
    8
    Ratings:
    +9 / 0
    Home Country:
    Sweden Sweden
    I've tracked down my problem, and it is a bug.

    In class PackageClass we have the following code:

    Code (Text):
    1. /// <summary>
    2. /// Do the unistall procces. The unistall file info should be alredy loaded.
    3. /// </summary>
    4. public void UnInstall()
    5. {
    6.   for (int i = UnInstallInfo.Items.Count - 1; i > 0; i--)
    7.   {
    8.     UnInstallItem item = UnInstallInfo.Items[i];
    9.     if (string.IsNullOrEmpty(item.ActionType))
    10.     {
    11.       MpeInstaller.InstallerTypeProviders[item.InstallType].Uninstall(this, item);
    12.       if (FileUnInstalled != null)
    13.         FileUnInstalled(this, new UnInstallEventArgs("Removing file " + Path.GetFileName(item.OriginalFile), item));
    14.     }
    15.     else
    16.     {
    17.       MpeInstaller.ActionProviders[item.ActionType].UnInstall(this, item);
    18.       if (FileUnInstalled != null)
    19.         FileUnInstalled(this, new UnInstallEventArgs("Removing action " + item.ActionType, item));
    20.     }
    21.   }
    22.   UnInstallInfo.Items.Clear();
    23.   DoAdditionalUnInstallTasks();
    24. }
    The problem is that the first file with index == 0 won't be uninstalled since 'i > 0' is stated in the for-loop. Dukus, can you fix this? Or else I volunteer to fix it if given the correct permissions. :)

    It won't help me since I've already released a second version of my plugin, and the leftover file from uninstalling the first version will be cached by MPE when installing the second version, but it may help new plugin developers.
     
    • Like Like x 3
  6. Seidelin
    • Team MediaPortal

    Seidelin Retired Team Member

    Joined:
    August 14, 2006
    Messages:
    1,755
    Likes Received:
    327
    Occupation:
    Researcher
    Location:
    Kgs. Lyngby
    Ratings:
    +328 / 0
    Home Country:
    Denmark Denmark
    I can do it. I guess changing i > 0 to i >= 0 would do it?
     
  7. Seidelin
    • Team MediaPortal

    Seidelin Retired Team Member

    Joined:
    August 14, 2006
    Messages:
    1,755
    Likes Received:
    327
    Occupation:
    Researcher
    Location:
    Kgs. Lyngby
    Ratings:
    +328 / 0
    Home Country:
    Denmark Denmark

    Attached Files:

    • Like Like x 1
  8. Disore

    Disore Portal Pro

    Joined:
    February 27, 2009
    Messages:
    72
    Likes Received:
    8
    Ratings:
    +9 / 0
    Home Country:
    Sweden Sweden
    Thanks! That was fast :D:D:D
     
  9. Seidelin
    • Team MediaPortal

    Seidelin Retired Team Member

    Joined:
    August 14, 2006
    Messages:
    1,755
    Likes Received:
    327
    Occupation:
    Researcher
    Location:
    Kgs. Lyngby
    Ratings:
    +328 / 0
    Home Country:
    Denmark Denmark
    You did all the work (vuego/Disore). I can add the missing "=" to the code base.
     
  10. Seidelin
    • Team MediaPortal

    Seidelin Retired Team Member

    Joined:
    August 14, 2006
    Messages:
    1,755
    Likes Received:
    327
    Occupation:
    Researcher
    Location:
    Kgs. Lyngby
    Ratings:
    +328 / 0
    Home Country:
    Denmark Denmark
    Fix is in svn 27925. Thanks for isolating the issue and providing the fix. It would be nice if you can verify the fix is working (binary attached), so we can close the mantis issue.
     

    Attached Files:

    • MpeCore.zip
      File size:
      69.8 KB
      Uploaded:
      May 21, 2011
      Views:
      181
    • Like Like x 1
  11. vuego
    • Team MediaPortal

    vuego Documentation Group

    Joined:
    August 5, 2006
    Messages:
    1,568
    Likes Received:
    658
    Occupation:
    Alchemist, Astrobiologist, Exotic dancer
    Location:
    Göteborg
    Ratings:
    +865 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    Confirmed working!
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!