External player (1 Viewer)

[kenwonders]

Ok here is a zip of the 2 changed files in patch form. It was created against current master. I would appreciate comments, I think my g_player implementation is a bit ropey, perhaps it should be embedded into the 'if' statement below? I felt it was complicated enough to understand without my stuff on top there. The configuration changes are straightforward but my designer seems to have shifted the source code making a much bigger patch than should be.

I tested out on the main TV and it works as hoped. I think the wording next to the new checkboxes needs to lose 'external player' as it's already understood.

So, if you guys want, I could start renaming the section and make other changes to clean up the wording.

 

[mm1352000]

Hmmm, I think this patch can be improved. We have a dedicated configuration section for Blu-ray (already with a "use internal Blu-ray menu player" option), so personally for consistency I'd like to see the external Blu-ray player configuration go somewhere under there. That separation would also mean you could choose a different external player for DVDs and Blu-rays if you really wanted to. The virtual drive and autoplay sections should also really come out from under DVD as well, because they apply for Blu-ray as well. One step at a time though...

 

[kenwonders]

Completely agree. if you feel this would be included in future MP I'd be happy to work on such a change.

 

[mm1352000]

if you feel this would be included in future MP...

I can't guarantee, but I'd certainly support such a patch.

 

[kenwonders]

if you feel this would be included in future MP...

I can't guarantee, but I'd certainly support such a patch.

Sounds like a challenge. If you have any ideas on the reworking above what you've already suggested, please let me know.

 

[mm1352000]

Sure.
If it were me I might try and convert the "DVD Discs/Images Player" subsection to a component that can be reused by both sections, in a similar way to the post processing sections.

 

[kenwonders]

I haven't forgotten or run off, I have setup a new dev environment and started looking at it. Might have something next week.

 

[kenwonders]

Oh dear, I have been 'that guy'. I got caught up in a different project. Apologies. Might be something soonish but no guarantees. My apologies if anyone was waiting for this.

 

[HomeY]

Hmmm, I think this patch can be improved. We have a dedicated configuration section for Blu-ray (already with a "use internal Blu-ray menu player" option), so personally for consistency I'd like to see the external Blu-ray player configuration go somewhere under there.

Just read this reply.
Might be useful to clarify that this option has nothing to do with an external player, but targets the menu player. Checking this option means BDReader is used, unchecking this option means LAVSplitter is used (both with the internal player).

 

[mm1352000]

@kenwonders
Any progress...