I think requiring Stop to be pressed twice is sufficient to avoid accidental stops, without needing a dialog. Just a time window during which the second Stop has to be received should do.
But without the dialog, how will the user know that they need to press it again to actually stop the TV Stream.
I think it is a really useful feature for the WAF, who doesn't understand the whole paused TV thing and why she looses the stream.
A couple of improvements might be:
1) Make it optional in the config so the feature can be turned on/off
2) Make the dialogue come up as it currently does, but have it time-out after 4 seconds (or a configurable time), this will mean that rather having a YES/NO option in the dialogue you could just have "Press OK/STOP to confirm you wish to stop the timeshifting of live TV". If OK or STOP is not pressed the dialogue disappears after 4 seconds, or if the back button is pressed it goes away instantly.
3) Have the TV Service detect if the current programme is running “live” or “timeshifted”, if it is “live” then just stop playback as soon as stop is pressed (since no timeshift file will be lost), but if it is “timeshifted” then make sure the dialogue is presented.
4) if you were to implement items 1, 2 and 3, then it might also be good to make it consistent and behave the same way whether you are in full-screen mode or in a menu display.
Just a thought.
Robbo100