[solved] Interested with a little modification in your plugin ? (1 Viewer)

framug

Super Moderator
  • Team MediaPortal
  • January 31, 2005
    4,539
    549
    South of France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #1
    Hello @ltfearme,

    I modified a bit your (great) plugin.
    I explain you why :
    Sometimes, I use MP Tvplugin to watch recorded TV files (when I was already watching another TV channel for example).
    And sometimes I use your plugin to watch TV-series (when I start the computer, for example).
    Then, when I delete a file in MP recorded, file(s) is(are) deleted in TV-series, I saw you added a mechanism to update your TV-series database automaticaly.

    BUT, when I delete a file in TV-series plugin (I mean a physically delete file), file still exist in MP Tvplugin.
    Of course because the MP recording table database is not updated.
    Thus, I added this.

    So, if someone want to test, here are modified plugin files
     

    Attachments

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,698
    7,083
    Sydney
    Australia Australia
    Country flag
    @framug, feel free to submit a pull request which describes the change (hard to know what has changed from just the binaries).

    Thanks.
     

    framug

    Super Moderator
  • Team MediaPortal
  • January 31, 2005
    4,539
    549
    South of France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #3
    Hello,

    I submit a pull request (first time with GIT for me).
    You will see that references have been added (.csproj file) then, you have to copy Gentle.Framework.dll, TvBusinessLayer.dll and TVDatabase.dll from MP in your "External" mptvseries folder.
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,369
    4,996
    France - IDF
    France France
    Country flag
    You will see that references have been added (.csproj file) then, you have to copy Gentle.Framework.dll, TvBusinessLayer.dll and TVDatabase.dll from MP in your "External" mptvseries folder.
    hello @framug ith git, all files included in your pullrequest will be pushed too, only to check if are checked during commit.
     

    framug

    Super Moderator
  • Team MediaPortal
  • January 31, 2005
    4,539
    549
    South of France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #5
    Yes, I saw this.
    I can deliver or create a branch but, only locally (difference with SVN ?)
    And, if I try a push, it seems that I need write access for mptvseries (or I don't use GIT correctly yet...)
    At least I use my modifications since some days and, it's a pleasure, it exactly suit my needs.
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,369
    4,996
    France - IDF
    France France
    Country flag
    I can deliver or create a branch but, only locally (difference with SVN ?)
    And, if I try a push, it seems that I need write access for mptvseries (or I don't use GIT correctly yet...)
    you need to create an github account, and maybe push your MP repo to your own repo.
    i'm not expert with pull request
     

    framug

    Super Moderator
  • Team MediaPortal
  • January 31, 2005
    4,539
    549
    South of France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #7
    I have a github account.
    It seems weird to me to push this repo in my own repo but, maybe it works like this ?
    Otherwise, I can also create a patch...
     

    framug

    Super Moderator
  • Team MediaPortal
  • January 31, 2005
    4,539
    549
    South of France
    France France
    Country flag
    • Thread starter
    • Moderator
    • #9

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom