Interested with a little modification in your plugin ?

Discussion in 'My TVSeries' started by framug, August 17, 2019.

  1. framug

    framug Portal Pro

    Joined:
    January 31, 2005
    Messages:
    4,173
    Likes Received:
    200
    Occupation:
    software engineer
    Location:
    South of France
    Ratings:
    +239 / 2
    Home Country:
    France France
    Hello @ltfearme,



    I modified a bit your (great) plugin.
    I explain you why :
    Sometimes, I use MP Tvplugin to watch recorded TV files (when I was already watching another TV channel for example).
    And sometimes I use your plugin to watch TV-series (when I start the computer, for example).
    Then, when I delete a file in MP recorded, file(s) is(are) deleted in TV-series, I saw you added a mechanism to update your TV-series database automaticaly.

    BUT, when I delete a file in TV-series plugin (I mean a physically delete file), file still exist in MP Tvplugin.
    Of course because the MP recording table database is not updated.
    Thus, I added this.

    So, if someone want to test, here are modified plugin files
     

    Attached Files:

    • modif fmu.rar
      File size:
      554.5 KB
      Uploaded:
      August 17, 2019
      Views:
      5
    • Like Like x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    @framug, feel free to submit a pull request which describes the change (hard to know what has changed from just the binaries).

    Thanks.
     
    • Like Like x 1
  4. framug

    framug Portal Pro

    Joined:
    January 31, 2005
    Messages:
    4,173
    Likes Received:
    200
    Occupation:
    software engineer
    Location:
    South of France
    Ratings:
    +239 / 2
    Home Country:
    France France
    Hello,

    I submit a pull request (first time with GIT for me).
    You will see that references have been added (.csproj file) then, you have to copy Gentle.Framework.dll, TvBusinessLayer.dll and TVDatabase.dll from MP in your "External" mptvseries folder.
     
    • Like Like x 2
  5. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,397
    Likes Received:
    2,479
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,136 / 13
    Home Country:
    France France
    Show System Specs
    hello @framug ith git, all files included in your pullrequest will be pushed too, only to check if are checked during commit.
     
    • Like Like x 1
  6. framug

    framug Portal Pro

    Joined:
    January 31, 2005
    Messages:
    4,173
    Likes Received:
    200
    Occupation:
    software engineer
    Location:
    South of France
    Ratings:
    +239 / 2
    Home Country:
    France France
    Yes, I saw this.
    I can deliver or create a branch but, only locally (difference with SVN ?)
    And, if I try a push, it seems that I need write access for mptvseries (or I don't use GIT correctly yet...)
    At least I use my modifications since some days and, it's a pleasure, it exactly suit my needs.
     
  7. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,397
    Likes Received:
    2,479
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,136 / 13
    Home Country:
    France France
    Show System Specs
    you need to create an github account, and maybe push your MP repo to your own repo.
    i'm not expert with pull request
     
    • Like Like x 1
  8. framug

    framug Portal Pro

    Joined:
    January 31, 2005
    Messages:
    4,173
    Likes Received:
    200
    Occupation:
    software engineer
    Location:
    South of France
    Ratings:
    +239 / 2
    Home Country:
    France France
    I have a github account.
    It seems weird to me to push this repo in my own repo but, maybe it works like this ?
    Otherwise, I can also create a patch...
     
    • Like Like x 1
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,240
    Likes Received:
    6,203
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,202 / 9
    Home Country:
    France France
    Show System Specs
    Yes create a patch can work and to write to TVS repo, you need to have right.
    So patch / create repo on your side. Etc.

    Tapatalk
     
    • Informative Informative x 1
  10. framug

    framug Portal Pro

    Joined:
    January 31, 2005
    Messages:
    4,173
    Likes Received:
    200
    Occupation:
    software engineer
    Location:
    South of France
    Ratings:
    +239 / 2
    Home Country:
    France France
    That's why I wrote MP .dlls should be copied locally in this case.
    It seems logical yo me...
    Yes but, what about a collaborative way ? How can it be integrated in the master, finally ?
     
    • Like Like x 1
  11. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,397
    Likes Received:
    2,479
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,136 / 13
    Home Country:
    France France
    Show System Specs
    the best is pull request or provide an branch on your own account.

    edit : if you need help ask.
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!