[solved] Interested with a little modification in your plugin ? (1 Viewer)

[framug]

Hello @ltfearme,

I modified a bit your (great) plugin.
I explain you why :
Sometimes, I use MP Tvplugin to watch recorded TV files (when I was already watching another TV channel for example).
And sometimes I use your plugin to watch TV-series (when I start the computer, for example).
Then, when I delete a file in MP recorded, file(s) is(are) deleted in TV-series, I saw you added a mechanism to update your TV-series database automaticaly.

BUT, when I delete a file in TV-series plugin (I mean a physically delete file), file still exist in MP Tvplugin.
Of course because the MP recording table database is not updated.
Thus, I added this.

So, if someone want to test, here are modified plugin files

 

[ltfearme]

@framug, feel free to submit a pull request which describes the change (hard to know what has changed from just the binaries).

Thanks.

 

[framug]

Hello,

I submit a pull request (first time with GIT for me).
You will see that references have been added (.csproj file) then, you have to copy Gentle.Framework.dll, TvBusinessLayer.dll and TVDatabase.dll from MP in your "External" mptvseries folder.

 

[azzuro]

You will see that references have been added (.csproj file) then, you have to copy Gentle.Framework.dll, TvBusinessLayer.dll and TVDatabase.dll from MP in your "External" mptvseries folder.

hello @framug ith git, all files included in your pullrequest will be pushed too, only to check if are checked during commit.

 

[framug]

Yes, I saw this.
I can deliver or create a branch but, only locally (difference with SVN ?)
And, if I try a push, it seems that I need write access for mptvseries (or I don't use GIT correctly yet...)
At least I use my modifications since some days and, it's a pleasure, it exactly suit my needs.

 

[azzuro]

I can deliver or create a branch but, only locally (difference with SVN ?)
And, if I try a push, it seems that I need write access for mptvseries (or I don't use GIT correctly yet...)

you need to create an github account, and maybe push your MP repo to your own repo.
i'm not expert with pull request

 

[framug]

I have a github account.
It seems weird to me to push this repo in my own repo but, maybe it works like this ?
Otherwise, I can also create a patch...

 

[Sebastiii]

Yes create a patch can work and to write to TVS repo, you need to have right.
So patch / create repo on your side. Etc.

Tapatalk

 

[framug]

Yes create a patch can work

That's why I wrote MP .dlls should be copied locally in this case.

and to write to TVS repo, you need to have right.

It seems logical yo me...

So patch / create repo on your side. Etc.

Yes but, what about a collaborative way ? How can it be integrated in the master, finally ?

 

[azzuro]

Yes but, what about a collaborative way ? How can it be integrated in the master, finally ?

the best is pull request or provide an branch on your own account.

edit : if you need help ask.