[WiP] madVR support in MP1 (30 Viewers)

[Sebastiii]

btw the code for restore :

Log("MPMadPresenter::Destructor() - m_pMad release 1");
    if (m_pMad)
    {
      // Let's madVR restore original display mode (when adjust refresh it's handled by madVR)
      if (Com::SmartQIPtr<IMadVRCommand> pMadVrCmd = m_pMad)
      {
        pMadVrCmd->SendCommand("restoreDisplayModeNow");
        pMadVrCmd.Release();
        Log("MPMadPresenter::Destructor() - restoreDisplayModeNow");
      }
      m_pMad.FullRelease();
    }
    Log("MPMadPresenter::Destructor() - m_pMad release 2");

 

[Rick164]

Thanks, tested with the videohelp.com linked version and MadVR is restoring refresh rate correctly there when Kodi is on either primary or secondary screen.

 

[Sebastiii]

Nice so now why on MP it doesn't works
maybe and surely because of some kind of delay introduced by c# vs c++ or it's something else.

 

[Sebastiii]

Kodi DS code :

CmadVRAllocatorPresenter::~CmadVRAllocatorPresenter()
{
  if (m_pSRCB) {
    // nasty, but we have to let it know about our death somehow
    ((CSubRenderCallback*)(ISubRenderCallback2*)m_pSRCB)->SetDXRAP(nullptr);
  }
 
  if (m_pORCB) {
    // nasty, but we have to let it know about our death somehow
    ((COsdRenderCallback*)(IOsdRenderCallback*)m_pORCB)->SetDXRAP(nullptr);
  }

  // Unregister madVR Exclusive Callback
  if (Com::SmartQIPtr<IMadVRExclusiveModeCallback> pEXL = m_pDXR)
    pEXL->Unregister(m_exclusiveCallback, this);

  // Let's madVR restore original display mode (when adjust refresh it's handled by madVR)
  if (Com::SmartQIPtr<IMadVRCommand> pMadVrCmd = m_pDXR)
    pMadVrCmd->SendCommand("restoreDisplayModeNow");

  g_renderManager.UnInit();
  g_advancedSettings.m_guiAlgorithmDirtyRegions = m_kodiGuiDirtyAlgo;
 
  // the order is important here
  CDSRendererCallback::Destroy();
  SAFE_DELETE(m_pMadvrShared);
  m_pSubPicQueue = nullptr;
  m_pAllocator = nullptr;
  m_pDXR = nullptr;
  m_pORCB = nullptr;
  m_pSRCB = nullptr;

  CLog::Log(LOGDEBUG, "%s Resources released", __FUNCTION__);
}

 

[Sebastiii]

Maybe it's not C++ issue, i will need to try something with you

 

[Rick164]

Yeah think it releases / restored the window correctly, before it crashed when restoring refresh rate with secondary window so maybe it's the fix from V227-229 (not sure which) ?
On IRC so can ping if you have the time

What we could try is to log the specific steps and see if perhaps it's crashing before it can reach "restoreDisplayModeNow" , any idea if we need to store the current display refresh rate on renderer start for MadVR or is that handled internally?
We also have some MPC-HC examples here:

https://fossies.org/windows/misc/mpc-hc-1.7.10.zip/mpc-hc-1.7.10/include/mvrInterfaces.h
https://github.com/MediaBrowser/Emby.Theater.Windows/blob/master/Emby.Theater.DirectShow/MadvrInterface.c <-- Looks incomplete

 

[Sebastiii]

Thanks
mvrinterfaces.h comes from madshi bin
The other one i have take some part but didn't work correctly under MP lol

 

[Sebastiii]

Hey

i can reproduce the issue about not refresh rate on multi-screen and manage to fix it (not sure if it will solve the issue on crimson driver @joecrow)
I will link to a new installer in first post asap

 

[Sebastiii]

V233 in first post

 

[joecrow]

Hey

i can reproduce the issue about not refresh rate on multi-screen and manage to fix it (not sure if it will solve the issue on crimson driver @joecrow)
I will link to a new installer in first post asap

It may be academic, I'm almost decided on keeping the Nvidia GTX 1050 Ti, maybe @Kotik or @GeYe can give some feedback.