[WiP] madVR support in MP1 (18 Viewers)

[Sebastiii]

@alexdepalma

Could you try the attached bin ?
Thanks.

 

[Sebastiii]

@kenwonders
Can you try also V411 on top of V407 master build too ?
It should be better but need to understand how to reproduce the null ref exception in TVGuide, i think i know where it comes from (releasing texture and added them) this is needed to fully unloaded leak in memory while running madVR but break the progress in TVGuide lol

 

[Sebastiii]

I was able to reproduce the null ref for TV Guide
So trying to fixed it, i have something but need to confirm myself first

 

[Sebastiii]

@kenwonders and for others too
This one should fix the null reference for TVGuide but also fix the empty list for Video (can't reproduce that one but i think it should solve it)

 

[kenwonders]

Ok this isn't crashing, and under many circumstances it's fine. Thanks! However here is a behaviour that I don't know is good or bad, maybe you decide!

If you start TV, but then (while TV is running) go to Videos. Pressing stop here takes me to the Home screen, which is neither where I was, or where the media was from. I attach a log from my first load with v412, the stop occurs at about 9:40.

Thanks as always for your work Seb.

 

[Sebastiii]

Good find
Will try to do the latest fix differently but yes it comes from it for sure.
If you stay in current window it works right (i mean no jump to other window like TV to Video)

And you confirm that it's not crashing for sure right

 

[kenwonders]

Can you ever be sure?

I'll hammer it and see if I can break.

 

[Sebastiii]

At least i can reproduce it
In fact the last commit permit to reinit the previous window when doing a stop so for ex when we start TV from TVGuide and doing a stop it restore TVGuide but here when going to MyVideo it goes in between to home and then on stop (myvideo) it reload Home.

Will try to change the behavior to the reload the current window, not sure if it will work but will try (tomorrow now, i'm quite off to bed)

But nice you can test and report feedback

 

[kenwonders]

Seems good after a bit of button mashing. It is quick too, adding to the feel that things went well under the bonnet (even if not!).

Is there not a current GUi window rather than previous? Ie if I press stop while TV playing but on Video screen, there must be a handle to that screen?

cheers @Sebastiii !

 

[Sebastiii]

@kenwonders
I have try to use current window, on quick test it seems better but you can confirm it on your side