[Bug] Mantis 3731: "Checkmark control is not scaled" is not completely fixed (1 Viewer)

Lbr_Lion

Extension Designer
July 19, 2008
243
372
Home Country
Netherlands Netherlands
Hi,

It looks like that mantis 3731 is not completely fixed: The "Checkmark" control is scaled now, but the "Checkbutton" control not yet:

Selectbutton_1280x720.png

1280x720

Selectbutton_1920x1080.png

1920x1080

Cheers,
 

ajp8164

Portal Pro
January 9, 2008
575
1,166
Atlanta, GA
Home Country
United States of America United States of America
Looking at the implementation I can see why it doesn't work. Definitely a bug!
 

Lbr_Lion

Extension Designer
July 19, 2008
243
372
Home Country
Netherlands Netherlands
  • Thread starter
  • Moderator
  • #5
Hi,

I don't know or you did test it in window mode, but it looks like it is less clear in this mode.

I can reproduce it in fullscreen mode by the following steps.

- (Close MediaPortal)
- Set desktop size to 720p (1280x720)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring
- Close MediaPortal
- Set desktop size to 1080p (1920x1080)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring

Via these steps I can clearly see the difference in size and location of the checkmark. (Also in Default Wide skin)
 

elliottmc

Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Have we checked in the code that the fix was correctly included? Mistakes do happen.
     

    ajp8164

    Portal Pro
    January 9, 2008
    575
    1,166
    Atlanta, GA
    Home Country
    United States of America United States of America
    Hi,

    I don't know or you did test it in window mode, but it looks like it is less clear in this mode.

    I can reproduce it in fullscreen mode by the following steps.

    - (Close MediaPortal)
    - Set desktop size to 720p (1280x720)
    - Start MediaPortal in fullscreen mode
    - Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring
    - Close MediaPortal
    - Set desktop size to 1080p (1920x1080)
    - Start MediaPortal in fullscreen mode
    - Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring

    Via these steps I can clearly see the difference in size and location of the checkmark. (Also in Default Wide skin)
    Yep, verified. Now we need to figure out what's wrong...
     

    Lbr_Lion

    Extension Designer
    July 19, 2008
    243
    372
    Home Country
    Netherlands Netherlands
    • Thread starter
    • Moderator
    • #9
    Thanks!

    Build a new version based on the branch and did the same steps as mentioned in the previous post and everything works fine now.

    PS. I noticed also that the HD logo in the TV Guide is not scaled. Can you have a look to this also?
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Since this is a one-line fix that is confirmed to fix the issue, I suggest that Andy sends a PM to a development team manager to approve merge to master.

    Mark
     

    Users who are viewing this thread

    Similar threads

    MP1 MP2 MP2 - V2.5 Sony Bravia 32S5100 DE
    When i was using 2.5, and like im using MP1, i set the resolution of my desktop. And MEPo just uses whatever i have set.
    When i was using 2.5, and like im using MP1, i set the resolution of my desktop. And MEPo just uses whatever i have set.
    MP 2.5 does not recognize my Bravia 32S5100 as 1920x1080 but only as 1280x720. The PC's monitor is recognized as 1920x1080. Both...
    Replies
    2
    Views
    771
    Reading through your code, I can see it's more than a couple steps above my paygrade. :cry:
    Reading through your code, I can see it's more than a couple steps above my paygrade. :cry:
    I used to run the TVService under the "NT Service\TVService" account to follow least privileges principal (not exposing my whole...
    Replies
    3
    Views
    2K
    4.5 is really old. I'm not sure 4.5.5 even is a version that actually existed. You should be able to install .NET Framework 4.8.0 on Windows 7 SP1
    4.5 is really old. I'm not sure 4.5.5 even is a version that actually existed. You should be able to install .NET Framework 4.8.0...
    My TV PC is more a cast-off on older hardware (a 'Quiet PC' i5 4690, 16GB ram, 2xSSD 1xHDD, system graphics), mainly as a cheap way...
    Replies
    5
    Views
    2K
    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team will create a Jira ticket, and for each ticket, you’ll make the changes and submit a pull request. This will be transparent and straightforward.
    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team...
    I'm very glad to see that mediaportal 1 is on github, where ordinary devs with github accounts can make contributions. Please can...
    Replies
    7
    Views
    1K
    Nice finding! (y)(y)(y) Adapted to new DWHD and PVHD ;) Position is in front of category bar ;)
    Nice finding! (y)(y)(y) Adapted to new DWHD and PVHD ;) Position is in front of category bar ;)
    This thread is intended for skin authors, plus those advanced users who have learnt skin programming and have customised the skins...
    Replies
    1
    Views
    2K
    Top Bottom