1.23.0 MatroskaTagInfo uses the wrong casing for tags (1 Viewer)

doskabouter

Development Group
  • Team MediaPortal
  • September 27, 2009
    3,570
    1,788
    Nuenen
    Netherlands Netherlands
    Country flag
    That's true for the most part.
    My concerns are not about code size, but more that it takes effort to keep that stuff working.
    Especially in a year or so when the devs do not have the old (wrong) format xml's on their system, we still have to make sure reading old style xml's still works.

    But then again, the code to do that is fairly simple, devs just have to keep this in mind when fixing/refactoring that area.

    To summarize the issue: when downloading metadata from imdb for videos, the metadata is stored and read in a wrong format (xml next to the video file). Onlinevideos also stores metadata but in the correct format. when mixing those 2 (f.e. when you have the onlinevideos download folder also in the videos section), the videos section can't find the metadata and does not display the title and description.

    I will add a backwards compatibility mode to my fix.
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,570
    1,788
    Nuenen
    Netherlands Netherlands
    Country flag
    Added support for reading old-style xmls.

    The only thing left is that if users install newest MP, and add fetch metadata from imdb for their videos, and after that downgrading MP the title and description will not show for those videos.
    Assuming they will be upgrading sooner or later, that issue will resolve itself.

    Only thing is, I can't test this properly as I have no old xml files present on my system. But I'm fairly confident that this will work...
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,570
    1,788
    Nuenen
    Netherlands Netherlands
    Country flag
    Ah crap.
    Just noticed there are three places where that xml is read...
    MediaPortal/MediaPortal-1
    internal in MediaPortal.GUI.Video namespace
    added a really long (>10 years) ago
    and
    MediaPortal/MediaPortal-1
    public in MediaPortal.Video.Database namespace
    added about 7 years ago
    and
    MediaPortal/MediaPortal-1
    public in TvDatabase namespace
    added a really long (>10 years) ago

    Codewise its better to remove the one in the IMDBMovie file, because I think its not at its proper place, but that one is public, so possibly used by other plugins...
    The one in MatroskaTagLib is nowhere used in mediaportal, and because it's internal, there's no worries about other dependencies failing.

    Pff. and another thing I noticed: MatroskaTagHandler.Persist is never called from mediaportal at least (being a public method, theoretically it could be called from somewhere else). So at least in recent mediaportals there is never going to be an xml file in the old format.

    However, the only place where I found that such a xml file is written is in the tvservice, for recorded tv.
    That's one area I don't like to change because of lots more dependencies (MP2 for example), but it gives me a good place to test!

    So my solution is (as is committed now to my pullrequest Bug mp1 4977 matroska tag info uses the wrong casing for tags by doskabouter · Pull Request #182 · MediaPortal/MediaPortal-1):
    removed the MatroskaTagLib.cs from mediaportal solution
    removed persist code from mediaportal
    removed unused properties from IMDBMovie's MatroskaTagInfo
    added support for correct and incorrect xml-files.

    So from my point of view this is mergeable without any regressions.
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,570
    1,788
    Nuenen
    Netherlands Netherlands
    Country flag
    this couldn't be used in other tool as all the methods were marked as internal.
    and if needed again it's easy enough to add it. Perhaps then we could do a bit of refactoring because now reading and writing matroskatags is in 3 places all slightly different
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,607
    5,232
    France - IDF
    France France
    Country flag
    and if needed again it's easy enough to add it. Perhaps then we could do a bit of refactoring because now reading and writing matroskatags is in 3 places all slightly different
    can be great for me, if you done change can you base your work on test4+PR please
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    morpheus_xx [WiP] OnlineVideos: New browser based playback support using WebDriver, new Amazon siteutil MediaPortal 2 14
    toricred [solved] Configuring TV Server to use NAS General 5
    vvulture Using Windows 10 MediaPortal 1 Talk 8
    atlantic How to use Spotify inside Mediaportal? Listen Music 18
    Megane Too much RAM used (over 2 GB). General Support 18
    D how to disengage from one version of a plugin to use another Newcomers Forum 0
    D I just installed MP 1.23. Which version of Schedules Direct should I use, where do I obtain it from Newcomers Forum 6
    M Can i use my Vu+ Zero 4k Tuner for Mediaportal? General 0
    benicehavefun Using MePo TV Server 1.23 via MPExtended/WebMediaPortal as a Backend for Plex MPExtended 4
    G MP1 TV Server "failed to upgrade the database" using MS Sql Server Installation, configuration support 3
    1gkar Use Alternative Sites to Scrape Series Info My TVSeries 5
    T Can Emprex 3009ARF III MCE Remote Control be used to toggle Fullscreen/Windowed mode?? Remotes 7
    S [solved] Live TV subtitle issue if not using 100% font General 31
    N [Proposal] Make text input using remote control easier MediaPortal 2 4
    T Issues with MediaPortal not starting correctly using versions after 1.20 Final General Support 6
    erika jandova Using SD and MediaPortal 1 Newcomers Forum 4
    D Large xml database in My Movies Management. I remain unclear on use My Films as bridge to MP2.2 General 9
    N [solved] When MP2-Client is trying to register credentials, it uses the wrong machine name MediaPortal 2 7
    high [Help Me!] Atlassian Fisheye/Crucible still used? Team Lounge 8
    D [solved] HID remote for mp2 and w10 64 bit? using all tools: sony, cisco, homeworkx ng General 2
    Symphy Still being used? ASIO music player 0
    P no signal when scanning for channels using antenna and dual hd General Support 2
    N Using mediaportal in lieu of hauppauge wintv Newcomers Forum 10
    T No data available using xmltv and mc2xml xmlTV 2
    Similar threads

























    Top Bottom