1.23.0 MatroskaTagInfo uses the wrong casing for tags (1 Viewer)

doskabouter

Development Group
  • Team MediaPortal
  • September 27, 2009
    3,566
    1,782
    Nuenen
    Netherlands Netherlands
    Country flag
    MediaPortal Version: 1.23

    Description
    Title says it all...
    Jira: [MP1-4977] MatroskaTagInfo uses the wrong casing for tags - MediaPortal Jira
    PR:Bug mp1 4977 matroska tag info uses the wrong casing for tags by doskabouter · Pull Request #182 · MediaPortal/MediaPortal-1

    Still needs some discussion, as this is a breaking change.
    I could add something that is able to read old-style xml's and optionally save them as correct ones?

    What do you guys think?

    Steps to Reproduce:
    Play a video downloaded by onlinevideos with the videos-plugin
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,607
    5,232
    France - IDF
    France France
    Country flag
    hello @doskabouter
    thank you for providing support,
    can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
    thank you.

    ps: what result we will have actually when trying to play with onlinevideos ?
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,566
    1,782
    Nuenen
    Netherlands Netherlands
    Country flag
    hello @doskabouter
    thank you for providing support,
    can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
    thank you.

    ps: what result we will have actually when trying to play with onlinevideos ?
    Are there relevant changes in that area in the test3 branch then?
    And for onlinevideos there will not be any differences. the wrong casing is in mediaportal
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,566
    1,782
    Nuenen
    Netherlands Netherlands
    Country flag
    Good idea :)
    Any more opinions on this?
    there are 3 choices:

    1: Create separate a tool that fixes the xmlfiles, and have it run at install/update
    2: When MP encounters a wrong-cased xmlfile fix it and save it
    3: Support both wrong-cased and correctly-cased xmlfiles

    In my opinion option 1 is the best one, and reduces the legacy stuff we have to maintain in mediaportal

    It's also the hardest one to integrate in the update process.
    Options 1 and 2 also make it impossible to downgrade Mediaportal.

    So I guess we'll end up with option 3 and have another piece of legacy we have to maintain, test and keep working,,,
    Unless ofcourse someone has a brilliant option 4 or a strong opinion on options 1 or 2
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    12,468
    7,162
    Kyiv
    Ukraine Ukraine
    Country flag
    How determine where files from OnlineVideos stored? When MP installed some resources maybe not work... NAS shutdown ... etc...
    IMHO support old and new better ...

    --
    WBR, ajs :):whistle::coffee:
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    3,566
    1,782
    Nuenen
    Netherlands Netherlands
    Country flag
    I think you're misunderstanding me. The files from onlinevideos are correct, it's the files created by mediaportal that are wrong.
    But apart from that, I think you're right about option 3 (reluctantly...). Anyone else want to give me their opinion?
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    12,468
    7,162
    Kyiv
    Ukraine Ukraine
    Country flag
    I dont use OV for download, and dont know where and how this XML stored and used :)

    --
    WBR, ajs :):whistle::coffee:
     

    CyberSimian

    Test Group
  • Team MediaPortal
  • June 10, 2013
    2,076
    1,284
    Southampton
    United Kingdom United Kingdom
    Country flag
    Anyone else want to give me their opinion?
    I too have no idea what this is all about, but my view is that upward compatibility should be mandatory in all circumstances. :eek: :eek: :eek:

    Yes, that means that there is legacy code in the product, but being legacy code also means that it should not need changing in the future (it's legacy -- it merely needs to be invoked when the circumstances demand it). So, the product is bigger than it need be, but in the era of multi-gigabyte RAM installations, who cares?

    We do users a disservice if we change things without maintaining compatibility with what went before.

    -- from CyberSimian in the UK
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    morpheus_xx [WiP] OnlineVideos: New browser based playback support using WebDriver, new Amazon siteutil MediaPortal 2 14
    toricred [solved] Configuring TV Server to use NAS General 5
    vvulture Using Windows 10 MediaPortal 1 Talk 8
    atlantic How to use Spotify inside Mediaportal? Listen Music 18
    Megane Too much RAM used (over 2 GB). General Support 18
    D how to disengage from one version of a plugin to use another Newcomers Forum 0
    D I just installed MP 1.23. Which version of Schedules Direct should I use, where do I obtain it from Newcomers Forum 6
    M Can i use my Vu+ Zero 4k Tuner for Mediaportal? General 0
    benicehavefun Using MePo TV Server 1.23 via MPExtended/WebMediaPortal as a Backend for Plex MPExtended 4
    G MP1 TV Server "failed to upgrade the database" using MS Sql Server Installation, configuration support 3
    1gkar Use Alternative Sites to Scrape Series Info My TVSeries 5
    T Can Emprex 3009ARF III MCE Remote Control be used to toggle Fullscreen/Windowed mode?? Remotes 7
    S [solved] Live TV subtitle issue if not using 100% font General 31
    N [Proposal] Make text input using remote control easier MediaPortal 2 4
    T Issues with MediaPortal not starting correctly using versions after 1.20 Final General Support 6
    erika jandova Using SD and MediaPortal 1 Newcomers Forum 4
    D Large xml database in My Movies Management. I remain unclear on use My Films as bridge to MP2.2 General 9
    N [solved] When MP2-Client is trying to register credentials, it uses the wrong machine name MediaPortal 2 7
    high [Help Me!] Atlassian Fisheye/Crucible still used? Team Lounge 8
    D [solved] HID remote for mp2 and w10 64 bit? using all tools: sony, cisco, homeworkx ng General 2
    Symphy Still being used? ASIO music player 0
    P no signal when scanning for channels using antenna and dual hd General Support 2
    N Using mediaportal in lieu of hauppauge wintv Newcomers Forum 10
    T No data available using xmltv and mc2xml xmlTV 2
    Similar threads

























    Top Bottom