1.23.0 MatroskaTagInfo uses the wrong casing for tags (1 Viewer)

doskabouter

Development Group
  • Team MediaPortal
  • September 27, 2009
    4,023
    2,260
    Nuenen
    Home Country
    Netherlands Netherlands
    Country flag
    MediaPortal Version: 1.23

    Description
    Title says it all...
    Jira: [MP1-4977] MatroskaTagInfo uses the wrong casing for tags - MediaPortal Jira
    PR:Bug mp1 4977 matroska tag info uses the wrong casing for tags by doskabouter · Pull Request #182 · MediaPortal/MediaPortal-1

    Still needs some discussion, as this is a breaking change.
    I could add something that is able to read old-style xml's and optionally save them as correct ones?

    What do you guys think?

    Steps to Reproduce:
    Play a video downloaded by onlinevideos with the videos-plugin
     

    azzuro

    Test Group
  • Team MediaPortal
  • May 10, 2007
    9,885
    5,544
    France - IDF
    Home Country
    France France
    Country flag
    hello @doskabouter
    thank you for providing support,
    can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
    thank you.

    ps: what result we will have actually when trying to play with onlinevideos ?
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    4,023
    2,260
    Nuenen
    Home Country
    Netherlands Netherlands
    Country flag
    hello @doskabouter
    thank you for providing support,
    can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
    thank you.

    ps: what result we will have actually when trying to play with onlinevideos ?

    Are there relevant changes in that area in the test3 branch then?
    And for onlinevideos there will not be any differences. the wrong casing is in mediaportal
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    4,023
    2,260
    Nuenen
    Home Country
    Netherlands Netherlands
    Country flag
    Good idea :)

    Any more opinions on this?
    there are 3 choices:

    1: Create separate a tool that fixes the xmlfiles, and have it run at install/update
    2: When MP encounters a wrong-cased xmlfile fix it and save it
    3: Support both wrong-cased and correctly-cased xmlfiles

    In my opinion option 1 is the best one, and reduces the legacy stuff we have to maintain in mediaportal

    It's also the hardest one to integrate in the update process.
    Options 1 and 2 also make it impossible to downgrade Mediaportal.

    So I guess we'll end up with option 3 and have another piece of legacy we have to maintain, test and keep working,,,
    Unless ofcourse someone has a brilliant option 4 or a strong opinion on options 1 or 2
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    13,974
    8,529
    Kyiv
    Home Country
    Ukraine Ukraine
    Country flag
    How determine where files from OnlineVideos stored? When MP installed some resources maybe not work... NAS shutdown ... etc...
    IMHO support old and new better ...

    --
    WBR, ajs :):whistle::coffee:
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    4,023
    2,260
    Nuenen
    Home Country
    Netherlands Netherlands
    Country flag
    I think you're misunderstanding me. The files from onlinevideos are correct, it's the files created by mediaportal that are wrong.
    But apart from that, I think you're right about option 3 (reluctantly...). Anyone else want to give me their opinion?
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    13,974
    8,529
    Kyiv
    Home Country
    Ukraine Ukraine
    Country flag
    I dont use OV for download, and dont know where and how this XML stored and used :)

    --
    WBR, ajs :):whistle::coffee:
     

    CyberSimian

    Test Group
  • Team MediaPortal
  • June 10, 2013
    2,346
    1,428
    Southampton
    Home Country
    United Kingdom United Kingdom
    Country flag
    Anyone else want to give me their opinion?
    I too have no idea what this is all about, but my view is that upward compatibility should be mandatory in all circumstances. :eek: :eek: :eek:

    Yes, that means that there is legacy code in the product, but being legacy code also means that it should not need changing in the future (it's legacy -- it merely needs to be invoked when the circumstances demand it). So, the product is bigger than it need be, but in the era of multi-gigabyte RAM installations, who cares?

    We do users a disservice if we change things without maintaining compatibility with what went before.

    -- from CyberSimian in the UK
     

    Users who are viewing this thread

    Similar threads

    I dont know... -- Tapatalk | WBR, ajs
    I dont know... -- Tapatalk | WBR, ajs
    Before you create this bug report: Make sure that your system (windows, codecs and drivers) is up to date, matching the...
    Replies
    5
    Views
    660
    Updated one of my MP installations (from 1.15) to 1.24 Final recently. It went perfectly smoothly, and fixed a few problems I had been having with video playback. Updated my plugins and Streamed MP skin, and not a single issue. Thank you for all your hard work.
    Updated one of my MP installations (from 1.15) to 1.24 Final recently. It went perfectly smoothly, and fixed a few problems I had...
    We have just released MediaPortal 1.24 Final Highlights of this release Bugfixes: [MP1-4969] - Fix typo in MyMusic DB Index...
    Replies
    3
    Views
    3K
    Pre Releases are provided as a way for the community to test and give feedback on all the exciting things we have lined up for the next release. We allocate about one month for Pre Release testing. In that time we will only fix bugs, after which comes the final release! Highlights of this release Bugfixes: [MP1-4969] - Fix typo in...
    Pre Releases are provided as a way for the community to test and give feedback on all the exciting things we have lined up for the...
    Pre Releases are provided as a way for the community to test and give feedback on all the exciting things we have lined up for the...
    Replies
    0
    Views
    2K
    Ok, just done some more mucking around. turns out my logitech mouse seems to be extremely unresponsive in media portal. Can use my keyboard just fine (also lightspeed wireless). Suggestions?
    Ok, just done some more mucking around. turns out my logitech mouse seems to be extremely unresponsive in media portal. Can use my...
    Good evening, having just fresh installed media portal 2.3.2. Looking at trialing again as it now seems to support what I am...
    Replies
    1
    Views
    136
    There was no change obviously related to it, but maybe something as the fixed user management or similar made it.
    There was no change obviously related to it, but maybe something as the fixed user management or similar made it.
    Before you create this bug report: Make sure that your system (Windows, codecs and drivers) is up to date, matching the...
    Replies
    7
    Views
    643
    Top Bottom